fix: correct Vue node selection box detection accuracy#7741
Merged
Conversation
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (15)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughRemoved redundant addition of node title height from layout → LiteGraph synchronization; layout sizes now use Changes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 12/23/2025, 08:16:44 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/23/2025, 08:05:18 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
dosubot
bot
added
the
size:XS
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.19 MB (baseline 3.19 MB) • 🟢 -151 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 996 kB (baseline 996 kB) • 🟢 -83 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 295 kB (baseline 295 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 196 kB (baseline 196 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 9.1 MB (baseline 9.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.44 MB (baseline 3.44 MB) • ⚪ 0 BBundles that do not match a named category
Status: 20 added / 20 removed |
dosubot
bot
added
size:S
jtydhr88
added
the
New Browser Test Expectations
|
Updating Playwright Expectations |
github-actions
bot
removed
the
New Browser Test Expectations
DrJKL
approved these changes
Dec 23, 2025
Yourz
pushed a commit
that referenced
this pull request
Dec 24, 2025
## Summary Remove double-counting of NODE_TITLE_HEIGHT in layout sync. The title height was being added both in useLayoutSync and in LiteGraph's measure() function, causing boundingRect to be 30px taller than actual DOM. This caused selection box to detect nodes ~30px below their actual bottom. fix #7580 ## Screenshots (if applicable) before https://github.com/user-attachments/assets/babf0b9d-174e-4ec3-a3bb-18e4f9d88d09 after https://github.com/user-attachments/assets/4f9989a5-4d3c-4303-bd1b-70ca70cb8f15 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7741-fix-correct-Vue-node-selection-box-detection-accuracy-2d26d73d3650817cbe80f98a3bf1abf1) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <github-actions@github.com>
1 task
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove double-counting of NODE_TITLE_HEIGHT in layout sync. The title height was being added both in useLayoutSync and in LiteGraph's measure() function, causing boundingRect to be 30px taller than actual DOM.
This caused selection box to detect nodes ~30px below their actual bottom.
fix #7580
Screenshots (if applicable)
before
2025-12-23.14-39-10.mp4
after
2025-12-23.14-37-42.mp4
┆Issue is synchronized with this Notion page by Unito