Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document registerCustomNodes to reflect LGraphNode ES6 class conversion #772

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

christian-byrne
Copy link
Collaborator

Updated doc comment to indicate that custom node classes need to subclass LGraphNode (since Comfy-Org/litegraph.js#98). The litegraph type for registerNodeType is already correct.

Related Issues:

@huchenlei
Copy link
Member

This PR is merged 3100m on Mt. Fuji.
Uploading IMG_2720.jpeg…

@huchenlei huchenlei merged commit 90abf97 into main Sep 10, 2024
6 checks passed
@huchenlei huchenlei deleted the update-custom-node-type branch September 10, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants