refactor node help watch source by benceruleanlu · Pull Request #7660 · Comfy-Org/ComfyUI_frontend

benceruleanlu · 2025-12-20T04:45:51Z

Extract the node help watch source into a computed value.

What changed

Move the watch predicate in NodeHelpPage.vue into a named activeHelpDef computed and pass it to whenever
Keep behavior identical while making the watch source easier to read and reference

Why

Motivation: a review comment requested separating the predicate from the watcher for readability and idiomatic usage
Why this approach: a local computed is the smallest change that preserves behavior and matches the requested structure
Tradeoffs / limitations: adds a couple of lines and a computed without changing runtime behavior

Evidence

Tests: Not run (existing unit tests for help sync live in tests-ui/tests/components/sidebar/nodeLibrary/NodeHelpPage.test.ts)

References

Review comment: Sync node help with selection and add watcher tests #7105 (comment) (request to extract the watcher predicate into a computed)
Related PR: Sync node help with selection and add watcher tests #7105 (original help sync change)

coderabbitai · 2025-12-20T04:45:56Z

📝 Walkthrough

Walkthrough

Replaces an inline conditional watcher in NodeHelpPage.vue with a computed property activeHelpDef (derived from nodeHelpStore.isHelpOpen and nodeDef) and uses whenever to subscribe to that computed, preserving synchronization of the open help page with the selected node.

Changes

Cohort / File(s)	Summary
Vue component watcher refactor `src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue`	Remove inline conditional watcher; add computed `activeHelpDef` (depends on `nodeHelpStore.isHelpOpen` and `nodeDef`) and switch `whenever` to subscribe to `activeHelpDef` to keep help page synchronized.

Possibly related PRs

Sync node help with selection and add watcher tests #7105: Modifies NodeHelpPage.vue watcher logic to use a computed-triggered whenever for syncing open help with the current selection.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch refactor/node-help-active-def-stacked

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1708602 and d7c6c34.

📒 Files selected for processing (1)

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue (2 hunks)

🧰 Additional context used

📓 Path-based instructions (12)

src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

**/*.vue

📄 CodeRabbit inference engine (AGENTS.md)

**/*.vue: Use Vue 3.5+ with TypeScript in .vue files, exclusively using Composition API with <script setup lang="ts"> syntax
Use Tailwind 4 for styling in Vue components; avoid <style> blocks
Name Vue components using PascalCase (e.g., MenuHamburger.vue)
Use Vue 3.5 TypeScript-style default prop declaration with reactive props destructuring; do not use withDefaults or runtime props declaration
Prefer computed() over ref with watch when deriving values
Prefer useModel over separately defining prop and emit for two-way binding
Use vue-i18n in composition API for string literals; place new translation entries in src/locales/en/main.json
Use cn() utility function from @/utils/tailwindUtil for merging Tailwind class names; do not use :class="[]" syntax
Do not use the dark: Tailwind variant; use semantic values from the style.css theme instead (e.g., bg-node-component-surface)
Do not use !important or the ! important prefix for Tailwind classes; find and correct interfering !important classes instead
Avoid new usage of PrimeVue components; use VueUse, shadcn/vue, or Reka UI instead
Leverage VueUse functions for performance-enhancing styles in Vue components
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,vue}: Use TypeScript exclusively; do not write new JavaScript code
Use sorted and grouped imports organized by plugin/source
Enforce ESLint rules including Vue + TypeScript rules, disallow floating promises, disallow unused imports, and restrict i18n raw text in templates
Do not use any type or as any type assertions; fix the underlying type issue instead
Write code that is expressive and self-documenting; avoid redundant comments and clean as you go
Keep functions short and functional; minimize nesting and follow the arrow anti-pattern
Avoid mutable state; prefer immutability and assignment at point of declaration
Use function declarations instead of function expressions when possible
Use es-toolkit for utility functions
Implement proper error handling in code

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

**/*.{ts,tsx,vue,js,jsx,json,css}

📄 CodeRabbit inference engine (AGENTS.md)

Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, and 80-character line width

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

🧠 Learnings (19)

📓 Common learnings

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.548Z
Learning: Applies to **/*.vue : Prefer `computed()` over `ref` with `watch` when deriving values

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Extract complex conditionals to computed properties

📚 Learning: 2025-12-21T06:04:12.548Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.548Z
Learning: Applies to **/*.vue : Prefer `computed()` over `ref` with `watch` when deriving values

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-09T03:49:52.828Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use setup() function in Vue 3 Composition API

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-21T06:04:12.548Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-21T06:04:12.548Z
Learning: Applies to **/*.vue : Use Vue 3.5+ with TypeScript in `.vue` files, exclusively using Composition API with `<script setup lang="ts">` syntax

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Implement computed() for derived state in Vue 3 Composition API

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use setup() function for component logic

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Extract complex conditionals to computed properties

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement computed properties with computed()

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-09T21:40:12.361Z

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-16T22:26:49.463Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-18T02:07:38.870Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-18T21:15:46.862Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-21T01:06:02.786Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-18T16:03:02.066Z

Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: setup
GitHub Check: lint-and-format
GitHub Check: test
GitHub Check: collect

🔇 Additional comments (1)

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue (1)

24-24: Excellent refactor that aligns with Vue best practices!

The extraction of the watch predicate into a named computed property improves readability and follows the repository's coding guidelines. The implementation is correct:

activeHelpDef clearly expresses the derived state (the active node definition when help is open)

whenever now has a semantic, reusable watch source instead of an inline condition

The early-return check on line 47 correctly prevents redundant openHelp calls

Type safety is preserved—whenever guarantees def is truthy in the callback

Based on learnings: This change follows the guideline "Prefer computed() over ref with watch when deriving values" and "Extract complex conditionals to computed properties."

Also applies to: 40-49

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

benceruleanlu · 2025-12-20T04:46:08Z

refactor node help watch source #7660 👈 (View in Graphite)
Sync node help with selection and add watcher tests #7105
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-12-20T04:46:09Z

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 12/21/2025, 06:48:37 PM UTC

📈 Summary

Total Tests: 505
Passed: 491 ✅
Failed: 1 ❌
Flaky: 5 ⚠️
Skipped: 8 ⏭️

📊 Test Reports by Browser

✅ chromium: View Report • ✅ 479 / ❌ 1 / ⚠️ 5 / ⏭️ 8
✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ mobile-chrome: View Report • ✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

github-actions · 2025-12-20T04:46:10Z

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/21/2025, 06:39:47 PM UTC

🔗 Links

📊 View Workflow Run
🎨 View Storybook

🎉 Your Storybook is ready for review!

Copilot

Pull request overview

This PR refactors the node help watch source by extracting an inline arrow function into a named computed property for improved readability and maintainability.

Extracted the watch source logic into a separate activeHelpDef computed property
Added the computed import from Vue
Maintained identical functionality while improving code clarity

benceruleanlu · 2025-12-20T04:52:47Z

minor graphite mistake

github-actions · 2025-12-20T05:00:49Z

Bundle Size Report

Summary

Raw size: 17.3 MB baseline 17.3 MB — 🔴 +11 B
Gzip: 3.53 MB baseline 3.53 MB — 🔴 +66 B
Brotli: 2.69 MB baseline 2.69 MB — 🟢 -281 B
Bundles: 98 current • 98 baseline • 42 added / 42 removed

Category Glance
App Entry Points 🔴 +11 B (3.22 MB) · Vendor & Third-Party ⚪ 0 B (9.1 MB) · Other ⚪ 0 B (3.44 MB) · Graph Workspace ⚪ 0 B (993 kB) · Panels & Settings ⚪ 0 B (297 kB) · UI Components ⚪ 0 B (186 kB) · + 3 more

Per-category breakdown

App Entry Points — 3.22 MB (baseline 3.22 MB) • 🔴 +11 B

Main entry bundles and manifests

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/index-CYZ9xDBB.js (new)	—	2.99 MB	🔴 +2.99 MB	🔴 +631 kB	🔴 +480 kB
~~assets/index-CRPAyso3.js~~ (removed)	2.99 MB	—	🟢 -2.99 MB	🟢 -631 kB	🟢 -480 kB
assets/index-JD_Vc4ZT.js (new)	—	228 kB	🔴 +228 kB	🔴 +48.8 kB	🔴 +40 kB
~~assets/index-x8X2_Kgo.js~~ (removed)	228 kB	—	🟢 -228 kB	🟢 -48.7 kB	🟢 -40.1 kB
assets/index-Dr51J1ZY.js (new)	—	345 B	🔴 +345 B	🔴 +246 B	🔴 +234 B
~~assets/index-DsPJ9rHe.js~~ (removed)	345 B	—	🟢 -345 B	🟢 -246 B	🟢 -210 B

Status: 3 added / 3 removed

Graph Workspace — 993 kB (baseline 993 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/GraphView-1LVXRMF4.js~~ (removed)	993 kB	—	🟢 -993 kB	🟢 -194 kB	🟢 -148 kB
assets/GraphView-DIUfWY_e.js (new)	—	993 kB	🔴 +993 kB	🔴 +194 kB	🔴 +148 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/UserSelectView-Bs9vzYb4.js (new)	—	6.54 kB	🔴 +6.54 kB	🔴 +2.14 kB	🔴 +1.9 kB
~~assets/UserSelectView-BwIWQRKS.js~~ (removed)	6.54 kB	—	🟢 -6.54 kB	🟢 -2.14 kB	🟢 -1.9 kB

Status: 1 added / 1 removed

Panels & Settings — 297 kB (baseline 297 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/LegacyCreditsPanel-D78YhPVE.js~~ (removed)	21.4 kB	—	🟢 -21.4 kB	🟢 -5.16 kB	🟢 -4.51 kB
assets/LegacyCreditsPanel-DH6daaCB.js (new)	—	21.4 kB	🔴 +21.4 kB	🔴 +5.16 kB	🔴 +4.51 kB
assets/KeybindingPanel--gLiMhaW.js (new)	—	13.6 kB	🔴 +13.6 kB	🔴 +3.42 kB	🔴 +3.02 kB
~~assets/KeybindingPanel-C376suAk.js~~ (removed)	13.6 kB	—	🟢 -13.6 kB	🟢 -3.42 kB	🟢 -3.02 kB
assets/ExtensionPanel-l0QBh1Sx.js (new)	—	10.8 kB	🔴 +10.8 kB	🔴 +2.57 kB	🔴 +2.25 kB
~~assets/ExtensionPanel-OBmMurXD.js~~ (removed)	10.8 kB	—	🟢 -10.8 kB	🟢 -2.57 kB	🟢 -2.24 kB
assets/AboutPanel-6W0Cdiwc.js (new)	—	9.16 kB	🔴 +9.16 kB	🔴 +2.46 kB	🔴 +2.21 kB
~~assets/AboutPanel-D5hwPoiM.js~~ (removed)	9.16 kB	—	🟢 -9.16 kB	🟢 -2.46 kB	🟢 -2.21 kB
assets/ServerConfigPanel-BbtvBgIj.js (new)	—	7.07 kB	🔴 +7.07 kB	🔴 +1.98 kB	🔴 +1.76 kB
~~assets/ServerConfigPanel-Dte0_tFn.js~~ (removed)	7.07 kB	—	🟢 -7.07 kB	🟢 -1.98 kB	🟢 -1.76 kB
~~assets/UserPanel-D9KS9Ibd.js~~ (removed)	6.23 kB	—	🟢 -6.23 kB	🟢 -1.72 kB	🟢 -1.5 kB
assets/UserPanel-DOXecGDN.js (new)	—	6.23 kB	🔴 +6.23 kB	🔴 +1.72 kB	🔴 +1.5 kB
assets/settings-BhbWhsRg.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BvFz-TmQ.js	33.1 kB	33.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BxYnTA2y.js	21.5 kB	21.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C6bMjAne.js	27.1 kB	27.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C7Yhp7H7.js	24 kB	24 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CsnOn8G0.js	25.7 kB	25.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-D5BGNZ7M.js	24.8 kB	24.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-D7k3huHm.js	25 kB	25 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DamkILzl.js	26.4 kB	26.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-s1k0gw1Y.js	20.9 kB	20.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

UI Components — 186 kB (baseline 186 kB) • ⚪ 0 B

Reusable component library chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-7zGzxg3l.js (new)	—	54.3 kB	🔴 +54.3 kB	🔴 +8.62 kB	🔴 +7.41 kB
~~assets/Load3D.vue_vue_type_script_setup_true_lang-lu_XnsUS.js~~ (removed)	54.3 kB	—	🟢 -54.3 kB	🟢 -8.62 kB	🟢 -7.42 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-C1zBzLYx.js (new)	—	50 kB	🔴 +50 kB	🔴 +11 kB	🔴 +9.64 kB
~~assets/LazyImage.vue_vue_type_script_setup_true_lang-CftIieqx.js~~ (removed)	50 kB	—	🟢 -50 kB	🟢 -11 kB	🟢 -9.63 kB
~~assets/WidgetSelect.vue_vue_type_script_setup_true_lang-CB5XTs6R.js~~ (removed)	48.8 kB	—	🟢 -48.8 kB	🟢 -10.5 kB	🟢 -9.13 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-DQ50Sxip.js (new)	—	48.8 kB	🔴 +48.8 kB	🔴 +10.5 kB	🔴 +9.13 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-CSiDfQ79.js (new)	—	14.3 kB	🔴 +14.3 kB	🔴 +3.74 kB	🔴 +3.29 kB
~~assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DV4FbEfg.js~~ (removed)	14.3 kB	—	🟢 -14.3 kB	🟢 -3.73 kB	🟢 -3.29 kB
assets/ComfyQueueButton-ChzQp3nr.js (new)	—	8.45 kB	🔴 +8.45 kB	🔴 +2.47 kB	🔴 +2.2 kB
~~assets/ComfyQueueButton-DhXmqiP5.js~~ (removed)	8.45 kB	—	🟢 -8.45 kB	🟢 -2.47 kB	🟢 -2.2 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-Dg5Pg2FH.js (new)	—	3.68 kB	🔴 +3.68 kB	🔴 +1.45 kB	🔴 +1.31 kB
~~assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-HkBDysp3.js~~ (removed)	3.68 kB	—	🟢 -3.68 kB	🟢 -1.45 kB	🟢 -1.31 kB
~~assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-4_up1okB.js~~ (removed)	2.14 kB	—	🟢 -2.14 kB	🟢 -888 B	🟢 -767 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-CwBMcln4.js (new)	—	2.14 kB	🔴 +2.14 kB	🔴 +889 B	🔴 +777 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-BflvA4Km.js (new)	—	897 B	🔴 +897 B	🔴 +503 B	🔴 +434 B
~~assets/MediaTitle.vue_vue_type_script_setup_true_lang-CnHL_M9Q.js~~ (removed)	897 B	—	🟢 -897 B	🟢 -503 B	🟢 -470 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-DymEwRe0.js	1.34 kB	1.34 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetButton-U5ly29Pt.js	2.04 kB	2.04 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 8 added / 8 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/keybindingService-D2P3bKTb.js (new)	—	7.51 kB	🔴 +7.51 kB	🔴 +1.83 kB	🔴 +1.57 kB
~~assets/keybindingService-DtKElWf1.js~~ (removed)	7.51 kB	—	🟢 -7.51 kB	🟢 -1.83 kB	🟢 -1.58 kB
~~assets/audioService-BEkOML7l.js~~ (removed)	2.2 kB	—	🟢 -2.2 kB	🟢 -960 B	🟢 -822 B
assets/audioService-BWXowEyS.js (new)	—	2.2 kB	🔴 +2.2 kB	🔴 +961 B	🔴 +826 B
assets/serverConfigStore-7JI8VFS2.js	2.83 kB	2.83 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/audioUtils-BjdoEgMY.js~~ (removed)	1.41 kB	—	🟢 -1.41 kB	🟢 -651 B	🟢 -551 B
assets/audioUtils-C9tQ6w1z.js (new)	—	1.41 kB	🔴 +1.41 kB	🔴 +654 B	🔴 +548 B

Status: 1 added / 1 removed

Vendor & Third-Party — 9.1 MB (baseline 9.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/vendor-chart-DaR9dw3X.js	452 kB	452 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-other-Cf7iqkoX.js	3.86 MB	3.86 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-primevue-BIgr9yoj.js	1.96 MB	1.96 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-three-DYL0ZbEr.js	2.02 MB	2.02 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-tiptap-C1NB2Q_L.js	232 kB	232 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-vue-DSfeuQOV.js	160 kB	160 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-xterm-BF8peZ5_.js	420 kB	420 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Other — 3.44 MB (baseline 3.44 MB) • ⚪ 0 B

Bundles that do not match a named category

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/SubscriptionRequiredDialogContent-B37n4waH.js~~ (removed)	28 kB	—	🟢 -28 kB	🟢 -6.34 kB	🟢 -5.5 kB
assets/SubscriptionRequiredDialogContent-B3uMIiu9.js (new)	—	28 kB	🔴 +28 kB	🔴 +6.34 kB	🔴 +5.49 kB
assets/WidgetRecordAudio-BRxIWzMw.js (new)	—	20.4 kB	🔴 +20.4 kB	🔴 +5.24 kB	🔴 +4.63 kB
~~assets/WidgetRecordAudio-DdDPDNUV.js~~ (removed)	20.4 kB	—	🟢 -20.4 kB	🟢 -5.24 kB	🟢 -4.63 kB
~~assets/AudioPreviewPlayer-BxGRKvc3.js~~ (removed)	13.3 kB	—	🟢 -13.3 kB	🟢 -3.35 kB	🟢 -2.99 kB
assets/AudioPreviewPlayer-CZVZ_-LI.js (new)	—	13.3 kB	🔴 +13.3 kB	🔴 +3.35 kB	🔴 +3 kB
~~assets/ValueControlPopover-BSqxTWS3.js~~ (removed)	5.49 kB	—	🟢 -5.49 kB	🟢 -1.7 kB	🟢 -1.52 kB
assets/ValueControlPopover-BZU5HWCB.js (new)	—	5.49 kB	🔴 +5.49 kB	🔴 +1.7 kB	🔴 +1.51 kB
~~assets/WidgetGalleria-DgJmQ4zl.js~~ (removed)	4.1 kB	—	🟢 -4.1 kB	🟢 -1.45 kB	🟢 -1.3 kB
assets/WidgetGalleria-Un0Vbk2E.js (new)	—	4.1 kB	🔴 +4.1 kB	🔴 +1.45 kB	🔴 +1.31 kB
~~assets/WidgetColorPicker-CMU__Oov.js~~ (removed)	3.41 kB	—	🟢 -3.41 kB	🟢 -1.38 kB	🟢 -1.23 kB
assets/WidgetColorPicker-CzEQ8fbW.js (new)	—	3.41 kB	🔴 +3.41 kB	🔴 +1.38 kB	🔴 +1.23 kB
~~assets/WidgetTextarea-Cy6Kmpz8.js~~ (removed)	3.08 kB	—	🟢 -3.08 kB	🟢 -1.21 kB	🟢 -1.08 kB
assets/WidgetTextarea-DRm8v1xT.js (new)	—	3.08 kB	🔴 +3.08 kB	🔴 +1.22 kB	🔴 +1.08 kB
~~assets/WidgetMarkdown-CCrBQFiJ.js~~ (removed)	3.08 kB	—	🟢 -3.08 kB	🟢 -1.28 kB	🟢 -1.13 kB
assets/WidgetMarkdown-Dy1oQXuz.js (new)	—	3.08 kB	🔴 +3.08 kB	🔴 +1.28 kB	🔴 +1.13 kB
~~assets/WidgetAudioUI-CPsxgaw7.js~~ (removed)	2.89 kB	—	🟢 -2.89 kB	🟢 -1.17 kB	🟢 -1.06 kB
assets/WidgetAudioUI-J4gAA8B1.js (new)	—	2.89 kB	🔴 +2.89 kB	🔴 +1.17 kB	🔴 +1.06 kB
~~assets/WidgetInputText-Cj0y_z_O.js~~ (removed)	1.99 kB	—	🟢 -1.99 kB	🟢 -920 B	🟢 -853 B
assets/WidgetInputText-JoKy1y15.js (new)	—	1.99 kB	🔴 +1.99 kB	🔴 +922 B	🔴 +849 B
assets/WidgetToggleSwitch-C1fwmjKg.js (new)	—	1.76 kB	🔴 +1.76 kB	🔴 +834 B	🔴 +735 B
~~assets/WidgetToggleSwitch-DyxJLzOm.js~~ (removed)	1.76 kB	—	🟢 -1.76 kB	🟢 -834 B	🟢 -728 B
assets/MediaImageBottom-Bf1lcu6q.js (new)	—	1.55 kB	🔴 +1.55 kB	🔴 +735 B	🔴 +638 B
~~assets/MediaImageBottom-BY84lmau.js~~ (removed)	1.55 kB	—	🟢 -1.55 kB	🟢 -735 B	🟢 -637 B
assets/MediaAudioBottom-B7c7-ysO.js (new)	—	1.51 kB	🔴 +1.51 kB	🔴 +731 B	🔴 +645 B
~~assets/MediaAudioBottom-DQum3qn8.js~~ (removed)	1.51 kB	—	🟢 -1.51 kB	🟢 -732 B	🟢 -644 B
~~assets/Media3DBottom-D00LRIC4.js~~ (removed)	1.5 kB	—	🟢 -1.5 kB	🟢 -730 B	🟢 -644 B
assets/Media3DBottom-DCkZuKIB.js (new)	—	1.5 kB	🔴 +1.5 kB	🔴 +730 B	🔴 +645 B
assets/MediaVideoBottom-CMYWDP3h.js (new)	—	1.5 kB	🔴 +1.5 kB	🔴 +732 B	🔴 +646 B
~~assets/MediaVideoBottom-DNaFw2Zs.js~~ (removed)	1.5 kB	—	🟢 -1.5 kB	🟢 -731 B	🟢 -647 B
assets/Media3DTop-BHsf7S0V.js (new)	—	1.49 kB	🔴 +1.49 kB	🔴 +765 B	🔴 +651 B
~~assets/Media3DTop-C7hgO2NB.js~~ (removed)	1.49 kB	—	🟢 -1.49 kB	🟢 -767 B	🟢 -653 B
assets/WidgetSelect-C2hKRC8A.js (new)	—	733 B	🔴 +733 B	🔴 +364 B	🔴 +306 B
~~assets/WidgetSelect-Ctp6tGrk.js~~ (removed)	733 B	—	🟢 -733 B	🟢 -361 B	🟢 -325 B
assets/WidgetInputNumber-Cdoq11L8.js (new)	—	673 B	🔴 +673 B	🔴 +349 B	🔴 +289 B
~~assets/WidgetInputNumber-CubPmmR4.js~~ (removed)	673 B	—	🟢 -673 B	🟢 -348 B	🟢 -290 B
assets/Load3D-CJ-Dh5nd.js (new)	—	424 B	🔴 +424 B	🔴 +268 B	🔴 +222 B
~~assets/Load3D-CZJ2PB2G.js~~ (removed)	424 B	—	🟢 -424 B	🟢 -268 B	🟢 -222 B
~~assets/WidgetLegacy-DpWmwQ7f.js~~ (removed)	364 B	—	🟢 -364 B	🟢 -238 B	🟢 -197 B
assets/WidgetLegacy-K3P_KCTn.js (new)	—	364 B	🔴 +364 B	🔴 +238 B	🔴 +197 B
assets/commands-BWp4HdfU.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CcfGaui5.js	14.4 kB	14.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CisfgZf5.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CkU12Foh.js	13 kB	13 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CoH2DJa6.js	14.2 kB	14.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-COSt-Bjx.js	14.9 kB	14.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DalfIW5f.js	15.9 kB	15.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DfTl0eCm.js	13.5 kB	13.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DwSJL865.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-Zxyx15Vd.js	12.8 kB	12.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BDhxs-bB.js	79.9 kB	79.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BtXVDFw6.js	84.7 kB	84.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Buv6RhU4.js	82.4 kB	82.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CgJ6zvJL.js	97.2 kB	97.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CI9qb0E5.js	112 kB	112 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cu4LqtW0.js	81.6 kB	81.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cw9RZWRY.js	89 B	89 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Dm19QY4N.js	92.2 kB	92.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Tihe0h_r.js	71.3 kB	71.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-wPWMutMw.js	70.4 kB	70.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaAudioTop-Dr0afgCA.js	1.46 kB	1.46 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaImageTop-BXa-oKEc.js	1.75 kB	1.75 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaVideoTop-BVdg2b8C.js	2.65 kB	2.65 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-1Vh3MCrN.js	240 kB	240 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-aW9En70v.js	260 kB	260 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BIckSVgU.js	273 kB	273 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BiYpVi7D.js	263 kB	263 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CCEXtYfM.js	243 kB	243 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CvmVDWYd.js	323 kB	323 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-D_wreoPJ.js	267 kB	267 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Dz-0ZIBN.js	297 kB	297 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-VZsNmhG7.js	264 kB	264 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetChart-BU__hen8.js	2.48 kB	2.48 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetImageCompare-0zJeINY-.js	2.21 kB	2.21 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js	1.28 kB	1.28 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 20 added / 20 removed

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f6bc10b and 1708602.

📒 Files selected for processing (1)

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue (2 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

src/**/*.vue: Vue 3 SFCs must use Composition API only - no Options API
Use <script setup lang="ts"> for component logic
Use Tailwind 4 utility classes for styling - avoid <style> blocks
Use cn() utility from @/utils/tailwindUtil to merge Tailwind class names - never use :class="[]" syntax
Never use the dark: Tailwind variant - use semantic values from style.css theme instead (e.g., bg-node-component-surface)
Use Vue 3.5+ TypeScript style default prop declaration with reactive destructuring - prefer useModel to prop/emit pairs, do not use withDefaults
Do not import Vue macros unnecessarily
Use vue-i18n in composition API for string literals - place translation entries in src/locales/en/main.json
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Avoid new usage of PrimeVue components

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

src/**/*.{vue,ts}: Avoid using ref and watch together - use computed instead if possible
Do not add ref if a prop would suffice; do not add computed if the ref/prop directly would work; use watch only when computed won't accomplish the goal
Leverage VueUse functions for performance-enhancing styles

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates
Use es-toolkit for utility functions
Avoid mutable state - prefer immutability and assignment at point of declaration
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Vue components must be named in PascalCase (e.g., MenuHamburger.vue)

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/*.{js,ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript exclusively - no new JavaScript files

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

src/**/*.{ts,tsx,vue,js}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx,vue,js}: Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see .prettierrc
Sort and group imports by plugin, run pnpm format before committing

Files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

🧠 Learnings (16)

📓 Common learnings

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Avoid using `ref` and `watch` together - use `computed` instead if possible

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Extract complex conditionals to computed properties

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Do not add `ref` if a prop would suffice; do not add `computed` if the ref/prop directly would work; use `watch` only when `computed` won't accomplish the goal

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.vue : Use `<script setup lang="ts">` for component logic

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-09T03:49:52.828Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Use setup() function in Vue 3 Composition API

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Implement computed() for derived state in Vue 3 Composition API

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use setup() function for component logic

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Avoid using `ref` and `watch` together - use `computed` instead if possible

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Extract complex conditionals to computed properties

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-09T21:40:12.361Z

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-16T22:26:49.463Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-18T02:07:38.870Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-18T21:15:46.862Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

📚 Learning: 2025-12-18T16:03:02.066Z

Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.

Applied to files:

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: setup
GitHub Check: lint-and-format
GitHub Check: collect
GitHub Check: test

🔇 Additional comments (1)

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue (1)

24-24: Excellent refactoring to use computed property.

This change follows the guideline to use computed instead of ref + watch together. Extracting the conditional logic (isHelpOpen ? nodeDef.value : null) into a dedicated computed property separates concerns cleanly and makes the reactive dependencies explicit.

Based on learnings: "Avoid using ref and watch together - use computed instead if possible" and "Extract complex conditionals to computed properties."

Also applies to: 40-42

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

Co-authored-by: Christian Byrne <cbyrne@comfy.org>

christian-byrne

LGTM

Extract the node help watch source into a computed value. ## What changed - Move the watch predicate in `NodeHelpPage.vue` into a named `activeHelpDef` computed and pass it to `whenever` - Keep behavior identical while making the watch source easier to read and reference ## Why - Motivation: a review comment requested separating the predicate from the watcher for readability and idiomatic usage - Why this approach: a local computed is the smallest change that preserves behavior and matches the requested structure - Tradeoffs / limitations: adds a couple of lines and a computed without changing runtime behavior ## Evidence - Tests: Not run (existing unit tests for help sync live in `tests-ui/tests/components/sidebar/nodeLibrary/NodeHelpPage.test.ts`) ## References - Review comment: #7105 (comment) (request to extract the watcher predicate into a computed) - Related PR: #7105 (original help sync change) --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org>

benceruleanlu requested a review from a team as a code owner December 20, 2025 04:45

Copilot AI review requested due to automatic review settings December 20, 2025 04:45

dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 20, 2025

benceruleanlu mentioned this pull request Dec 20, 2025

Sync node help with selection and add watcher tests #7105

Merged

Copilot started reviewing on behalf of benceruleanlu December 20, 2025 04:46 View session

Copilot AI reviewed Dec 20, 2025

View reviewed changes

Base automatically changed from feat/help-help-sync to main December 20, 2025 04:51

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 20, 2025

refactor node help watch source

1708602

benceruleanlu force-pushed the refactor/node-help-active-def-stacked branch from 78b918f to 1708602 Compare December 20, 2025 04:58

dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 20, 2025

coderabbitai bot reviewed Dec 20, 2025

View reviewed changes

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue Show resolved Hide resolved

christian-byrne reviewed Dec 20, 2025

View reviewed changes

src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue Outdated Show resolved Hide resolved

Update src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue

d7c6c34

Co-authored-by: Christian Byrne <cbyrne@comfy.org>

benceruleanlu requested a review from christian-byrne December 21, 2025 18:38

christian-byrne approved these changes Dec 22, 2025

View reviewed changes

christian-byrne merged commit d253f67 into main Dec 22, 2025
26 of 27 checks passed

christian-byrne deleted the refactor/node-help-active-def-stacked branch December 22, 2025 10:12

christian-byrne mentioned this pull request Jan 5, 2026

Bump comfyui-frontend-package to 1.36.13 Comfy-Org/ComfyUI#11645

Merged

coderabbitai bot mentioned this pull request Jan 16, 2026

Decouple node help between sidebar and right panel #8110

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor node help watch source#7660

refactor node help watch source#7660
christian-byrne merged 2 commits intomainfrom
refactor/node-help-active-def-stacked

benceruleanlu commented Dec 20, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 20, 2025 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Uh oh!

benceruleanlu commented Dec 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

benceruleanlu commented Dec 20, 2025

Uh oh!

github-actions bot commented Dec 20, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

christian-byrne left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

benceruleanlu commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Why

Evidence

References

Uh oh!

coderabbitai bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Uh oh!

benceruleanlu commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

📈 Summary

📊 Test Reports by Browser

Uh oh!

github-actions bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🔗 Links

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

benceruleanlu commented Dec 20, 2025

Uh oh!

github-actions bot commented Dec 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Report

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

christian-byrne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

benceruleanlu commented Dec 20, 2025 •

edited

Loading

coderabbitai bot commented Dec 20, 2025 •

edited

Loading

benceruleanlu commented Dec 20, 2025 •

edited

Loading

github-actions bot commented Dec 20, 2025 •

edited

Loading

github-actions bot commented Dec 20, 2025 •

edited

Loading

github-actions bot commented Dec 20, 2025 •

edited

Loading