Skip to content

[backport core/1.35] Prevent sidebar tool buttons from flashing during collapse#7654

Merged
christian-byrne merged 1 commit intocore/1.35from
backport-7652-to-core-1.35
Dec 20, 2025
Merged

[backport core/1.35] Prevent sidebar tool buttons from flashing during collapse#7654
christian-byrne merged 1 commit intocore/1.35from
backport-7652-to-core-1.35

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Dec 20, 2025

Backport of #7652 to core/1.35

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

Prevent sidebar tool buttons from flashing during collapse.

## What changed
- Clip the sidebar tool-buttons container during hover collapse so tab
labels don't render outside the header.
- Keep the existing width/opacity transition so the title still reclaims
space.

## Why
- Motivation: the hover-out transition shrinks the tool-buttons wrapper
to `w-0` while the tabs keep their intrinsic width, causing a brief
clipped flash on the right edge of the sidebar.
- Why this approach: clipping during the transition is the smallest
change that fixes the visual artifact without altering layout timing or
hover behavior.
- Tradeoffs / limitations: no functional change; the buttons are only
clipped while collapsing.

## Evidence
- Issues: n/a
- Tests: Not run (lint/typecheck only; not evidence)
- Screenshots/video:


https://github.com/user-attachments/assets/3af4d735-6330-4521-b4cf-45eb4b09f9ba

## References
- Related PRs: n/a
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Dec 20, 2025
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner December 20, 2025 01:37
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 20, 2025
@github-actions
Copy link

github-actions bot commented Dec 20, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 12/20/2025, 01:39:16 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Dec 20, 2025

🎭 Playwright Test Results

🕵🏻 No test results found

⏰ Completed at: 12/20/2025, 07:43:13 AM UTC

📊 Test Reports by Browser

  • chromium: Deployment failed
  • chromium-2x: Deployment failed
  • chromium-0.5x: Deployment failed
  • mobile-chrome: Deployment failed

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne merged commit 574e5bd into core/1.35 Dec 20, 2025
20 of 31 checks passed
@christian-byrne christian-byrne deleted the backport-7652-to-core-1.35 branch December 20, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants