feat: position properties panel opposite to sidebar

[csongorczezar]

Problem

When sidebar is positioned on the right, the properties panel also appears on the right, causing both panels to compete for space and creating a poor layout.

Solution

Properties panel now dynamically positions itself opposite to the sidebar:

• Sidebar left → Properties panel right (default)
• Sidebar right → Properties panel left

Changes

• Modified LiteGraphCanvasSplitterOverlay.vue to conditionally render properties panel based on sidebar location
• Updated splitter refresh key to recalculate layout when sidebar position changes
• Added dynamic close button icon in RightSidePanel.vue that points in the correct direction

Testing

• Created E2E tests to verify positioning behavior
• Manually verified visual behavior in browser

┆Issue is synchronized with this Notion page by Unito

[coderabbitai]

📝 Walkthrough

Walkthrough

Adjusts splitter and side-panel rendering so side panels render/size based on stored Comfy.Sidebar.Location and rightSidePanelVisible; makes the panel toggle/close icon dynamic by sidebar location; adds an i18n label and a Playwright test verifying panel positioning and toggle icon for left/right placements.

Changes

Cohort / File(s)	Summary
Test: Properties panel positioning browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts	Adds a Playwright spec that sets Comfy.Sidebar.Location to left and right, advances a frame, locates sidebar and properties panel, asserts their relative bounding boxes (panel to right/left of sidebar), and verifies the toggle button's icon class for each placement.
UI: Splitter & panel ordering src/components/LiteGraphCanvasSplitterOverlay.vue	Changes rendering/ordering so first/last panels render based on sidebarLocation and rightSidePanelVisible; consolidates right-side content into existing panels, adjusts per-panel min-size and classes, adds ARIA labels and i18n usage, updates splitterRefreshKey, and replaces hard display toggles with computed styles.
UI: Properties toggle/close icon logic src/components/rightSidePanel/RightSidePanel.vue	Adds useSettingStore, computes sidebarLocation and panelIcon (icon class chosen by location), and binds the dynamic icon class on the toggle/close button.
Locales src/locales/en/main.json	Adds sideToolbar.sidebar translation entry with value Sidebar.

Possibly related PRs

• Cleanup: Properties Panel #7137 — Overlaps edits to LiteGraphCanvasSplitterOverlay.vue, RightSidePanel.vue, and related tests verifying sidebar-location-driven behavior.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat-properties-panel-sidebar-placement

---

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2aa12c4 and 43d8619.

📒 Files selected for processing (1)

• src/components/LiteGraphCanvasSplitterOverlay.vue (5 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

src/**/*.vue: Vue 3 SFCs must use Composition API only - no Options API
Use <script setup lang="ts"> for component logic
Use Tailwind 4 utility classes for styling - avoid <style> blocks
Use cn() utility from @/utils/tailwindUtil to merge Tailwind class names - never use :class="[]" syntax
Never use the dark: Tailwind variant - use semantic values from style.css theme instead (e.g., bg-node-component-surface)
Use Vue 3.5+ TypeScript style default prop declaration with reactive destructuring - prefer useModel to prop/emit pairs, do not use withDefaults
Do not import Vue macros unnecessarily
Use vue-i18n in composition API for string literals - place translation entries in src/locales/en/main.json
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Avoid new usage of PrimeVue components

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

src/**/*.{vue,ts}: Avoid using ref and watch together - use computed instead if possible
Do not add ref if a prop would suffice; do not add computed if the ref/prop directly would work; use watch only when computed won't accomplish the goal
Leverage VueUse functions for performance-enhancing styles

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates
Use es-toolkit for utility functions
Avoid mutable state - prefer immutability and assignment at point of declaration
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Vue components must be named in PascalCase (e.g., MenuHamburger.vue)

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{js,ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript exclusively - no new JavaScript files

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{ts,tsx,vue,js}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx,vue,js}: Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see .prettierrc
Sort and group imports by plugin, run pnpm format before committing

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

🧠 Learnings (35)

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Extract complex conditionals to computed properties

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-09T21:40:12.361Z

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-04T21:47:07.812Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/LiteGraphCanvasSplitterOverlay.vue:43-43
Timestamp: 2025-12-04T21:47:07.812Z
Learning: In Vue SFCs with a build step (pre-compilation), kebab-case attribute names in templates are automatically converted to camelCase, so `:sidebar-panel-visible` as a shorthand binding correctly resolves to a variable named `sidebarPanelVisible`. The `.camel` modifier is only needed when using in-DOM templates without a build step.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Do not add `ref` if a prop would suffice; do not add `computed` if the ref/prop directly would work; use `watch` only when `computed` won't accomplish the goal

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T21:15:46.862Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Prefer single line `if` syntax over adding curly braces, when the statement has a very concise expression and concise, single line statement

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-05T06:11:09.383Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7177
File: src/platform/assets/components/UploadModelFooter.vue:72-78
Timestamp: 2025-12-05T06:11:09.383Z
Learning: For the ComfyUI_frontend repository, avoid suggesting comments that would be redundant when the code is already self-explanatory through descriptive naming (e.g., filenames, prop names, aria-labels). The project prefers clean code without unnecessary documentation comments.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement computed properties with computed()

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Implement computed() for derived state in Vue 3 Composition API

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Avoid using `ref` and `watch` together - use `computed` instead if possible

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-10T03:09:19.636Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7303
File: src/components/topbar/CurrentUserPopover.test.ts:199-205
Timestamp: 2025-12-10T03:09:19.636Z
Learning: For test files in the Comfy-Org/ComfyUI_frontend repository: When writing tests, prefer selecting elements by accessible properties (text content, aria-label, role, accessible name) over data-testid attributes. This ensures tests verify actual user-facing behavior and accessibility compliance.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.vue : Use Tailwind 4 utility classes for styling - avoid `<style>` blocks

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use Tailwind CSS for styling

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.vue : Use vue-i18n in composition API for string literals - place translation entries in `src/locales/en/main.json`

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI strings

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-05T20:35:28.330Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/locales/en/main.json:2257-2272
Timestamp: 2025-12-05T20:35:28.330Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, vue-i18n pluralization uses a two-parameter pattern: `t('key', { count: value })` where the `count` property in the interpolation object automatically triggers plural selection from pipe-separated locale strings (e.g., "no items | 1 item | {count} items"). This is the correct pattern used throughout the codebase, as validated by Playwright tests.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T20:39:30.137Z

Learnt from: jtydhr88
Repo: Comfy-Org/ComfyUI_frontend PR: 7621
File: src/components/load3d/Load3DScene.vue:4-4
Timestamp: 2025-12-18T20:39:30.137Z
Learning: In src/components/load3d/Load3DScene.vue, the scoped `<style>` block with `!important` declarations for the canvas element is necessary because Three.js dynamically creates the canvas with inline styles, preventing direct application of Tailwind classes. This is a valid exception to the Tailwind-only styling guideline.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T02:07:38.870Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-16T17:30:29.719Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7559
File: .storybook/preview.ts:61-61
Timestamp: 2025-12-16T17:30:29.719Z
Learning: In .storybook/preview.ts for the Comfy-Org/ComfyUI_frontend repository, using `document.body.classList.add('[&_*]:!font-inter')` is the correct approach for applying the Inter font to all Storybook story elements. The simpler `font-inter` class alone does not work in this context. This runtime arbitrary variant pattern is valid and should not be flagged as an issue.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.vue : Use `cn()` utility from `@/utils/tailwindUtil` to merge Tailwind class names - never use `:class="[]"` syntax

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-01T23:42:30.894Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7084
File: src/renderer/extensions/vueNodes/components/SlotConnectionDot.vue:23-26
Timestamp: 2025-12-01T23:42:30.894Z
Learning: In the ComfyUI frontend codebase, Tailwind CSS is configured with Preflight enabled (default), which automatically provides `content: ''` for pseudo-elements when using `after:` or `before:` variants - no need to explicitly add `after:content-['']`.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.vue : Avoid new usage of PrimeVue components

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Calendar component with DatePicker

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-09T03:49:52.828Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-16T22:26:49.463Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-21T01:06:02.786Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T16:03:02.066Z

Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: lint-and-format
• GitHub Check: setup
• GitHub Check: test
• GitHub Check: collect

🔇 Additional comments (4)

src/components/LiteGraphCanvasSplitterOverlay.vue (4)

124-124: Good adoption of the composition API for i18n.

Correctly using useI18n instead of the deprecated global t function.

---

136-136: LGTM!

Proper use of the useI18n composable per coding guidelines.

---

168-173: Correct refresh key computation.

Including both rightSidePanelVisible and sidebarLocation in the key ensures the splitter recalculates layout when either value changes. This is essential for the dynamic panel positioning feature.

---

175-187: Clean implementation of panel visibility control.

The computed properties correctly toggle sidebar visibility based on location. Using inline styles here is acceptable for PrimeVue Splitter integration, as discussed in previous reviews, ensuring proper layout calculations.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 12/21/2025, 01:23:15 AM UTC

📈 Summary

• Total Tests: 511
• Passed: 500 ✅
• Failed: 0
• Flaky: 3 ⚠️
• Skipped: 8 ⏭️

📊 Test Reports by Browser

• ✅ chromium: View Report • ✅ 488 / ❌ 0 / ⚠️ 3 / ⏭️ 8
• ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
• ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
• ✅ mobile-chrome: View Report • ✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0

---

🎉 Click on the links above to view detailed test results for each browser configuration.

[github-actions]

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/21/2025, 01:14:47 AM UTC

🔗 Links

• 📊 View Workflow Run
• 🎨 View Storybook

---

🎉 Your Storybook is ready for review!

[github-actions]

Bundle Size Report

Summary

• Raw size: 17.3 MB baseline 17.3 MB — 🔴 +1.08 kB
• Gzip: 3.53 MB baseline 3.53 MB — 🔴 +181 B
• Brotli: 2.69 MB baseline 2.69 MB — 🔴 +69 B
• Bundles: 98 current • 98 baseline • 42 added / 42 removed

Category Glance
Graph Workspace 🔴 +1.06 kB (994 kB) · App Entry Points 🔴 +22 B (3.22 MB) · Vendor & Third-Party ⚪ 0 B (9.1 MB) · Other ⚪ 0 B (3.44 MB) · Panels & Settings ⚪ 0 B (297 kB) · UI Components ⚪ 0 B (186 kB) · + 3 more

Per-category breakdown

App Entry Points — 3.22 MB (baseline 3.22 MB) • 🔴 +22 B

Main entry bundles and manifests

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/index-B29BszBs.js (new)	—	2.99 MB	🔴 +2.99 MB	🔴 +631 kB	🔴 +480 kB
assets/index-CRPAyso3.js (removed)	2.99 MB	—	🟢 -2.99 MB	🟢 -631 kB	🟢 -480 kB
assets/index-pGB-RwNM.js (new)	—	228 kB	🔴 +228 kB	🔴 +48.7 kB	🔴 +40 kB
assets/index-x8X2_Kgo.js (removed)	228 kB	—	🟢 -228 kB	🟢 -48.7 kB	🟢 -40.1 kB
assets/index-DsPJ9rHe.js (removed)	345 B	—	🟢 -345 B	🟢 -246 B	🟢 -210 B
assets/index-zU-nnqa9.js (new)	—	345 B	🔴 +345 B	🔴 +243 B	🔴 +209 B

Status: 3 added / 3 removed

Graph Workspace — 994 kB (baseline 993 kB) • 🔴 +1.06 kB

Graph editor runtime, canvas, workflow orchestration

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/GraphView-BUaf72Hu.js (new)	—	994 kB	🔴 +994 kB	🔴 +194 kB	🔴 +148 kB
assets/GraphView-1LVXRMF4.js (removed)	993 kB	—	🟢 -993 kB	🟢 -194 kB	🟢 -148 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/UserSelectView-BwIWQRKS.js (removed)	6.54 kB	—	🟢 -6.54 kB	🟢 -2.14 kB	🟢 -1.9 kB
assets/UserSelectView-r7vImC6i.js (new)	—	6.54 kB	🔴 +6.54 kB	🔴 +2.14 kB	🔴 +1.89 kB

Status: 1 added / 1 removed

Panels & Settings — 297 kB (baseline 297 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/LegacyCreditsPanel-D78YhPVE.js (removed)	21.4 kB	—	🟢 -21.4 kB	🟢 -5.16 kB	🟢 -4.51 kB
assets/LegacyCreditsPanel-inviHzld.js (new)	—	21.4 kB	🔴 +21.4 kB	🔴 +5.16 kB	🔴 +4.51 kB
assets/KeybindingPanel-C376suAk.js (removed)	13.6 kB	—	🟢 -13.6 kB	🟢 -3.42 kB	🟢 -3.02 kB
assets/KeybindingPanel-Da6vDofQ.js (new)	—	13.6 kB	🔴 +13.6 kB	🔴 +3.42 kB	🔴 +3.01 kB
assets/ExtensionPanel-CeQyzDo7.js (new)	—	10.8 kB	🔴 +10.8 kB	🔴 +2.57 kB	🔴 +2.24 kB
assets/ExtensionPanel-OBmMurXD.js (removed)	10.8 kB	—	🟢 -10.8 kB	🟢 -2.57 kB	🟢 -2.24 kB
assets/AboutPanel-BEzVqUA0.js (new)	—	9.16 kB	🔴 +9.16 kB	🔴 +2.46 kB	🔴 +2.21 kB
assets/AboutPanel-D5hwPoiM.js (removed)	9.16 kB	—	🟢 -9.16 kB	🟢 -2.46 kB	🟢 -2.21 kB
assets/ServerConfigPanel-D7-U40Uz.js (new)	—	7.07 kB	🔴 +7.07 kB	🔴 +1.98 kB	🔴 +1.76 kB
assets/ServerConfigPanel-Dte0_tFn.js (removed)	7.07 kB	—	🟢 -7.07 kB	🟢 -1.98 kB	🟢 -1.76 kB
assets/UserPanel-D9KS9Ibd.js (removed)	6.23 kB	—	🟢 -6.23 kB	🟢 -1.72 kB	🟢 -1.5 kB
assets/UserPanel-DjSj5mDK.js (new)	—	6.23 kB	🔴 +6.23 kB	🔴 +1.72 kB	🔴 +1.5 kB
assets/settings-BhbWhsRg.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BvFz-TmQ.js	33.1 kB	33.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BxYnTA2y.js	21.5 kB	21.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C6bMjAne.js	27.1 kB	27.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C7Yhp7H7.js	24 kB	24 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CsnOn8G0.js	25.7 kB	25.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-D5BGNZ7M.js	24.8 kB	24.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-D7k3huHm.js	25 kB	25 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DamkILzl.js	26.4 kB	26.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-s1k0gw1Y.js	20.9 kB	20.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

UI Components — 186 kB (baseline 186 kB) • ⚪ 0 B

Reusable component library chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-C_JoGEvJ.js (new)	—	54.3 kB	🔴 +54.3 kB	🔴 +8.62 kB	🔴 +7.42 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-lu_XnsUS.js (removed)	54.3 kB	—	🟢 -54.3 kB	🟢 -8.62 kB	🟢 -7.42 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-CftIieqx.js (removed)	50 kB	—	🟢 -50 kB	🟢 -11 kB	🟢 -9.63 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-V-_vCzsU.js (new)	—	50 kB	🔴 +50 kB	🔴 +11 kB	🔴 +9.63 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-CB5XTs6R.js (removed)	48.8 kB	—	🟢 -48.8 kB	🟢 -10.5 kB	🟢 -9.13 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-DHiOH6Ek.js (new)	—	48.8 kB	🔴 +48.8 kB	🔴 +10.5 kB	🔴 +9.13 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-DV4FbEfg.js (removed)	14.3 kB	—	🟢 -14.3 kB	🟢 -3.73 kB	🟢 -3.29 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-QeRrpt33.js (new)	—	14.3 kB	🔴 +14.3 kB	🔴 +3.73 kB	🔴 +3.29 kB
assets/ComfyQueueButton-D3GOv-gl.js (new)	—	8.45 kB	🔴 +8.45 kB	🔴 +2.47 kB	🔴 +2.2 kB
assets/ComfyQueueButton-DhXmqiP5.js (removed)	8.45 kB	—	🟢 -8.45 kB	🟢 -2.47 kB	🟢 -2.2 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-CAaj-Kbx.js (new)	—	3.68 kB	🔴 +3.68 kB	🔴 +1.45 kB	🔴 +1.31 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-HkBDysp3.js (removed)	3.68 kB	—	🟢 -3.68 kB	🟢 -1.45 kB	🟢 -1.31 kB
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-4_up1okB.js (removed)	2.14 kB	—	🟢 -2.14 kB	🟢 -888 B	🟢 -767 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-C-1qnde-.js (new)	—	2.14 kB	🔴 +2.14 kB	🔴 +887 B	🔴 +769 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-CnHL_M9Q.js (removed)	897 B	—	🟢 -897 B	🟢 -503 B	🟢 -470 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-Cu5MAiHH.js (new)	—	897 B	🔴 +897 B	🔴 +503 B	🔴 +456 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-DymEwRe0.js	1.34 kB	1.34 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetButton-U5ly29Pt.js	2.04 kB	2.04 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 8 added / 8 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/keybindingService-Dm5Fa_3p.js (new)	—	7.51 kB	🔴 +7.51 kB	🔴 +1.83 kB	🔴 +1.59 kB
assets/keybindingService-DtKElWf1.js (removed)	7.51 kB	—	🟢 -7.51 kB	🟢 -1.83 kB	🟢 -1.58 kB
assets/audioService-BEkOML7l.js (removed)	2.2 kB	—	🟢 -2.2 kB	🟢 -960 B	🟢 -822 B
assets/audioService-DcsLbHyp.js (new)	—	2.2 kB	🔴 +2.2 kB	🔴 +960 B	🔴 +822 B
assets/serverConfigStore-7JI8VFS2.js	2.83 kB	2.83 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/audioUtils-BjdoEgMY.js (removed)	1.41 kB	—	🟢 -1.41 kB	🟢 -651 B	🟢 -551 B
assets/audioUtils-BwdL-M6E.js (new)	—	1.41 kB	🔴 +1.41 kB	🔴 +651 B	🔴 +545 B

Status: 1 added / 1 removed

Vendor & Third-Party — 9.1 MB (baseline 9.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/vendor-chart-DaR9dw3X.js	452 kB	452 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-other-Cf7iqkoX.js	3.86 MB	3.86 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-primevue-BIgr9yoj.js	1.96 MB	1.96 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-three-DYL0ZbEr.js	2.02 MB	2.02 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-tiptap-C1NB2Q_L.js	232 kB	232 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-vue-DSfeuQOV.js	160 kB	160 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-xterm-BF8peZ5_.js	420 kB	420 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Other — 3.44 MB (baseline 3.44 MB) • ⚪ 0 B

Bundles that do not match a named category

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/SubscriptionRequiredDialogContent-B37n4waH.js (removed)	28 kB	—	🟢 -28 kB	🟢 -6.34 kB	🟢 -5.5 kB
assets/SubscriptionRequiredDialogContent-D1H8PD99.js (new)	—	28 kB	🔴 +28 kB	🔴 +6.33 kB	🔴 +5.48 kB
assets/WidgetRecordAudio-C5Qph1e-.js (new)	—	20.4 kB	🔴 +20.4 kB	🔴 +5.23 kB	🔴 +4.64 kB
assets/WidgetRecordAudio-DdDPDNUV.js (removed)	20.4 kB	—	🟢 -20.4 kB	🟢 -5.24 kB	🟢 -4.63 kB
assets/AudioPreviewPlayer-BxGRKvc3.js (removed)	13.3 kB	—	🟢 -13.3 kB	🟢 -3.35 kB	🟢 -2.99 kB
assets/AudioPreviewPlayer-DQvNfCxu.js (new)	—	13.3 kB	🔴 +13.3 kB	🔴 +3.35 kB	🔴 +3.01 kB
assets/ValueControlPopover-Blnpr2AZ.js (new)	—	5.49 kB	🔴 +5.49 kB	🔴 +1.7 kB	🔴 +1.52 kB
assets/ValueControlPopover-BSqxTWS3.js (removed)	5.49 kB	—	🟢 -5.49 kB	🟢 -1.7 kB	🟢 -1.52 kB
assets/WidgetGalleria-DgJmQ4zl.js (removed)	4.1 kB	—	🟢 -4.1 kB	🟢 -1.45 kB	🟢 -1.3 kB
assets/WidgetGalleria-mTbVbgI9.js (new)	—	4.1 kB	🔴 +4.1 kB	🔴 +1.45 kB	🔴 +1.31 kB
assets/WidgetColorPicker-CMU__Oov.js (removed)	3.41 kB	—	🟢 -3.41 kB	🟢 -1.38 kB	🟢 -1.23 kB
assets/WidgetColorPicker-W_KV1d3G.js (new)	—	3.41 kB	🔴 +3.41 kB	🔴 +1.38 kB	🔴 +1.23 kB
assets/WidgetTextarea-CReylfwu.js (new)	—	3.08 kB	🔴 +3.08 kB	🔴 +1.21 kB	🔴 +1.08 kB
assets/WidgetTextarea-Cy6Kmpz8.js (removed)	3.08 kB	—	🟢 -3.08 kB	🟢 -1.21 kB	🟢 -1.08 kB
assets/WidgetMarkdown-CCrBQFiJ.js (removed)	3.08 kB	—	🟢 -3.08 kB	🟢 -1.28 kB	🟢 -1.13 kB
assets/WidgetMarkdown-CYEoI2oY.js (new)	—	3.08 kB	🔴 +3.08 kB	🔴 +1.28 kB	🔴 +1.13 kB
assets/WidgetAudioUI-CCnRhGBe.js (new)	—	2.89 kB	🔴 +2.89 kB	🔴 +1.17 kB	🔴 +1.05 kB
assets/WidgetAudioUI-CPsxgaw7.js (removed)	2.89 kB	—	🟢 -2.89 kB	🟢 -1.17 kB	🟢 -1.06 kB
assets/WidgetInputText-Bu_New3n.js (new)	—	1.99 kB	🔴 +1.99 kB	🔴 +918 B	🔴 +829 B
assets/WidgetInputText-Cj0y_z_O.js (removed)	1.99 kB	—	🟢 -1.99 kB	🟢 -920 B	🟢 -853 B
assets/WidgetToggleSwitch-DyxJLzOm.js (removed)	1.76 kB	—	🟢 -1.76 kB	🟢 -834 B	🟢 -728 B
assets/WidgetToggleSwitch-qhFVmjy1.js (new)	—	1.76 kB	🔴 +1.76 kB	🔴 +833 B	🔴 +726 B
assets/MediaImageBottom-BY84lmau.js (removed)	1.55 kB	—	🟢 -1.55 kB	🟢 -735 B	🟢 -637 B
assets/MediaImageBottom-CR2BoTDo.js (new)	—	1.55 kB	🔴 +1.55 kB	🔴 +731 B	🔴 +638 B
assets/MediaAudioBottom-DbSUrjhv.js (new)	—	1.51 kB	🔴 +1.51 kB	🔴 +731 B	🔴 +645 B
assets/MediaAudioBottom-DQum3qn8.js (removed)	1.51 kB	—	🟢 -1.51 kB	🟢 -732 B	🟢 -644 B
assets/Media3DBottom-D00LRIC4.js (removed)	1.5 kB	—	🟢 -1.5 kB	🟢 -730 B	🟢 -644 B
assets/Media3DBottom-PCXIDSyI.js (new)	—	1.5 kB	🔴 +1.5 kB	🔴 +730 B	🔴 +644 B
assets/MediaVideoBottom-CZh6TkyB.js (new)	—	1.5 kB	🔴 +1.5 kB	🔴 +730 B	🔴 +644 B
assets/MediaVideoBottom-DNaFw2Zs.js (removed)	1.5 kB	—	🟢 -1.5 kB	🟢 -731 B	🟢 -647 B
assets/Media3DTop-arVxGPjA.js (new)	—	1.49 kB	🔴 +1.49 kB	🔴 +766 B	🔴 +652 B
assets/Media3DTop-C7hgO2NB.js (removed)	1.49 kB	—	🟢 -1.49 kB	🟢 -767 B	🟢 -653 B
assets/WidgetSelect-CPk6b5RI.js (new)	—	733 B	🔴 +733 B	🔴 +362 B	🔴 +321 B
assets/WidgetSelect-Ctp6tGrk.js (removed)	733 B	—	🟢 -733 B	🟢 -361 B	🟢 -325 B
assets/WidgetInputNumber-CubPmmR4.js (removed)	673 B	—	🟢 -673 B	🟢 -348 B	🟢 -290 B
assets/WidgetInputNumber-D05oD3A-.js (new)	—	673 B	🔴 +673 B	🔴 +344 B	🔴 +289 B
assets/Load3D-C58NiTr9.js (new)	—	424 B	🔴 +424 B	🔴 +268 B	🔴 +223 B
assets/Load3D-CZJ2PB2G.js (removed)	424 B	—	🟢 -424 B	🟢 -268 B	🟢 -222 B
assets/WidgetLegacy-BGaPO9AV.js (new)	—	364 B	🔴 +364 B	🔴 +238 B	🔴 +194 B
assets/WidgetLegacy-DpWmwQ7f.js (removed)	364 B	—	🟢 -364 B	🟢 -238 B	🟢 -197 B
assets/commands-BWp4HdfU.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CcfGaui5.js	14.4 kB	14.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CisfgZf5.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CkU12Foh.js	13 kB	13 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CoH2DJa6.js	14.2 kB	14.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-COSt-Bjx.js	14.9 kB	14.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DalfIW5f.js	15.9 kB	15.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DfTl0eCm.js	13.5 kB	13.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DwSJL865.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-Zxyx15Vd.js	12.8 kB	12.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BDhxs-bB.js	79.9 kB	79.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BtXVDFw6.js	84.7 kB	84.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Buv6RhU4.js	82.4 kB	82.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CgJ6zvJL.js	97.2 kB	97.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CI9qb0E5.js	112 kB	112 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cu4LqtW0.js	81.6 kB	81.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cw9RZWRY.js	89 B	89 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Dm19QY4N.js	92.2 kB	92.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Tihe0h_r.js	71.3 kB	71.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-wPWMutMw.js	70.4 kB	70.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaAudioTop-Dr0afgCA.js	1.46 kB	1.46 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaImageTop-BXa-oKEc.js	1.75 kB	1.75 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaVideoTop-BVdg2b8C.js	2.65 kB	2.65 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-1Vh3MCrN.js	240 kB	240 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-aW9En70v.js	260 kB	260 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BIckSVgU.js	273 kB	273 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BiYpVi7D.js	263 kB	263 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CCEXtYfM.js	243 kB	243 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CvmVDWYd.js	323 kB	323 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-D_wreoPJ.js	267 kB	267 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Dz-0ZIBN.js	297 kB	297 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-VZsNmhG7.js	264 kB	264 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetChart-BU__hen8.js	2.48 kB	2.48 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetImageCompare-0zJeINY-.js	2.21 kB	2.21 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js	1.28 kB	1.28 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 20 added / 20 removed

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5524526 and 683098e.

📒 Files selected for processing (3)

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts (1 hunks)
• src/components/LiteGraphCanvasSplitterOverlay.vue (3 hunks)
• src/components/rightSidePanel/RightSidePanel.vue (3 hunks)

🧰 Additional context used

📓 Path-based instructions (13)

src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

src/**/*.vue: Vue 3 SFCs must use Composition API only - no Options API
Use <script setup lang="ts"> for component logic
Use Tailwind 4 utility classes for styling - avoid <style> blocks
Use cn() utility from @/utils/tailwindUtil to merge Tailwind class names - never use :class="[]" syntax
Never use the dark: Tailwind variant - use semantic values from style.css theme instead (e.g., bg-node-component-surface)
Use Vue 3.5+ TypeScript style default prop declaration with reactive destructuring - prefer useModel to prop/emit pairs, do not use withDefaults
Do not import Vue macros unnecessarily
Use vue-i18n in composition API for string literals - place translation entries in src/locales/en/main.json
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Avoid new usage of PrimeVue components

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

src/**/*.{vue,ts}: Avoid using ref and watch together - use computed instead if possible
Do not add ref if a prop would suffice; do not add computed if the ref/prop directly would work; use watch only when computed won't accomplish the goal
Leverage VueUse functions for performance-enhancing styles

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates
Use es-toolkit for utility functions
Avoid mutable state - prefer immutability and assignment at point of declaration
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Vue components must be named in PascalCase (e.g., MenuHamburger.vue)

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{js,ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript exclusively - no new JavaScript files

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{ts,tsx,vue,js}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx,vue,js}: Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see .prettierrc
Sort and group imports by plugin, run pnpm format before committing

Files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (browser_tests/CLAUDE.md)

browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx}: Test user workflows in browser tests
Use Playwright fixtures for browser tests
Follow naming conventions for browser tests
Check assets/ directory for test data when writing tests
Prefer specific selectors in browser tests
Test across multiple viewports

Files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

browser_tests/**/*.spec.ts

📄 CodeRabbit inference engine (AGENTS.md)

browser_tests/**/*.spec.ts: E2E test files must use pattern browser_tests/**/*.spec.ts with Playwright
Do not use waitForTimeout in Playwright - use Locator actions and retrying assertions
Use Playwright tags like @mobile, @2x for relevant E2E tests - they are respected by config

Files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

🧠 Learnings (29)

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer

Applied to files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-04T21:47:07.812Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/LiteGraphCanvasSplitterOverlay.vue:43-43
Timestamp: 2025-12-04T21:47:07.812Z
Learning: In Vue SFCs with a build step (pre-compilation), kebab-case attribute names in templates are automatically converted to camelCase, so `:sidebar-panel-visible` as a shorthand binding correctly resolves to a variable named `sidebarPanelVisible`. The `.camel` modifier is only needed when using in-DOM templates without a build step.

Applied to files:

• src/components/rightSidePanel/RightSidePanel.vue

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : Use provided test helpers `createTestSubgraph` and `createTestSubgraphNode` from `./fixtures/subgraphHelpers` for consistent subgraph test setup

Applied to files:

• src/components/rightSidePanel/RightSidePanel.vue

📚 Learning: 2025-12-09T03:49:52.828Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-09T21:40:12.361Z

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-16T22:26:49.463Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

• src/components/rightSidePanel/RightSidePanel.vue
• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts
• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T02:07:38.870Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T21:15:46.862Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Applied to files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T16:03:02.066Z

Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.

Applied to files:

• src/components/rightSidePanel/RightSidePanel.vue
• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to browser_tests/**/*.spec.ts : E2E test files must use pattern `browser_tests/**/*.spec.ts` with Playwright

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Write tests for new features

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to tests-ui/**/*.test.ts : Write tests for all changes, especially bug fixes to catch future regressions

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to browser_tests/**/*.spec.ts : Use Playwright tags like `mobile`, `2x` for relevant E2E tests - they are respected by config

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-11-24T19:47:22.909Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Use Playwright fixtures for browser tests

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-11-24T19:47:22.909Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Follow naming conventions for browser tests

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to tests-ui/**/*.test.ts : Aim for behavioral coverage of critical and new features

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-11-24T19:47:22.909Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Prefer specific selectors in browser tests

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to browser_tests/**/*.spec.ts : Do not use waitForTimeout in Playwright - use Locator actions and retrying assertions

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-11-24T19:47:22.909Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: browser_tests/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:22.909Z
Learning: Applies to browser_tests/**/*.{e2e,spec}.{ts,tsx,js,jsx} : Test across multiple viewports

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-12-10T03:09:19.636Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7303
File: src/components/topbar/CurrentUserPopover.test.ts:199-205
Timestamp: 2025-12-10T03:09:19.636Z
Learning: For test files in the Comfy-Org/ComfyUI_frontend repository: When writing tests, prefer selecting elements by accessible properties (text content, aria-label, role, accessible name) over data-testid attributes. This ensures tests verify actual user-facing behavior and accessibility compliance.

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Check tests-ui/README.md for test guidelines

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-12-13T05:54:35.779Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7415
File: browser_tests/tests/mobileBaseline.spec.ts:17-22
Timestamp: 2025-12-13T05:54:35.779Z
Learning: In browser_tests tests for the Comfy-Org/ComfyUI_frontend repository, the `comfyPage.loadWorkflow()` method already handles all necessary synchronization and waiting. No additional `await comfyPage.nextFrame()` call is needed before taking screenshots after loading a workflow.

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-11-24T19:48:03.270Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: tests-ui/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:48:03.270Z
Learning: Applies to tests-ui/**/*.test.{js,ts,jsx,tsx} : Follow existing test patterns in the codebase

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-12-13T05:34:15.488Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7415
File: browser_tests/tests/mobileBaseline.spec.ts:7-15
Timestamp: 2025-12-13T05:34:15.488Z
Learning: In Playwright tests for the ComfyUI frontend, the toPass() assertion uses incremental backoff during retries. When a test may involve async operations, increasing the timeout (e.g., to 5000 ms) can be sufficient instead of aggressively extending timeouts. Apply this understanding to tests under browser_tests/tests/; if not resolved, review the toPass() backoff behavior and ensure timeouts align with expected async completion without masking issues.

Applied to files:

• browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: test
• GitHub Check: setup
• GitHub Check: lint-and-format
• GitHub Check: collect

🔇 Additional comments (6)

src/components/rightSidePanel/RightSidePanel.vue (2)

32-41: LGTM! Clean implementation of dynamic icon selection.

The computed properties correctly implement the inverse relationship between sidebar location and panel icon direction. When the sidebar is on the right, the panel appears on the left and shows a left-pointing icon.

---

176-176: LGTM! Proper use of dynamic class binding.

The dynamic icon class binding correctly uses the cn() utility to merge the computed panelIcon class with the size class.

browser_tests/tests/propertiesPanel/propertiesPanelPosition.spec.ts (1)

31-50: LGTM! Correct positioning validation for inverted layout.

The test properly validates that the properties panel appears on the left when the sidebar is on the right. The positioning assertion logic is sound.

src/components/LiteGraphCanvasSplitterOverlay.vue (3)

25-35: Note: Slot name semantics vs. positioning.

The slot name right-side-panel is used for a panel that appears on the left when sidebarLocation === 'right'. While this might seem semantically confusing, it's understandable given that the slot name describes the panel's identity (properties/right-side panel) rather than its current position. The positioning is correctly handled by the conditional rendering.

Consider documenting this naming convention if it causes confusion for future maintainers.

---

111-121: LGTM! Correct conditional rendering for default layout.

The updated condition properly restricts this panel to only render when the sidebar is on the left (default behavior), making it mutually exclusive with the new left-positioned panel. The comment clarifies the intent well.

---

175-186: LGTM! Proper key composition for forced re-rendering.

The updated splitterRefreshKey correctly includes sidebarLocation in the key composition, which forces the Splitter component to recalculate panel widths and ordering when the sidebar location changes. The implementation using array parts and join is clean and maintainable.

[DrJKL]

Would it be possible to just swap the slots between the two panels instead?

[csongorczezar]

Hmmm. I thought about that too, but the issue is that the Splitter component renders its children in the order they appear in the template. So to get the properties panel on the left vs right, it needs to be the first child vs the last child in the DOM.

We could technically do a computed array of components and dynamically reorder them, but that felt more convoluted than just having two conditional renders.
The actual duplication is minimal: it's just the SplitterPanel wrapper, the content itself ([]) is shared.
If you have a cleaner pattern in mind though, I'm all ears :)

[csongorczezar]

Done

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8721935 and 22793fd.

📒 Files selected for processing (1)

• src/components/LiteGraphCanvasSplitterOverlay.vue (4 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

src/**/*.vue: Vue 3 SFCs must use Composition API only - no Options API
Use <script setup lang="ts"> for component logic
Use Tailwind 4 utility classes for styling - avoid <style> blocks
Use cn() utility from @/utils/tailwindUtil to merge Tailwind class names - never use :class="[]" syntax
Never use the dark: Tailwind variant - use semantic values from style.css theme instead (e.g., bg-node-component-surface)
Use Vue 3.5+ TypeScript style default prop declaration with reactive destructuring - prefer useModel to prop/emit pairs, do not use withDefaults
Do not import Vue macros unnecessarily
Use vue-i18n in composition API for string literals - place translation entries in src/locales/en/main.json
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Avoid new usage of PrimeVue components

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

src/**/*.{vue,ts}: Avoid using ref and watch together - use computed instead if possible
Do not add ref if a prop would suffice; do not add computed if the ref/prop directly would work; use watch only when computed won't accomplish the goal
Leverage VueUse functions for performance-enhancing styles

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates
Use es-toolkit for utility functions
Avoid mutable state - prefer immutability and assignment at point of declaration
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Vue components must be named in PascalCase (e.g., MenuHamburger.vue)

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{js,ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript exclusively - no new JavaScript files

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{ts,tsx,vue,js}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx,vue,js}: Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see .prettierrc
Sort and group imports by plugin, run pnpm format before committing

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

🧠 Learnings (12)

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Extract complex conditionals to computed properties

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-09T03:49:52.828Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-09T21:40:12.361Z

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-16T22:26:49.463Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T02:07:38.870Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T21:15:46.862Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T16:03:02.066Z

Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: lint-and-format
• GitHub Check: collect
• GitHub Check: test
• GitHub Check: setup

🔇 Additional comments (2)

src/components/LiteGraphCanvasSplitterOverlay.vue (2)

89-119: Implementation aligns with Splitter ordering constraints.

The mirrored conditional logic for the last panel correctly implements the opposite behavior. Per the past discussion, this approach is justified given PrimeVue's Splitter renders children in DOM order, making dynamic reordering more complex than the current conditional render approach.

---

174-185: Refresh key logic correctly triggers layout recalculation.

The updated splitterRefreshKey properly includes sidebarLocation.value to force the Splitter to re-render when the sidebar position changes. This ensures the panel order updates correctly without stale layout state.

[Myestery]

LGTM

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22793fd and 5a87e31.

📒 Files selected for processing (1)

• src/components/LiteGraphCanvasSplitterOverlay.vue (4 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

src/**/*.vue: Vue 3 SFCs must use Composition API only - no Options API
Use <script setup lang="ts"> for component logic
Use Tailwind 4 utility classes for styling - avoid <style> blocks
Use cn() utility from @/utils/tailwindUtil to merge Tailwind class names - never use :class="[]" syntax
Never use the dark: Tailwind variant - use semantic values from style.css theme instead (e.g., bg-node-component-surface)
Use Vue 3.5+ TypeScript style default prop declaration with reactive destructuring - prefer useModel to prop/emit pairs, do not use withDefaults
Do not import Vue macros unnecessarily
Use vue-i18n in composition API for string literals - place translation entries in src/locales/en/main.json
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Avoid new usage of PrimeVue components

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

src/**/*.{vue,ts}: Avoid using ref and watch together - use computed instead if possible
Do not add ref if a prop would suffice; do not add computed if the ref/prop directly would work; use watch only when computed won't accomplish the goal
Leverage VueUse functions for performance-enhancing styles

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates
Use es-toolkit for utility functions
Avoid mutable state - prefer immutability and assignment at point of declaration
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Vue components must be named in PascalCase (e.g., MenuHamburger.vue)

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{js,ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript exclusively - no new JavaScript files

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{ts,tsx,vue,js}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx,vue,js}: Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see .prettierrc
Sort and group imports by plugin, run pnpm format before committing

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

🧠 Learnings (20)

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Extract complex conditionals to computed properties

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-09T21:40:12.361Z

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-04T21:47:07.812Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/LiteGraphCanvasSplitterOverlay.vue:43-43
Timestamp: 2025-12-04T21:47:07.812Z
Learning: In Vue SFCs with a build step (pre-compilation), kebab-case attribute names in templates are automatically converted to camelCase, so `:sidebar-panel-visible` as a shorthand binding correctly resolves to a variable named `sidebarPanelVisible`. The `.camel` modifier is only needed when using in-DOM templates without a build step.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Do not add `ref` if a prop would suffice; do not add `computed` if the ref/prop directly would work; use `watch` only when `computed` won't accomplish the goal

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T21:15:46.862Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-05T06:11:09.383Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7177
File: src/platform/assets/components/UploadModelFooter.vue:72-78
Timestamp: 2025-12-05T06:11:09.383Z
Learning: For the ComfyUI_frontend repository, avoid suggesting comments that would be redundant when the code is already self-explanatory through descriptive naming (e.g., filenames, prop names, aria-labels). The project prefers clean code without unnecessary documentation comments.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Prefer single line `if` syntax over adding curly braces, when the statement has a very concise expression and concise, single line statement

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement computed properties with computed()

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Implement computed() for derived state in Vue 3 Composition API

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Avoid using `ref` and `watch` together - use `computed` instead if possible

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-09T03:49:52.828Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-16T22:26:49.463Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T02:07:38.870Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T16:03:02.066Z

Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: test
• GitHub Check: lint-and-format
• GitHub Check: setup
• GitHub Check: collect

🔇 Additional comments (3)

src/components/LiteGraphCanvasSplitterOverlay.vue (3)

170-177: LGTM!

The splitterRefreshKey correctly includes both rightSidePanelVisible and sidebarLocation, ensuring the splitter recalculates layout and panel order when either changes. This implementation aligns with the PR objectives.

---

179-191: LGTM!

The firstPanelStyle and lastPanelStyle computed properties correctly manage panel visibility using display:none while keeping the panels in the DOM for the splitter component. Returning undefined when not applicable is appropriate and avoids unnecessary style bindings.

The approach works well with the CSS rules at lines 206-209 that hide the gutter when adjacent panels are hidden.

---

25-54: Consider adding accessibility attributes to the properties panel.

When sidebarLocation === 'right', the first panel renders the properties panel but doesn't provide role or aria-label attributes. While the sidebar correctly receives these attributes (lines 41-44), the properties panel lacks semantic information for assistive technologies.

Consider adding similar accessibility attributes for the properties panel case:

 <SplitterPanel
   v-if="
     !focusMode && (sidebarLocation === 'left' || rightSidePanelVisible)
   "
   :class="
     sidebarLocation === 'left'
       ? cn(
           'side-bar-panel bg-comfy-menu-bg pointer-events-auto',
           sidebarPanelVisible && 'min-w-78'
         )
       : 'bg-comfy-menu-bg pointer-events-auto'
   "
   :min-size="sidebarLocation === 'left' ? 10 : 15"
   :size="20"
   :style="firstPanelStyle"
-  :role="sidebarLocation === 'left' ? 'complementary' : undefined"
+  :role="'complementary'"
   :aria-label="
-    sidebarLocation === 'left' ? t('sideToolbar.sidebar') : undefined
+    sidebarLocation === 'left' ? t('sideToolbar.sidebar') : t('sideToolbar.properties')
   "
 >

Note: Verify that sideToolbar.properties exists in the i18n file or add an appropriate key.

⛔ Skipped due to learnings

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:54.349Z
Learning: For Vue components in Comfy-Org/ComfyUI_frontend: Do not suggest adding aria-label to buttons that already have visible text content (e.g., <span> elements with labels). The visible text automatically provides the accessible name. aria-label should only be used for elements without visible labels, such as icon-only buttons.

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer

[DrJKL]

Nit: I'd probably just do this with a single template string

[csongorczezar]

Done

[DrJKL]

Question: Could this be done with tailwind utilities instead of through the style attribute?

[csongorczezar]

Great observation. With this we are removing the computed styles.
Done!

[csongorczezar]

Reverted back to the original way, because Tailwind was interacting differently with PrimeVue's Splitter component, causing subtle layout shifts that affect the canvas rendering.

[DrJKL]

😢

[DrJKL]

The global t function is deprecated. Could you use the useI18n composable instead?

[csongorczezar]

Done!

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (3)

src/components/LiteGraphCanvasSplitterOverlay.vue (3)

25-54: Consider extracting complex conditionals to computed properties for improved readability.

The first panel contains multiple inline conditionals based on sidebarLocation. Extracting these to computed properties would align with coding guidelines and improve maintainability:

const isFirstPanelSidebar = computed(() => sidebarLocation.value === 'left')
const firstPanelVisible = computed(() => 
  !focusMode.value && (isFirstPanelSidebar.value || rightSidePanelVisible.value)
)
const firstPanelMinSize = computed(() => isFirstPanelSidebar.value ? 10 : 15)

The current implementation is functionally correct. This is a recommended refactor for readability.

Based on coding guidelines and similar to past review feedback.

---

85-111: Add accessibility attributes for the properties panel.

When sidebarLocation === 'left', this panel renders the properties panel (line 106) but lacks role and aria-label attributes. These should be provided for screen reader accessibility:

 <SplitterPanel
   v-if="
     !focusMode && (sidebarLocation === 'right' || rightSidePanelVisible)
   "
   :class="
     sidebarLocation === 'right'
       ? cn(
           'side-bar-panel bg-comfy-menu-bg pointer-events-auto',
           sidebarPanelVisible && 'min-w-78'
         )
       : 'bg-comfy-menu-bg pointer-events-auto'
   "
   :min-size="sidebarLocation === 'right' ? 10 : 15"
   :size="20"
   :style="lastPanelStyle"
-  :role="sidebarLocation === 'right' ? 'complementary' : undefined"
+  role="complementary"
   :aria-label="
-    sidebarLocation === 'right' ? t('sideToolbar.sidebar') : undefined
+    sidebarLocation === 'right' ? t('sideToolbar.sidebar') : t('sideToolbar.properties')
   "
 >

Ensure sideToolbar.properties exists in src/locales/en/main.json.

---

125-125: Replace deprecated global t with useI18n composable.

The global t function is deprecated. Use the useI18n composable instead.

🔎 Proposed fix

-import { t } from '@/i18n'
 import { useSettingStore } from '@/platform/settings/settingStore'
+import { useI18n } from 'vue-i18n'

Then add in the setup section after imports:

const { t } = useI18n()

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a87e31 and aecf8d8.

📒 Files selected for processing (1)

• src/components/LiteGraphCanvasSplitterOverlay.vue (4 hunks)

🧰 Additional context used

📓 Path-based instructions (11)

src/**/*.vue

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions

src/**/*.vue: Vue 3 SFCs must use Composition API only - no Options API
Use <script setup lang="ts"> for component logic
Use Tailwind 4 utility classes for styling - avoid <style> blocks
Use cn() utility from @/utils/tailwindUtil to merge Tailwind class names - never use :class="[]" syntax
Never use the dark: Tailwind variant - use semantic values from style.css theme instead (e.g., bg-node-component-surface)
Use Vue 3.5+ TypeScript style default prop declaration with reactive destructuring - prefer useModel to prop/emit pairs, do not use withDefaults
Do not import Vue macros unnecessarily
Use vue-i18n in composition API for string literals - place translation entries in src/locales/en/main.json
Implement proper props and emits definitions in Vue components
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Avoid new usage of PrimeVue components

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

src/**/*.{vue,ts}: Avoid using ref and watch together - use computed instead if possible
Do not add ref if a prop would suffice; do not add computed if the ref/prop directly would work; use watch only when computed won't accomplish the goal
Leverage VueUse functions for performance-enhancing styles

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

src/**/*.{ts,tsx,vue}: ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates
Use es-toolkit for utility functions
Avoid mutable state - prefer immutability and assignment at point of declaration
Never use any type - use proper TypeScript types
Never use as any type assertions - fix the underlying type issue

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/{composables,components}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Clean up subscriptions in state management to prevent memory leaks

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/{components,composables}/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Use vue-i18n for ALL user-facing strings by adding them to src/locales/en/main.json

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.vue

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.vue: Use setup() function in Vue 3 Composition API
Destructure props using Vue 3.5 style in Vue components
Use ref/reactive for state management in Vue 3 Composition API
Implement computed() for derived state in Vue 3 Composition API
Use provide/inject for dependency injection in Vue components
Prefer emit/@event-name for state changes over other communication patterns
Use defineExpose only for imperative operations (such as form.validate(), modal.open())
Replace PrimeVue Dropdown component with Select
Replace PrimeVue OverlayPanel component with Popover
Replace PrimeVue Calendar component with DatePicker
Replace PrimeVue InputSwitch component with ToggleSwitch
Replace PrimeVue Sidebar component with Drawer
Replace PrimeVue Chips component with AutoComplete with multiple enabled
Replace PrimeVue TabMenu component with Tabs without panels
Replace PrimeVue Steps component with Stepper without panels
Replace PrimeVue InlineMessage component with Message
Extract complex conditionals to computed properties
Implement cleanup for async operations in Vue components
Use lifecycle hooks: onMounted, onUpdated in Vue 3 Composition API
Use Teleport/Suspense when needed for component rendering
Define proper props and emits definitions in Vue components

Vue components must be named in PascalCase (e.g., MenuHamburger.vue)

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.{vue,css}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,css}: Use Tailwind CSS only for styling (no custom CSS)
Use the correct tokens from style.css in the design system package

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/components/**/*.{vue,ts,js}

📄 CodeRabbit inference engine (src/components/CLAUDE.md)

src/components/**/*.{vue,ts,js}: Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Use useIntersectionObserver for visibility detection instead of custom scroll handlers
Use vue-i18n for ALL UI strings

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{js,ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

Use TypeScript exclusively - no new JavaScript files

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

src/**/*.{ts,tsx,vue,js}

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.{ts,tsx,vue,js}: Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see .prettierrc
Sort and group imports by plugin, run pnpm format before committing

Files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

🧠 Learnings (28)

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Sidebar component with Drawer

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Extract complex conditionals to computed properties

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-09T21:40:12.361Z

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-04T21:47:07.812Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/components/LiteGraphCanvasSplitterOverlay.vue:43-43
Timestamp: 2025-12-04T21:47:07.812Z
Learning: In Vue SFCs with a build step (pre-compilation), kebab-case attribute names in templates are automatically converted to camelCase, so `:sidebar-panel-visible` as a shorthand binding correctly resolves to a variable named `sidebarPanelVisible`. The `.camel` modifier is only needed when using in-DOM templates without a build step.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Do not replace `&&=` or `||=` with `=` when there is no reason to do so. If you do find a reason to remove either `&&=` or `||=`, leave a comment explaining why the removal occurred

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Do not add `ref` if a prop would suffice; do not add `computed` if the ref/prop directly would work; use `watch` only when `computed` won't accomplish the goal

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T21:15:46.862Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-05T06:11:09.383Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7177
File: src/platform/assets/components/UploadModelFooter.vue:72-78
Timestamp: 2025-12-05T06:11:09.383Z
Learning: For the ComfyUI_frontend repository, avoid suggesting comments that would be redundant when the code is already self-explanatory through descriptive naming (e.g., filenames, prop names, aria-labels). The project prefers clean code without unnecessary documentation comments.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Prefer single line `if` syntax over adding curly braces, when the statement has a very concise expression and concise, single line statement

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Implement computed properties with computed()

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Implement computed() for derived state in Vue 3 Composition API

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{vue,ts} : Avoid using `ref` and `watch` together - use `computed` instead if possible

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-10T03:09:19.636Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7303
File: src/components/topbar/CurrentUserPopover.test.ts:199-205
Timestamp: 2025-12-10T03:09:19.636Z
Learning: For test files in the Comfy-Org/ComfyUI_frontend repository: When writing tests, prefer selecting elements by accessible properties (text content, aria-label, role, accessible name) over data-testid attributes. This ensures tests verify actual user-facing behavior and accessibility compliance.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.vue : Use Tailwind 4 utility classes for styling - avoid `<style>` blocks

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Use Tailwind CSS for styling

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:02.860Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/{components,composables}/**/*.{ts,tsx,vue} : Use vue-i18n for ALL user-facing strings by adding them to `src/locales/en/main.json`

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.vue : Use vue-i18n in composition API for string literals - place translation entries in `src/locales/en/main.json`

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use vue-i18n for ALL UI strings

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-05T20:35:28.330Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7137
File: src/locales/en/main.json:2257-2272
Timestamp: 2025-12-05T20:35:28.330Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, vue-i18n pluralization uses a two-parameter pattern: `t('key', { count: value })` where the `count` property in the interpolation object automatically triggers plural selection from pipe-separated locale strings (e.g., "no items | 1 item | {count} items"). This is the correct pattern used throughout the codebase, as validated by Playwright tests.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Steps component with Stepper without panels

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-11-24T19:47:45.616Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue TabMenu component with Tabs without panels

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-09T03:49:52.828Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-16T22:26:49.463Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T02:07:38.870Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

📚 Learning: 2025-12-18T16:03:02.066Z

Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.

Applied to files:

• src/components/LiteGraphCanvasSplitterOverlay.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: lint-and-format
• GitHub Check: test
• GitHub Check: setup
• GitHub Check: collect

🔇 Additional comments (2)

src/components/LiteGraphCanvasSplitterOverlay.vue (2)

167-172: LGTM! Splitter refresh key correctly tracks both visibility and location.

The computed key properly combines rightSidePanelVisible and sidebarLocation to trigger layout recalculation when either changes. This ensures the splitter correctly handles dynamic panel positioning.

---

56-56: LGTM! Clear comment improves code readability.

The comment helpfully documents that the main panel is always present regardless of sidebar configuration.

[comfydesigner]

Can't comment on the code per say, but checked out the branch and the properties panel seems to be functioning as we discussed. Looks good to me