eslint issue on windows by jtydhr88 · Pull Request #7634 · Comfy-Org/ComfyUI_frontend

jtydhr88 · 2025-12-19T03:19:43Z

Summary

fix eslint issue on windows

┆Issue is synchronized with this Notion page by Unito

coderabbitai · 2025-12-19T03:19:56Z

📝 Walkthrough

Walkthrough

ESLint configuration updated to replace eslint-plugin-prettier/recommended with eslint-config-prettier. Workaround comments added documenting Node 24 segfault risk mitigation. Prettier execution is noted as delegated to lint-staged. Dev dependency eslint-plugin-prettier removed from package manifests.

Changes

Cohort / File(s)	Change Summary
ESLint configuration `eslint.config.ts`	Replaced `eslint-plugin-prettier/recommended` with `eslint-config-prettier`; added comments explaining Node 24 segfault risk and that Prettier runs via lint-staged.
Package manifests `package.json`, `pnpm-workspace.yaml`	Removed `eslint-plugin-prettier` from devDependencies / catalog entries, dropping the plugin from the workspace/dev deps.

Possibly related PRs

fix(desktop-ui): resolve linting and typecheck errors #7271: Modifies ESLint configuration in eslint.config.ts (path resolution changes) — related to other ESLint config edits.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch lint-win

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7d5cda and 1619ff5.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (3)

eslint.config.ts (2 hunks)
package.json (0 hunks)
pnpm-workspace.yaml (0 hunks)

💤 Files with no reviewable changes (2)

package.json
pnpm-workspace.yaml

🧰 Additional context used

🧠 Learnings (10)

📓 Common learnings

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:24.164Z
Learning: The project has CI automation that handles code formatting (pnpm format) automatically, so manual formatting suggestions should not be provided in code reviews for the Comfy-Org/ComfyUI_frontend repository.

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Run ESLint instead of manually figuring out whitespace fixes or other trivial style concerns using the `pnpm lint:fix` command

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{ts,tsx,vue,js} : Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see `.prettierrc`

📚 Learning: 2025-11-24T19:47:56.371Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{js,ts,jsx,tsx} : Run ESLint instead of manually figuring out whitespace fixes or other trivial style concerns using the `pnpm lint:fix` command

Applied to files:

eslint.config.ts

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{ts,tsx,vue,js} : Indent with 2 spaces, use single quotes, no trailing semicolons, line width 80 - see `.prettierrc`

Applied to files:

eslint.config.ts

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{ts,tsx,vue} : ESLint rules: Vue + TS rules, no floating promises, unused imports disallowed, i18n raw text restrictions in templates

Applied to files:

eslint.config.ts

📚 Learning: 2025-12-17T01:01:03.609Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-17T01:01:03.609Z
Learning: Applies to src/**/*.{ts,tsx,vue,js} : Sort and group imports by plugin, run `pnpm format` before committing

Applied to files:

eslint.config.ts

📚 Learning: 2025-11-24T19:47:34.324Z

Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:34.324Z
Learning: Applies to src/**/*.{ts,tsx,vue} : Avoid using ts-expect-error; use proper TypeScript types instead

Applied to files:

eslint.config.ts

📚 Learning: 2025-12-13T11:03:11.264Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

eslint.config.ts

📚 Learning: 2025-12-09T03:39:54.501Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

eslint.config.ts

📚 Learning: 2025-12-17T00:40:09.635Z

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

eslint.config.ts

📚 Learning: 2025-12-11T12:25:15.470Z

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

eslint.config.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: setup
GitHub Check: comment-on-pr-start
GitHub Check: test
GitHub Check: lint-and-format
GitHub Check: collect

🔇 Additional comments (2)

eslint.config.ts (2)

114-115: Configuration correctly updated.

The usage of eslint-config-prettier is correct. This will disable ESLint rules that conflict with Prettier formatting while relying on separate Prettier execution (via lint-staged and CI) to enforce formatting.

7-10: Good workaround documentation.

Node.js v24.2.0 causes segmentation faults on WSL2, making the switch from eslint-plugin-prettier to eslint-config-prettier a valid approach. These rules are safe to use if you run eslint --fix and prettier --write as separate steps. Ensure Prettier runs through your lint-staged configuration and CI pipeline independently to catch formatting issues.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-19T03:20:03Z

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 12/19/2025, 08:06:43 PM UTC

📈 Summary

Total Tests: 11
Passed: 10 ✅
Failed: 0
Flaky: 1 ⚠️
Skipped: 0

📊 Test Reports by Browser

❌ chromium: Deployment failed
✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ mobile-chrome: View Report • ✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

github-actions · 2025-12-19T03:20:07Z

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 12/19/2025, 07:59:22 PM UTC

🔗 Links

📊 View Workflow Run
🎨 View Storybook

🎉 Your Storybook is ready for review!

github-actions · 2025-12-19T03:22:26Z

Bundle Size Report

Summary

Raw size: 16.6 MB baseline 16.6 MB — ⚪ 0 B
Gzip: 3.37 MB baseline 3.37 MB — ⚪ 0 B
Brotli: 2.6 MB baseline 2.6 MB — ⚪ 0 B
Bundles: 99 current • 99 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (8.46 MB) · Other ⚪ 0 B (3.44 MB) · App Entry Points ⚪ 0 B (3.21 MB) · Graph Workspace ⚪ 0 B (997 kB) · Panels & Settings ⚪ 0 B (297 kB) · UI Components ⚪ 0 B (184 kB) · + 3 more

Per-category breakdown

App Entry Points — 3.21 MB (baseline 3.21 MB) • ⚪ 0 B

Main entry bundles and manifests

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/index-B8ZjncxJ.js	2.98 MB	2.98 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/index-BLFxjp1R.js	345 B	345 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/index-CH9AE5wQ.js	227 kB	227 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Graph Workspace — 997 kB (baseline 997 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/GraphView-DWEd1lQq.js	997 kB	997 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/UserSelectView-Kj_aLhyH.js	6.54 kB	6.54 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Panels & Settings — 297 kB (baseline 297 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/AboutPanel-CKn8UnRR.js	9.16 kB	9.16 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/ExtensionPanel-BMtapK-f.js	10.8 kB	10.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/KeybindingPanel-DlDpk8Uq.js	13.6 kB	13.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/LegacyCreditsPanel-C2Qgb1tm.js	21.4 kB	21.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/ServerConfigPanel-BdmGp3Rb.js	7.07 kB	7.07 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BhbWhsRg.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BvFz-TmQ.js	33.1 kB	33.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-BxYnTA2y.js	21.5 kB	21.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C6bMjAne.js	27.1 kB	27.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-C7Yhp7H7.js	24 kB	24 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CsnOn8G0.js	25.7 kB	25.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-D5BGNZ7M.js	24.8 kB	24.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-D7k3huHm.js	25 kB	25 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DamkILzl.js	26.4 kB	26.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-s1k0gw1Y.js	20.9 kB	20.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/UserPanel-CZ9nutRs.js	6.23 kB	6.23 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

UI Components — 184 kB (baseline 184 kB) • ⚪ 0 B

Reusable component library chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/ComfyQueueButton-mTgBDwrm.js	8.49 kB	8.49 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/LazyImage.vue_vue_type_script_setup_true_lang-BLdVlY-_.js	48.4 kB	48.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/Load3D.vue_vue_type_script_setup_true_lang-DFskC1ax.js	53.5 kB	53.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-BQosCyAL.js	897 B	897 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-Bumg4_L2.js	1.34 kB	1.34 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetButton-z3dAsplW.js	2.04 kB	2.04 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-BM_DnOVi.js	14.3 kB	14.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-B56cwveW.js	2.14 kB	2.14 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-B4T8CvsY.js	48.8 kB	48.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-YhcMch_H.js	3.68 kB	3.68 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/audioService-2eU3Q4uR.js	2.2 kB	2.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/keybindingService-tGO_yGgR.js	7.51 kB	7.51 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/serverConfigStore-7JI8VFS2.js	2.83 kB	2.83 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Utilities & Hooks — 1.86 kB (baseline 1.86 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/audioUtils-Bkg1ZMqT.js	1.41 kB	1.41 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeFilterUtil-CXKCRJ-m.js	460 B	460 B	⚪ 0 B	⚪ 0 B	⚪ 0 B

Vendor & Third-Party — 8.46 MB (baseline 8.46 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/vendor-chart-DaR9dw3X.js	452 kB	452 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-other-Cf7iqkoX.js	3.86 MB	3.86 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-primevue-DZ--Ysu_.js	1.96 MB	1.96 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-three-C1LfRdh4.js	1.37 MB	1.37 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-tiptap-C1NB2Q_L.js	232 kB	232 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-vue-DSfeuQOV.js	160 kB	160 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-xterm-BF8peZ5_.js	420 kB	420 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Other — 3.44 MB (baseline 3.44 MB) • ⚪ 0 B

Bundles that do not match a named category

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/AudioPreviewPlayer-AygdYHkE.js	13.4 kB	13.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-BWp4HdfU.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CcfGaui5.js	14.4 kB	14.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CisfgZf5.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CkU12Foh.js	13 kB	13 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CoH2DJa6.js	14.2 kB	14.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-COSt-Bjx.js	14.9 kB	14.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DalfIW5f.js	15.9 kB	15.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DfTl0eCm.js	13.5 kB	13.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DwSJL865.js	13.7 kB	13.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-Zxyx15Vd.js	12.8 kB	12.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/Load3D-B11rrLMj.js	424 B	424 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BDhxs-bB.js	79.9 kB	79.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-BtXVDFw6.js	84.7 kB	84.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Buv6RhU4.js	82.4 kB	82.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CgJ6zvJL.js	97.2 kB	97.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CI9qb0E5.js	112 kB	112 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cu4LqtW0.js	81.6 kB	81.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Cw9RZWRY.js	89 B	89 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Dm19QY4N.js	92.2 kB	92.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Tihe0h_r.js	71.3 kB	71.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-wPWMutMw.js	70.4 kB	70.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/Media3DBottom-BQKoM6q8.js	1.5 kB	1.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/Media3DTop-BigQIn7j.js	1.49 kB	1.49 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaAudioBottom-CsJt9IOe.js	1.51 kB	1.51 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaAudioTop-Dr0afgCA.js	1.46 kB	1.46 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaImageBottom-DjbheCQ0.js	1.55 kB	1.55 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaImageTop-BXa-oKEc.js	1.75 kB	1.75 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaVideoBottom-Cg128kLD.js	1.5 kB	1.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/MediaVideoTop-BVdg2b8C.js	2.65 kB	2.65 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-1Vh3MCrN.js	240 kB	240 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-aW9En70v.js	260 kB	260 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BIckSVgU.js	273 kB	273 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BiYpVi7D.js	263 kB	263 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js	101 B	101 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CCEXtYfM.js	243 kB	243 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CvmVDWYd.js	323 kB	323 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-D_wreoPJ.js	267 kB	267 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Dz-0ZIBN.js	297 kB	297 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-VZsNmhG7.js	264 kB	264 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/SubscriptionRequiredDialogContent-exHhOhYQ.js	28.1 kB	28.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/ValueControlPopover-CG48HeO0.js	5.49 kB	5.49 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetAudioUI-kikeSp0b.js	2.94 kB	2.94 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetChart-DT6E_SOn.js	2.48 kB	2.48 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetColorPicker-x-rLAapO.js	3.41 kB	3.41 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetGalleria-Dv_6AB3x.js	4.1 kB	4.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetImageCompare-BB9nVmFq.js	2.21 kB	2.21 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetInputNumber-Dt3N_9qz.js	673 B	673 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetInputText-DE5Og5WD.js	1.99 kB	1.99 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetLegacy-ntNE20CU.js	364 B	364 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetMarkdown-CoBFy2vN.js	3.08 kB	3.08 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js	1.28 kB	1.28 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetRecordAudio-CD2PyyAf.js	20.4 kB	20.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetSelect-53nwmHTT.js	733 B	733 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetTextarea-BspJF9hL.js	3.08 kB	3.08 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/WidgetToggleSwitch-PI-JGSJE.js	1.76 kB	1.76 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

DrJKL · 2025-12-19T04:18:38Z

knip --fix should remove the dep for you.

## Summary fix eslint issue on windows ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7634-eslint-issue-on-windows-2ce6d73d365081f785def469045f57bd) by [Unito](https://www.unito.io) --------- Co-authored-by: DrJKL <DrJKL0424@gmail.com>

jtydhr88 requested a review from a team as a code owner December 19, 2025 03:19

dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 19, 2025

DrJKL previously approved these changes Dec 19, 2025

View reviewed changes

DrJKL dismissed their stale review via d3d526a December 19, 2025 19:56

dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 19, 2025

DrJKL approved these changes Dec 19, 2025

View reviewed changes

jtydhr88 and others added 2 commits December 19, 2025 11:57

eslint issue on windows

e233825

knip: Remove dependency

1619ff5

DrJKL force-pushed the lint-win branch from d3d526a to 1619ff5 Compare December 19, 2025 19:57

DrJKL requested review from csongorczezar and simula-r December 19, 2025 20:05

DrJKL merged commit ac1b551 into main Dec 19, 2025
20 of 27 checks passed

DrJKL deleted the lint-win branch December 19, 2025 20:06

christian-byrne mentioned this pull request Jan 5, 2026

Bump comfyui-frontend-package to 1.36.13 Comfy-Org/ComfyUI#11645

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eslint issue on windows#7634

eslint issue on windows#7634
DrJKL merged 2 commits intomainfrom
lint-win

jtydhr88 commented Dec 19, 2025 •

edited by sync-by-unito bot

Loading

Uh oh!

coderabbitai bot commented Dec 19, 2025 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Uh oh!

github-actions bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 19, 2025 •

edited

Loading

Uh oh!

DrJKL commented Dec 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jtydhr88 commented Dec 19, 2025 • edited by sync-by-unito bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

coderabbitai bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Uh oh!

github-actions bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

📈 Summary

📊 Test Reports by Browser

Uh oh!

github-actions bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🔗 Links

Uh oh!

github-actions bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Report

Uh oh!

DrJKL commented Dec 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jtydhr88 commented Dec 19, 2025 •

edited by sync-by-unito bot

Loading

coderabbitai bot commented Dec 19, 2025 •

edited

Loading

github-actions bot commented Dec 19, 2025 •

edited

Loading

github-actions bot commented Dec 19, 2025 •

edited

Loading

github-actions bot commented Dec 19, 2025 •

edited

Loading