Hide queue overlay header menu on cloud (#7571)#7573
Hide queue overlay header menu on cloud (#7571)#7573benceruleanlu merged 2 commits intocloud/1.35from
Conversation
Hide the QueueOverlayHeader more-options (…) menu when running in Cloud distribution This is being hidden instead of fixed because it deletes all user assets on cloud, will be touched by /jobs, replaced by the second iteration of design changes, along with changes to asset deletion happening soon. It would be too risky to have a proper fix for it in the cloud deploy today. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7571-Hide-queue-overlay-header-menu-on-cloud-2cb6d73d3650815a8faac8a8f0de91f0) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
dosubot
bot
added
the
size:XS
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright Test Results⏰ Completed at: 12/16/2025, 10:00:09 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/16/2025, 09:50:54 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
There was a problem hiding this comment.
Pull request overview
This PR hides the QueueOverlayHeader's more-options menu (…) when running in the Cloud distribution to prevent users from accidentally deleting all their assets. The menu is temporarily hidden rather than fixed because it will be replaced by upcoming design changes and improvements to asset deletion functionality.
- Conditionally hide the more-options menu in QueueOverlayHeader based on the
isCloudflag - Add defensive checks to node resize handler to prevent unintended resize operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/queue/QueueOverlayHeader.vue | Adds conditional rendering (v-if="!isCloud") to hide the more-options menu and Popover component in Cloud distribution, and imports the isCloud flag |
| src/renderer/extensions/vueNodes/components/LGraphNode.vue | Adds button type check and pointer event handling check to handleResizePointerDown to prevent resize operations with non-primary mouse buttons or when pointer events should not be handled |
| </span> | ||
| </div> | ||
| <div class="flex items-center gap-1"> | ||
| <div v-if="!isCloud" class="flex items-center gap-1"> |
There was a problem hiding this comment.
The conditional hiding of the menu options based on isCloud requires corresponding test updates. The existing test file QueueOverlayHeader.test.ts needs to be modified to test both cloud and non-cloud scenarios, as the current test expects the "More options" button to be present which will now only render when isCloud is false.
There was a problem hiding this comment.
Literally first time I ever saw copilot give a suggestion
2 participants
Hide the QueueOverlayHeader more-options (…) menu when running in Cloud
distribution
This is being hidden instead of fixed because it deletes all user assets
on cloud, will be touched by /jobs, replaced by the second iteration of
design changes, along with changes to asset deletion happening soon. It
would be too risky to have a proper fix for it in the cloud deploy
today.
┆Issue is synchronized with this Notion page by Unito