Skip to content

[backport core/1.34] feat: bring node to front when clicking on any widget#7520

Merged
christian-byrne merged 1 commit intocore/1.34from
backport-7202-to-core-1.34
Dec 16, 2025
Merged

[backport core/1.34] feat: bring node to front when clicking on any widget#7520
christian-byrne merged 1 commit intocore/1.34from
backport-7202-to-core-1.34

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Dec 15, 2025

Summary

Backport of #7202 to core/1.34

  • Adds a capture-phase pointerdown handler to NodeWidgets that calls bringNodeToFront whenever any widget is clicked
  • Improves UX by ensuring the interacted node is always visible on top, without requiring the node itself to be selected

fix #7131

┆Issue is synchronized with this Notion page by Unito

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Dec 15, 2025
@christian-byrne christian-byrne requested a review from a team as a code owner December 15, 2025 21:36
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Dec 15, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-7202-to-core-1.34

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 12/15/2025, 10:43:22 PM UTC

📈 Summary

  • Total Tests: 479
  • Passed: 451 ✅
  • Failed: 10 ❌
  • Flaky: 8 ⚠️
  • Skipped: 10 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 448 / ❌ 10 / ⚠️ 8 / ⏭️ 10
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: Deployment failed

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 12/15/2025, 10:00:59 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

- Adds a capture-phase pointerdown handler to NodeWidgets that calls
`bringNodeToFront` whenever any widget is clicked
- Improves UX by ensuring the interacted node is always visible on top,
without requiring the node itself to be selected

fix #7131

https://github.com/user-attachments/assets/c2c2ff0e-6e5a-49f2-bf2e-333950559ada

https://github.com/user-attachments/assets/fc3db735-20eb-40b5-9101-278badc4698e

- [ ] Click on any widget (button, dropdown, input, etc.) within a Vue
node
- [ ] Verify the node moves to the front (highest z-index) when the
widget is clicked
- [ ] Verify existing widget functionality is unaffected

---------

Co-authored-by: github-actions <github-actions@github.com>
@christian-byrne christian-byrne force-pushed the backport-7202-to-core-1.34 branch from 9f8ab23 to 7469f16 Compare December 15, 2025 21:58
@christian-byrne christian-byrne merged commit c5ebb47 into core/1.34 Dec 16, 2025
22 of 25 checks passed
@christian-byrne christian-byrne deleted the backport-7202-to-core-1.34 branch December 16, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants