Skip to content

Fix: Properties Panel update when updating nodes #7518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DrJKL wants to merge 1 commit into from
Closed

Fix: Properties Panel update when updating nodes #7518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/rightSidePanel/settings/TabSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@

<script setup lang="ts">
import ToggleSwitch from 'primevue/toggleswitch'
import { computed } from 'vue'
import { computed, ref } from 'vue'
import { useI18n } from 'vue-i18n'

import { LGraphCanvas, LiteGraph } from '@/lib/litegraph/src/litegraph'
Expand All @@ -102,8 +102,10 @@ const isLightTheme = computed(
() => colorPaletteStore.completedActivePalette.light_theme
)

const version = ref(0)
const nodeState = computed({
get(): LGraphNode['mode'] | null {
version.value
if (!nodes.length) return null
if (nodes.length === 1) {
return nodes[0].mode
Expand All @@ -121,17 +123,20 @@ const nodeState = computed({
nodes.forEach((node) => {
node.mode = value
})
version.value++
canvasStore.canvas?.setDirty(true, true)
}
})

// Pinned state
const isPinned = computed<boolean>({
get() {
version.value
return nodes.some((node) => node.pinned)
},
set(value) {
nodes.forEach((node) => node.pin(value))
version.value++
canvasStore.canvas?.setDirty(true, true)
}
})
Expand Down Expand Up @@ -175,6 +180,7 @@ const colorOptions: NodeColorOption[] = [

const nodeColor = computed<NodeColorOption['name'] | null>({
get() {
version.value
if (nodes.length === 0) return null
const theColorOptions = nodes.map((item) => item.getColorOption())

Expand Down Expand Up @@ -205,6 +211,7 @@ const nodeColor = computed<NodeColorOption['name'] | null>({
for (const item of nodes) {
item.setColorOption(canvasColorOption)
}
version.value++
canvasStore.canvas?.setDirty(true, true)
}
})
Expand Down
Loading