Skip to content

[backport core/1.34] add warning when using legacy mask editor (indicating it will be removed in next version)#7513

Merged
christian-byrne merged 1 commit intocore/1.34from
backport-7332-to-core-1.34
Dec 15, 2025
Merged

[backport core/1.34] add warning when using legacy mask editor (indicating it will be removed in next version)#7513
christian-byrne merged 1 commit intocore/1.34from
backport-7332-to-core-1.34

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Dec 15, 2025

Backport of #7332 to core/1.34

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

…ved in next version) (#7332)

## Summary

Telemetry data shows zero users using the legacy mask editor. It has
been considerable time since we switched to the new one, and there
really is no reason to use the legacy version given how lacking it is.

Will add this warning for 1 minor version just for maximum safety then
remove all legacy mask editor code.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7332-add-warning-when-using-legacy-mask-editor-indicating-it-will-be-removed-in-next-version-2c66d73d365081a0bad7d63ba4d414af)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Dec 15, 2025
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Dec 15, 2025
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 12/15/2025, 07:38:46 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 12/15/2025, 08:55:20 PM UTC

📈 Summary

  • Total Tests: 495
  • Passed: 481 ✅
  • Failed: 0
  • Flaky: 4 ⚠️
  • Skipped: 10 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 472 / ❌ 0 / ⚠️ 4 / ⏭️ 10
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne merged commit 0e19ed2 into core/1.34 Dec 15, 2025
38 checks passed
@christian-byrne christian-byrne deleted the backport-7332-to-core-1.34 branch December 15, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants