Skip to content

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Dec 15, 2025

Backport of #7400 to core/1.34

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

Adds a desktop-only "Custom Nodes Manager" topbar button (Lucide puzzle)
in its own bordered island left of the actionbar. Button opens the
manager via useManagerState().openManager().

- New i18n key: menu.customNodesManager

<img width="318" height="147" alt="image"
src="https://github.com/user-attachments/assets/e36c5c7f-80d1-454c-87de-e0daa822fad1"
/>

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7400-Topbar-add-Custom-Nodes-Manager-button-2c76d73d3650810b9122da61a3c4be39)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Dec 15, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 15, 2025
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 12/15/2025, 06:30:27 PM UTC

📈 Summary

  • Total Tests: 489
  • Passed: 469 ✅
  • Failed: 2 ❌
  • Flaky: 8 ⚠️
  • Skipped: 10 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 460 / ❌ 2 / ⚠️ 8 / ⏭️ 10
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 12/15/2025, 05:37:54 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@benceruleanlu
Copy link
Member

There are two failing tests.

The first is interesting, because it seems like a flaky run had their snapshot merged, because it seems like the actual is indeed the expected, and the expected is the one that is bugged.

image

The second seems unrelated and I've seen it flake before.

image

@benceruleanlu benceruleanlu added the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 15, 2025
@github-actions
Copy link

Updating Playwright Expectations

@benceruleanlu benceruleanlu merged commit 3f61119 into core/1.34 Dec 15, 2025
38 of 40 checks passed
@benceruleanlu benceruleanlu deleted the backport-7400-to-core-1.34 branch December 15, 2025 20:54
@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants