-
Notifications
You must be signed in to change notification settings - Fork 462
remove user.css on cloud to prevent failed requests on startup #7442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@christian-byrne has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 53 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes relocate stylesheet link injection from static HTML to a post-build Vite plugin that conditionally injects stylesheets only in non-cloud deployments, removing the links from index.html and adding dynamic injection logic to vite.config.mts. Changes
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/13/2025, 10:57:56 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 12/13/2025, 11:07:06 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.24 MB (baseline 3.24 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 985 kB (baseline 985 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 178 kB (baseline 178 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.81 MB (baseline 3.81 MB) • ⚪ 0 BBundles that do not match a named category
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
index.html(0 hunks)vite.config.mts(1 hunks)
💤 Files with no reviewable changes (1)
- index.html
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Use Vite for fast development and building
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Use Vite for fast development and building
📚 Learning: 2025-12-01T23:42:30.894Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7084
File: src/renderer/extensions/vueNodes/components/SlotConnectionDot.vue:23-26
Timestamp: 2025-12-01T23:42:30.894Z
Learning: In the ComfyUI frontend codebase, Tailwind CSS is configured with Preflight enabled (default), which automatically provides `content: ''` for pseudo-elements when using `after:` or `before:` variants - no need to explicitly add `after:content-['']`.
Applied to files:
vite.config.mts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: test
- GitHub Check: setup
- GitHub Check: lint-and-format
- GitHub Check: collect
…-Org#7442) ## Summary Removes the user.css put at top of the index.html when building for cloud. On local, now compiles to this (pictured): <img width="1909" height="184" alt="image" src="https://github.com/user-attachments/assets/be03beea-35e9-47d6-a293-08f2971b04be" /> Formatted, that looks like: ```html <!doctype html> <html lang="en"> <head> <link rel="stylesheet" href="user.css"> <link rel="stylesheet" href="api/userdata/user.css"> <meta charset="UTF-8"> <title>ComfyUI</title> <meta name="viewport" content="width=device-width,initial-scale=1,user-scalable=no"> <link rel="stylesheet" href="materialdesignicons.min.css"/> <meta name="mobile-web-app-capable" content="yes"> <meta name="apple-mobile-web-app-status-bar-style" content="black"> <link rel="manifest" href="./assets/manifest-CebUEmtR.json"> <script type="module" crossorigin src="./assets/index-DuwpHar_.js"></script> <link rel="modulepreload" crossorigin href="./assets/vendor-other--dOoND1c.js"> <link rel="modulepreload" crossorigin href="./assets/vendor-primevue-BPXiTI_h.js"> <link rel="modulepreload" crossorigin href="./assets/vendor-vue-RrbnUvXR.js"> <link rel="modulepreload" crossorigin href="./assets/vendor-xterm-BZLod3g9.js"> <link rel="modulepreload" crossorigin href="./assets/vendor-three-aR6ntw5X.js"> <link rel="modulepreload" crossorigin href="./assets/vendor-tiptap-BVGjFCxT.js"> <link rel="stylesheet" crossorigin href="./assets/vendor-other-DODGPXtn.css"> <link rel="stylesheet" crossorigin href="./assets/vendor-xterm-BKlWQB97.css"> <link rel="stylesheet" crossorigin href="./assets/index-CX9dQXxD.css"> </head> <body class="litegraph grid"> <div id="vue-app"></div> </body> </html> ``` On cloud, this: <img width="1911" height="1106" alt="image" src="https://github.com/user-attachments/assets/bbf6046b-e2fd-4e02-bb71-cba27f579271" /> ## Context On the cloud distribution, there are currently 401 errors appearing in the console from requests attempting to load custom user stylesheets: - `https://cloud.comfy.org/user.css` (returns 200) - `https://cloud.comfy.org/api/userdata/user.css` (returns 401) This is a feature inherited from local ComfyUI that allows users to add custom stylesheets. The implementation naively requests the stylesheet from the server, and if the user has added one, it gets loaded; otherwise, the request fails. This PR removes the custom stylesheet loading from the cloud distribution by removing it from teh index.html and only re-injecting it on non-cloud builds. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7442-remove-user-css-on-cloud-to-prevent-failed-requests-on-startup-2c86d73d3650813d82a0deb3b01cee74) by [Unito](https://www.unito.io)
## Summary Removes the user.css put at top of the index.html when building for cloud. On local, now compiles to this (pictured): <img width="1909" height="184" alt="image" src="https://github.com/user-attachments/assets/be03beea-35e9-47d6-a293-08f2971b04be" /> Formatted, that looks like: ```html <!doctype html> <html lang="en"> <head> <link rel="stylesheet" href="user.css"> <link rel="stylesheet" href="api/userdata/user.css"> <meta charset="UTF-8"> <title>ComfyUI</title> <meta name="viewport" content="width=device-width,initial-scale=1,user-scalable=no"> <link rel="stylesheet" href="materialdesignicons.min.css"/> <meta name="mobile-web-app-capable" content="yes"> <meta name="apple-mobile-web-app-status-bar-style" content="black"> <link rel="manifest" href="./assets/manifest-CebUEmtR.json"> <script type="module" crossorigin src="./assets/index-DuwpHar_.js"></script> <link rel="modulepreload" crossorigin href="./assets/vendor-other--dOoND1c.js"> <link rel="modulepreload" crossorigin href="./assets/vendor-primevue-BPXiTI_h.js"> <link rel="modulepreload" crossorigin href="./assets/vendor-vue-RrbnUvXR.js"> <link rel="modulepreload" crossorigin href="./assets/vendor-xterm-BZLod3g9.js"> <link rel="modulepreload" crossorigin href="./assets/vendor-three-aR6ntw5X.js"> <link rel="modulepreload" crossorigin href="./assets/vendor-tiptap-BVGjFCxT.js"> <link rel="stylesheet" crossorigin href="./assets/vendor-other-DODGPXtn.css"> <link rel="stylesheet" crossorigin href="./assets/vendor-xterm-BKlWQB97.css"> <link rel="stylesheet" crossorigin href="./assets/index-CX9dQXxD.css"> </head> <body class="litegraph grid"> <div id="vue-app"></div> </body> </html> ``` On cloud, this: <img width="1911" height="1106" alt="image" src="https://github.com/user-attachments/assets/bbf6046b-e2fd-4e02-bb71-cba27f579271" /> ## Context On the cloud distribution, there are currently 401 errors appearing in the console from requests attempting to load custom user stylesheets: - `https://cloud.comfy.org/user.css` (returns 200) - `https://cloud.comfy.org/api/userdata/user.css` (returns 401) This is a feature inherited from local ComfyUI that allows users to add custom stylesheets. The implementation naively requests the stylesheet from the server, and if the user has added one, it gets loaded; otherwise, the request fails. This PR removes the custom stylesheet loading from the cloud distribution by removing it from teh index.html and only re-injecting it on non-cloud builds. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7442-remove-user-css-on-cloud-to-prevent-failed-requests-on-startup-2c86d73d3650813d82a0deb3b01cee74) by [Unito](https://www.unito.io)
Summary
Removes the user.css put at top of the index.html when building for cloud.
On local, now compiles to this (pictured):

Formatted, that looks like:
On cloud, this:
Context
On the cloud distribution, there are currently 401 errors appearing in the console from requests attempting to load custom user stylesheets:
https://cloud.comfy.org/user.css(returns 200)https://cloud.comfy.org/api/userdata/user.css(returns 401)This is a feature inherited from local ComfyUI that allows users to add custom stylesheets. The implementation naively requests the stylesheet from the server, and if the user has added one, it gets loaded; otherwise, the request fails.
This PR removes the custom stylesheet loading from the cloud distribution by removing it from teh index.html and only re-injecting it on non-cloud builds.
┆Issue is synchronized with this Notion page by Unito