[backport cloud/1.34] remove useless/misleading toast in topup dialog#7380
Merged
christian-byrne merged 1 commit intocloud/1.34from Dec 11, 2025
Merged
Conversation
Removes a toast that says "Purchase successful" when clicking the "Add credits" button -- that button just opens Stripe checkout in another tab, so the toast is misleading and could be wrong. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7375-fix-remove-useless-misleading-toast-in-topup-dialog-2c66d73d36508124bb65feaf7cf26712) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <action@github.com>
christian-byrne
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
dosubot
bot
added
the
size:S
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
christian-byrne
changed the title
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 12/11/2025, 03:34:11 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/11/2025, 03:17:10 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports the fix from main that removes the misleading "purchase successful" toast that appears immediately after clicking the buy button in the credit top-up dialog.
Details
useCoreCommands.tsby keeping cloud/1.34'sSubgraphNodeimportRelated
┆Issue is synchronized with this Notion page by Unito