Skip to content

cleanup: remove the legacy mask editor and all related code#7370

Merged
christian-byrne merged 2 commits intomainfrom
chore/remove-legacy-mask-editor
Dec 22, 2025
Merged

cleanup: remove the legacy mask editor and all related code#7370
christian-byrne merged 2 commits intomainfrom
chore/remove-legacy-mask-editor

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Dec 11, 2025

Summary

Removes the legacy mask editor. May also want to remove the "Beta" tags on all the current mask editor components/mentions in the app now as well.

Context

Telemetry data shows zero users using the legacy mask editor. It has been considerable time since we switched to the new one, and there really is no reason to use the legacy version given how lacking it is.

In #7332 (v1.35.2 - Dec 11, 2025), we added a final warning that the legacy mask editor is being removed.

On 1.36, this PR can be merged, as more than enough warning will have been given.

┆Issue is synchronized with this Notion page by Unito

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

📝 Walkthrough

Walkthrough

This PR removes the legacy mask editor implementation (maskEditorOld.ts) and eliminates the UseNewEditor setting that toggled between old and new editors, consolidating on the new mask editor as the sole implementation across the codebase.

Changes

Cohort / File(s) Summary
Deprecated references removal
CODEOWNERS, build/plugins/comfyAPIPlugin.ts
Removed ownership assignment and deprecated file entry for maskEditorOld.ts
Legacy mask editor removal
src/extensions/core/maskEditorOld.ts, src/extensions/core/maskeditor.ts
Deleted entire old mask editor module; refactored main editor to always delegate to new editor via useMaskEditor(), removed conditional branches and legacy deprecation warnings
Documentation
docs/extensions/core.md
Removed maskEditorOld.ts entry from core extensions documentation
Locale updates
src/locales/{ar,en,es,fr,ja,ko,ru,tr,zh,zh-TW}/main.json, src/locales/{ar,en,es,fr,ja,ko,ru,tr,zh,zh-TW}/settings.json
Removed NewEditor key from all main.json files and Comfy_MaskEditor_UseNewEditor entry from all settings.json files across 10 language locales
API schema
src/schemas/apiSchema.ts
Removed Comfy.MaskEditor.UseNewEditor boolean field from exported Settings type

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-legacy-mask-editor

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9514e5d and 47aa2d1.

📒 Files selected for processing (26)
  • CODEOWNERS
  • build/plugins/comfyAPIPlugin.ts
  • docs/extensions/core.md
  • src/extensions/core/maskEditorOld.ts
  • src/extensions/core/maskeditor.ts
  • src/locales/ar/main.json
  • src/locales/ar/settings.json
  • src/locales/en/main.json
  • src/locales/en/settings.json
  • src/locales/es/main.json
  • src/locales/es/settings.json
  • src/locales/fr/main.json
  • src/locales/fr/settings.json
  • src/locales/ja/main.json
  • src/locales/ja/settings.json
  • src/locales/ko/main.json
  • src/locales/ko/settings.json
  • src/locales/ru/main.json
  • src/locales/ru/settings.json
  • src/locales/tr/main.json
  • src/locales/tr/settings.json
  • src/locales/zh-TW/main.json
  • src/locales/zh-TW/settings.json
  • src/locales/zh/main.json
  • src/locales/zh/settings.json
  • src/schemas/apiSchema.ts
💤 Files with no reviewable changes (21)
  • src/locales/ru/settings.json
  • src/locales/zh-TW/main.json
  • src/locales/tr/main.json
  • src/locales/ar/settings.json
  • src/locales/es/main.json
  • src/locales/ja/settings.json
  • src/locales/ko/settings.json
  • src/locales/ko/main.json
  • src/locales/fr/settings.json
  • src/locales/tr/settings.json
  • src/locales/zh/main.json
  • src/locales/zh-TW/settings.json
  • src/locales/ru/main.json
  • src/locales/ar/main.json
  • src/locales/es/settings.json
  • src/locales/ja/main.json
  • CODEOWNERS
  • src/locales/zh/settings.json
  • src/locales/fr/main.json
  • src/extensions/core/maskEditorOld.ts
  • src/schemas/apiSchema.ts
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{ts,tsx,vue}: Use TypeScript exclusively; do not write new JavaScript code
Use sorted and grouped imports organized by plugin/source
Enforce ESLint rules including Vue + TypeScript rules, disallow floating promises, disallow unused imports, and restrict i18n raw text in templates
Do not use any type or as any type assertions; fix the underlying type issue instead
Write code that is expressive and self-documenting; avoid redundant comments and clean as you go
Keep functions short and functional; minimize nesting and follow the arrow anti-pattern
Avoid mutable state; prefer immutability and assignment at point of declaration
Use function declarations instead of function expressions when possible
Use es-toolkit for utility functions
Implement proper error handling in code

Files:

  • build/plugins/comfyAPIPlugin.ts
  • src/extensions/core/maskeditor.ts
**/*.{ts,tsx,vue,js,jsx,json,css}

📄 CodeRabbit inference engine (AGENTS.md)

Apply Prettier formatting with 2-space indentation, single quotes, no trailing semicolons, and 80-character line width

Files:

  • build/plugins/comfyAPIPlugin.ts
  • src/locales/en/main.json
  • src/extensions/core/maskeditor.ts
  • src/locales/en/settings.json
**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Minimize the surface area (exported values) of each module and composable

Files:

  • build/plugins/comfyAPIPlugin.ts
  • src/extensions/core/maskeditor.ts
src/**/*.{vue,ts}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json

Files:

  • src/extensions/core/maskeditor.ts
src/**/*.ts

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safety

Files:

  • src/extensions/core/maskeditor.ts
src/**/*.{ts,tsx,vue}

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase

Files:

  • src/extensions/core/maskeditor.ts
src/**/*.{vue,ts,tsx}

📄 CodeRabbit inference engine (src/CLAUDE.md)

Follow Vue 3 composition API style guide

Files:

  • src/extensions/core/maskeditor.ts
🧠 Learnings (6)
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Applied to files:

  • build/plugins/comfyAPIPlugin.ts
  • src/extensions/core/maskeditor.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Applied to files:

  • build/plugins/comfyAPIPlugin.ts
  • src/extensions/core/maskeditor.ts
📚 Learning: 2025-12-17T00:40:09.635Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Applied to files:

  • build/plugins/comfyAPIPlugin.ts
  • src/extensions/core/maskeditor.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Applied to files:

  • build/plugins/comfyAPIPlugin.ts
  • src/extensions/core/maskeditor.ts
📚 Learning: 2025-12-09T04:35:43.971Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/locales/en/main.json:774-780
Timestamp: 2025-12-09T04:35:43.971Z
Learning: In the Comfy-Org/ComfyUI_frontend repository, locale files other than `src/locales/en/main.json` are generated automatically on every release. Developers only need to add English (en) key/values in `src/locales/en/main.json` when making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews.

Applied to files:

  • src/locales/en/main.json
  • docs/extensions/core.md
  • src/locales/en/settings.json
📚 Learning: 2025-11-24T19:47:56.371Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/lib/litegraph/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:56.371Z
Learning: Applies to src/lib/litegraph/**/*.{test,spec}.{ts,tsx} : Use provided test helpers `createTestSubgraph` and `createTestSubgraphNode` from `./fixtures/subgraphHelpers` for consistent subgraph test setup

Applied to files:

  • docs/extensions/core.md
🧬 Code graph analysis (1)
src/extensions/core/maskeditor.ts (2)
src/composables/maskeditor/useMaskEditor.ts (1)
  • useMaskEditor (6-48)
src/stores/dialogStore.ts (1)
  • useDialogStore (80-265)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: setup
🔇 Additional comments (7)
docs/extensions/core.md (1)

180-180: LGTM! Documentation correctly updated.

The documentation now accurately reflects the removal of the legacy mask editor. The core extensions list is consistent with the codebase after removing maskEditorOld.ts.

src/locales/en/settings.json (1)

463-463: LGTM! Locale entry correctly removed.

The Comfy_MaskEditor_UseNewEditor setting has been properly removed from the English locale. Based on learnings, other locale files will be automatically updated on release.

src/locales/en/main.json (1)

2430-2430: LGTM! Settings category label removed.

The "NewEditor" category label has been correctly removed from the English locale, eliminating the distinction between old and new mask editors in the settings UI.

build/plugins/comfyAPIPlugin.ts (1)

12-12: LGTM! Deprecation entry correctly removed.

The maskEditorOld path has been properly removed from the DEPRECATED_FILES list, consistent with the file deletion. The build plugin will no longer emit deprecation warnings for this now-deleted module.

src/extensions/core/maskeditor.ts (3)

6-7: LGTM! Imports correctly added.

The new imports for useDialogStore and useMaskEditor are properly structured and necessary for the refactored implementation that delegates to the new mask editor.


9-21: LGTM! Excellent input validation added.

The refactored openMaskEditor function now includes robust validation that checks for node presence and verifies the node has images or image preview media before delegating to the new mask editor. The early returns and clear error messages improve error handling.


24-26: LGTM! Clean simplification of mask editor logic.

The isOpened() function is correctly simplified to check the dialog store for the 'global-mask-editor' key. The removal of the UseNewEditor setting and init hook completes the consolidation to a single mask editor implementation. The UseDominantAxis setting is preserved with its correct default value.

Also applies to: 53-53, 81-81


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@christian-byrne christian-byrne force-pushed the chore/remove-legacy-mask-editor branch from 062f8e9 to 8968beb Compare December 11, 2025 12:41
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 12/22/2025, 01:59:41 PM UTC

📈 Summary

  • Total Tests: 508
  • Passed: 497 ✅
  • Failed: 0
  • Flaky: 3 ⚠️
  • Skipped: 8 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 485 / ❌ 0 / ⚠️ 3 / ⏭️ 8
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 12/22/2025, 01:50:32 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Bundle Size Report

Summary

  • Raw size: 17.2 MB baseline 17.3 MB — 🟢 -38.5 kB
  • Gzip: 3.52 MB baseline 3.53 MB — 🟢 -7.57 kB
  • Brotli: 2.69 MB baseline 2.69 MB — 🟢 -5.54 kB
  • Bundles: 98 current • 98 baseline • 60 added / 60 removed

Category Glance
App Entry Points 🟢 -36.1 kB (3.19 MB) · Panels & Settings 🟢 -2.05 kB (295 kB) · Other 🟢 -307 B (3.44 MB) · Vendor & Third-Party ⚪ 0 B (9.1 MB) · Graph Workspace ⚪ 0 B (993 kB) · UI Components ⚪ 0 B (186 kB) · + 3 more

Per-category breakdown
App Entry Points — 3.19 MB (baseline 3.22 MB) • 🟢 -36.1 kB

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-DoZMDJ_N.js (removed) 2.99 MB 🟢 -2.99 MB 🟢 -631 kB 🟢 -480 kB
assets/index-B4_8aRms.js (new) 2.99 MB 🔴 +2.99 MB 🔴 +631 kB 🔴 +480 kB
assets/index-DyRAQ3ky.js (removed) 228 kB 🟢 -228 kB 🟢 -48.7 kB 🟢 -40 kB
assets/index-C6dEXiOM.js (new) 192 kB 🔴 +192 kB 🔴 +41.8 kB 🔴 +34.8 kB
assets/index-CU8g-uy3.js (removed) 345 B 🟢 -345 B 🟢 -246 B 🟢 -235 B
assets/index-kHsJdRFX.js (new) 345 B 🔴 +345 B 🔴 +245 B 🔴 +211 B

Status: 3 added / 3 removed

Graph Workspace — 993 kB (baseline 993 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-3g5kzexO.js (new) 993 kB 🔴 +993 kB 🔴 +194 kB 🔴 +148 kB
assets/GraphView-BX1X9mI-.js (removed) 993 kB 🟢 -993 kB 🟢 -194 kB 🟢 -148 kB

Status: 1 added / 1 removed

Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/UserSelectView-BXX0quQh.js (new) 6.54 kB 🔴 +6.54 kB 🔴 +2.14 kB 🔴 +1.9 kB
assets/UserSelectView-DR8-hHpb.js (removed) 6.54 kB 🟢 -6.54 kB 🟢 -2.14 kB 🟢 -1.9 kB

Status: 1 added / 1 removed

Panels & Settings — 295 kB (baseline 297 kB) • 🟢 -2.05 kB

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/settings-BvFz-TmQ.js (removed) 33.1 kB 🟢 -33.1 kB 🟢 -7.68 kB 🟢 -6.47 kB
assets/settings-CjlRFMdL.js (new) 32.8 kB 🔴 +32.8 kB 🔴 +7.65 kB 🔴 +6.43 kB
assets/settings-C6bMjAne.js (removed) 27.1 kB 🟢 -27.1 kB 🟢 -6.53 kB 🟢 -5.46 kB
assets/settings-DkGwvylK.js (new) 26.9 kB 🔴 +26.9 kB 🔴 +6.5 kB 🔴 +5.43 kB
assets/settings-DamkILzl.js (removed) 26.4 kB 🟢 -26.4 kB 🟢 -6.96 kB 🟢 -6.02 kB
assets/settings-BIdKi-OT.js (new) 26.2 kB 🔴 +26.2 kB 🔴 +6.92 kB 🔴 +5.97 kB
assets/settings-CsnOn8G0.js (removed) 25.7 kB 🟢 -25.7 kB 🟢 -6.6 kB 🟢 -5.94 kB
assets/settings-ByL6gy5c.js (new) 25.4 kB 🔴 +25.4 kB 🔴 +6.56 kB 🔴 +5.91 kB
assets/settings-D7k3huHm.js (removed) 25 kB 🟢 -25 kB 🟢 -6.51 kB 🟢 -5.87 kB
assets/settings-D5BGNZ7M.js (removed) 24.8 kB 🟢 -24.8 kB 🟢 -6.36 kB 🟢 -5.59 kB
assets/settings-Dyd027Dx.js (new) 24.7 kB 🔴 +24.7 kB 🔴 +6.47 kB 🔴 +5.83 kB
assets/settings-Bu3OR-lX.js (new) 24.6 kB 🔴 +24.6 kB 🔴 +6.32 kB 🔴 +5.55 kB
assets/settings-C7Yhp7H7.js (removed) 24 kB 🟢 -24 kB 🟢 -6.61 kB 🟢 -5.67 kB
assets/settings-xx2Yb6R2.js (new) 23.8 kB 🔴 +23.8 kB 🔴 +6.56 kB 🔴 +5.63 kB
assets/settings-BxYnTA2y.js (removed) 21.5 kB 🟢 -21.5 kB 🟢 -6.49 kB 🟢 -5.35 kB
assets/LegacyCreditsPanel-BaETRbFT.js (new) 21.4 kB 🔴 +21.4 kB 🔴 +5.16 kB 🔴 +4.51 kB
assets/LegacyCreditsPanel-C9HKNpA9.js (removed) 21.4 kB 🟢 -21.4 kB 🟢 -5.16 kB 🟢 -4.51 kB
assets/settings-wwBxqLH5.js (new) 21.3 kB 🔴 +21.3 kB 🔴 +6.46 kB 🔴 +5.35 kB
assets/settings-s1k0gw1Y.js (removed) 20.9 kB 🟢 -20.9 kB 🟢 -6.29 kB 🟢 -5.02 kB
assets/settings-CA43q0kf.js (new) 20.7 kB 🔴 +20.7 kB 🔴 +6.25 kB 🔴 +5 kB
assets/KeybindingPanel-BtCIX6Nq.js (removed) 13.6 kB 🟢 -13.6 kB 🟢 -3.42 kB 🟢 -3.02 kB
assets/KeybindingPanel-ClkNr-UV.js (new) 13.6 kB 🔴 +13.6 kB 🔴 +3.42 kB 🔴 +3.01 kB
assets/ExtensionPanel-99hvmdBQ.js (removed) 10.8 kB 🟢 -10.8 kB 🟢 -2.57 kB 🟢 -2.25 kB
assets/ExtensionPanel-BkhdsUrt.js (new) 10.8 kB 🔴 +10.8 kB 🔴 +2.57 kB 🔴 +2.25 kB
assets/AboutPanel-BR4fKEPw.js (new) 9.16 kB 🔴 +9.16 kB 🔴 +2.46 kB 🔴 +2.21 kB
assets/AboutPanel-GczHveHQ.js (removed) 9.16 kB 🟢 -9.16 kB 🟢 -2.46 kB 🟢 -2.21 kB
assets/ServerConfigPanel-b1q_yPna.js (removed) 7.07 kB 🟢 -7.07 kB 🟢 -1.98 kB 🟢 -1.76 kB
assets/ServerConfigPanel-rBmNraNB.js (new) 7.07 kB 🔴 +7.07 kB 🔴 +1.98 kB 🔴 +1.76 kB
assets/UserPanel-D8mKfIC3.js (removed) 6.23 kB 🟢 -6.23 kB 🟢 -1.72 kB 🟢 -1.5 kB
assets/UserPanel-WxwC41ch.js (new) 6.23 kB 🔴 +6.23 kB 🔴 +1.72 kB 🔴 +1.5 kB
assets/settings-BhbWhsRg.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 15 added / 15 removed

UI Components — 186 kB (baseline 186 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/Load3D.vue_vue_type_script_setup_true_lang-C1BTtMfa.js (removed) 54.3 kB 🟢 -54.3 kB 🟢 -8.62 kB 🟢 -7.41 kB
assets/Load3D.vue_vue_type_script_setup_true_lang-D_ylRMe9.js (new) 54.3 kB 🔴 +54.3 kB 🔴 +8.62 kB 🔴 +7.42 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-DjxoS5Ai.js (new) 50 kB 🔴 +50 kB 🔴 +11 kB 🔴 +9.63 kB
assets/LazyImage.vue_vue_type_script_setup_true_lang-WMc7yst9.js (removed) 50 kB 🟢 -50 kB 🟢 -11 kB 🟢 -9.63 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-BxMQjiUv.js (new) 48.8 kB 🔴 +48.8 kB 🔴 +10.5 kB 🔴 +9.12 kB
assets/WidgetSelect.vue_vue_type_script_setup_true_lang-CkK-QiJS.js (removed) 48.8 kB 🟢 -48.8 kB 🟢 -10.5 kB 🟢 -9.14 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-AiFyIX8G.js (removed) 14.3 kB 🟢 -14.3 kB 🟢 -3.74 kB 🟢 -3.31 kB
assets/WidgetInputNumber.vue_vue_type_script_setup_true_lang-CC5eMrUE.js (new) 14.3 kB 🔴 +14.3 kB 🔴 +3.73 kB 🔴 +3.29 kB
assets/ComfyQueueButton-BFXA4LCL.js (removed) 8.45 kB 🟢 -8.45 kB 🟢 -2.47 kB 🟢 -2.2 kB
assets/ComfyQueueButton-Gy09KBBI.js (new) 8.45 kB 🔴 +8.45 kB 🔴 +2.47 kB 🔴 +2.2 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-C3v8dSGX.js (new) 3.68 kB 🔴 +3.68 kB 🔴 +1.45 kB 🔴 +1.31 kB
assets/WidgetWithControl.vue_vue_type_script_setup_true_lang-CdzrR1PB.js (removed) 3.68 kB 🟢 -3.68 kB 🟢 -1.45 kB 🟢 -1.31 kB
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-BgaYDZ6T.js (removed) 2.14 kB 🟢 -2.14 kB 🟢 -890 B 🟢 -771 B
assets/WidgetLayoutField.vue_vue_type_script_setup_true_lang-BPejpeZ8.js (new) 2.14 kB 🔴 +2.14 kB 🔴 +888 B 🔴 +768 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-3ZhOGtRU.js (removed) 897 B 🟢 -897 B 🟢 -503 B 🟢 -474 B
assets/MediaTitle.vue_vue_type_script_setup_true_lang-WE7gKrzh.js (new) 897 B 🔴 +897 B 🔴 +502 B 🔴 +464 B
assets/UserAvatar.vue_vue_type_script_setup_true_lang-DymEwRe0.js 1.34 kB 1.34 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetButton-U5ly29Pt.js 2.04 kB 2.04 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 8 added / 8 removed

Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/keybindingService-CW7xY5es.js (removed) 7.51 kB 🟢 -7.51 kB 🟢 -1.83 kB 🟢 -1.58 kB
assets/keybindingService-SY8FxrrP.js (new) 7.51 kB 🔴 +7.51 kB 🔴 +1.83 kB 🔴 +1.57 kB
assets/audioService-BSCP_os0.js (new) 2.2 kB 🔴 +2.2 kB 🔴 +960 B 🔴 +826 B
assets/audioService-CNfnXbw1.js (removed) 2.2 kB 🟢 -2.2 kB 🟢 -962 B 🟢 -826 B
assets/serverConfigStore-7JI8VFS2.js 2.83 kB 2.83 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 2 added / 2 removed

Utilities & Hooks — 1.41 kB (baseline 1.41 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/audioUtils-CAmVNaVC.js (new) 1.41 kB 🔴 +1.41 kB 🔴 +651 B 🔴 +545 B
assets/audioUtils-CZ0skduL.js (removed) 1.41 kB 🟢 -1.41 kB 🟢 -651 B 🟢 -548 B

Status: 1 added / 1 removed

Vendor & Third-Party — 9.1 MB (baseline 9.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-chart-DaR9dw3X.js 452 kB 452 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-other-Cf7iqkoX.js 3.86 MB 3.86 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-primevue-BIgr9yoj.js 1.96 MB 1.96 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-three-DYL0ZbEr.js 2.02 MB 2.02 MB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-tiptap-C1NB2Q_L.js 232 kB 232 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-vue-DSfeuQOV.js 160 kB 160 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/vendor-xterm-BF8peZ5_.js 420 kB 420 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
Other — 3.44 MB (baseline 3.44 MB) • 🟢 -307 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-CI9qb0E5.js (removed) 112 kB 🟢 -112 kB 🟢 -30.4 kB 🟢 -24.6 kB
assets/main-OzGsrlqJ.js (new) 112 kB 🔴 +112 kB 🔴 +30.3 kB 🔴 +24.6 kB
assets/main-CgJ6zvJL.js (removed) 97.2 kB 🟢 -97.2 kB 🟢 -27 kB 🟢 -22.2 kB
assets/main-Bdc58rJq.js (new) 97.1 kB 🔴 +97.1 kB 🔴 +27 kB 🔴 +22.2 kB
assets/main-Dm19QY4N.js (removed) 92.2 kB 🟢 -92.2 kB 🟢 -27.1 kB 🟢 -22.3 kB
assets/main-DLHyaEcz.js (new) 92.1 kB 🔴 +92.1 kB 🔴 +27 kB 🔴 +22.3 kB
assets/main-BtXVDFw6.js (removed) 84.7 kB 🟢 -84.7 kB 🟢 -26 kB 🟢 -22.5 kB
assets/main-CAL83XT3.js (new) 84.6 kB 🔴 +84.6 kB 🔴 +26 kB 🔴 +22.5 kB
assets/main-Buv6RhU4.js (removed) 82.4 kB 🟢 -82.4 kB 🟢 -26.1 kB 🟢 -21.7 kB
assets/main-CHLLfvpG.js (new) 82.4 kB 🔴 +82.4 kB 🔴 +26.1 kB 🔴 +21.7 kB
assets/main-Cu4LqtW0.js (removed) 81.6 kB 🟢 -81.6 kB 🟢 -25.6 kB 🟢 -21.8 kB
assets/main-C9ZJBRdI.js (new) 81.5 kB 🔴 +81.5 kB 🔴 +25.6 kB 🔴 +21.7 kB
assets/main-BDhxs-bB.js (removed) 79.9 kB 🟢 -79.9 kB 🟢 -25.6 kB 🟢 -22.1 kB
assets/main-O7KfJeMO.js (new) 79.9 kB 🔴 +79.9 kB 🔴 +25.6 kB 🔴 +22.1 kB
assets/main-Tihe0h_r.js (removed) 71.3 kB 🟢 -71.3 kB 🟢 -25.2 kB 🟢 -20.8 kB
assets/main-DDqR5EuX.js (new) 71.3 kB 🔴 +71.3 kB 🔴 +25.2 kB 🔴 +20.8 kB
assets/main-wPWMutMw.js (removed) 70.4 kB 🟢 -70.4 kB 🟢 -25.2 kB 🟢 -20.4 kB
assets/main-CJOg9JF6.js (new) 70.3 kB 🔴 +70.3 kB 🔴 +25.2 kB 🔴 +20.4 kB
assets/SubscriptionRequiredDialogContent-B14KC9Ck.js (removed) 28 kB 🟢 -28 kB 🟢 -6.27 kB 🟢 -5.44 kB
assets/SubscriptionRequiredDialogContent-DOLVIpc6.js (new) 28 kB 🔴 +28 kB 🔴 +6.27 kB 🔴 +5.44 kB
assets/WidgetRecordAudio-KsD2IT6R.js (removed) 20.4 kB 🟢 -20.4 kB 🟢 -5.24 kB 🟢 -4.64 kB
assets/WidgetRecordAudio-zrAuPvk3.js (new) 20.4 kB 🔴 +20.4 kB 🔴 +5.23 kB 🔴 +4.63 kB
assets/AudioPreviewPlayer-CEeynxgp.js (new) 13.3 kB 🔴 +13.3 kB 🔴 +3.35 kB 🔴 +2.99 kB
assets/AudioPreviewPlayer-CUGeVYyB.js (removed) 13.3 kB 🟢 -13.3 kB 🟢 -3.35 kB 🟢 -2.99 kB
assets/ValueControlPopover-DA4Q3UDV.js (removed) 5.49 kB 🟢 -5.49 kB 🟢 -1.7 kB 🟢 -1.51 kB
assets/ValueControlPopover-DLkgdMHB.js (new) 5.49 kB 🔴 +5.49 kB 🔴 +1.71 kB 🔴 +1.52 kB
assets/WidgetGalleria-DBzpcyOl.js (removed) 4.1 kB 🟢 -4.1 kB 🟢 -1.45 kB 🟢 -1.31 kB
assets/WidgetGalleria-UpWh6TiS.js (new) 4.1 kB 🔴 +4.1 kB 🔴 +1.45 kB 🔴 +1.3 kB
assets/WidgetColorPicker-BJ1IVosT.js (removed) 3.41 kB 🟢 -3.41 kB 🟢 -1.38 kB 🟢 -1.23 kB
assets/WidgetColorPicker-CyeUVNZx.js (new) 3.41 kB 🔴 +3.41 kB 🔴 +1.38 kB 🔴 +1.23 kB
assets/WidgetTextarea-D_m5UzrE.js (removed) 3.08 kB 🟢 -3.08 kB 🟢 -1.21 kB 🟢 -1.08 kB
assets/WidgetTextarea-DP2casvs.js (new) 3.08 kB 🔴 +3.08 kB 🔴 +1.21 kB 🔴 +1.08 kB
assets/WidgetMarkdown-BtJjBZw0.js (new) 3.08 kB 🔴 +3.08 kB 🔴 +1.28 kB 🔴 +1.13 kB
assets/WidgetMarkdown-CEhaAc4Y.js (removed) 3.08 kB 🟢 -3.08 kB 🟢 -1.28 kB 🟢 -1.13 kB
assets/WidgetAudioUI-B8mONoiv.js (new) 2.89 kB 🔴 +2.89 kB 🔴 +1.16 kB 🔴 +1.06 kB
assets/WidgetAudioUI-KGaYE7ao.js (removed) 2.89 kB 🟢 -2.89 kB 🟢 -1.17 kB 🟢 -1.06 kB
assets/WidgetInputText-DjssFluh.js (new) 1.99 kB 🔴 +1.99 kB 🔴 +918 B 🔴 +852 B
assets/WidgetInputText-DYu_pBfR.js (removed) 1.99 kB 🟢 -1.99 kB 🟢 -920 B 🟢 -848 B
assets/WidgetToggleSwitch-B26iwt1N.js (removed) 1.76 kB 🟢 -1.76 kB 🟢 -832 B 🟢 -735 B
assets/WidgetToggleSwitch-Hob6cR_X.js (new) 1.76 kB 🔴 +1.76 kB 🔴 +831 B 🔴 +729 B
assets/MediaImageBottom-CrRTALre.js (removed) 1.55 kB 🟢 -1.55 kB 🟢 -732 B 🟢 -638 B
assets/MediaImageBottom-Cw4eNFxn.js (new) 1.55 kB 🔴 +1.55 kB 🔴 +731 B 🔴 +637 B
assets/MediaAudioBottom-BGZMt7in.js (new) 1.51 kB 🔴 +1.51 kB 🔴 +731 B 🔴 +645 B
assets/MediaAudioBottom-vU1NHTt7.js (removed) 1.51 kB 🟢 -1.51 kB 🟢 -733 B 🟢 -647 B
assets/Media3DBottom-C31jev2Y.js (new) 1.5 kB 🔴 +1.5 kB 🔴 +730 B 🔴 +645 B
assets/Media3DBottom-DILp91sM.js (removed) 1.5 kB 🟢 -1.5 kB 🟢 -731 B 🟢 -644 B
assets/MediaVideoBottom-B1wxn9pM.js (removed) 1.5 kB 🟢 -1.5 kB 🟢 -732 B 🟢 -643 B
assets/MediaVideoBottom-BnaagiEx.js (new) 1.5 kB 🔴 +1.5 kB 🔴 +729 B 🔴 +645 B
assets/Media3DTop-CJNb7cq8.js (new) 1.49 kB 🔴 +1.49 kB 🔴 +768 B 🔴 +652 B
assets/Media3DTop-h10O8qUn.js (removed) 1.49 kB 🟢 -1.49 kB 🟢 -767 B 🟢 -652 B
assets/WidgetSelect-D0jfgdSK.js (removed) 733 B 🟢 -733 B 🟢 -363 B 🟢 -327 B
assets/WidgetSelect-DkVuoe0a.js (new) 733 B 🔴 +733 B 🔴 +361 B 🔴 +321 B
assets/WidgetInputNumber-BQCNvTL5.js (new) 673 B 🔴 +673 B 🔴 +347 B 🔴 +291 B
assets/WidgetInputNumber-DvndGxsw.js (removed) 673 B 🟢 -673 B 🟢 -350 B 🟢 -291 B
assets/Load3D-B5Sw66jn.js (new) 424 B 🔴 +424 B 🔴 +268 B 🔴 +222 B
assets/Load3D-Br9LoxAc.js (removed) 424 B 🟢 -424 B 🟢 -267 B 🟢 -224 B
assets/WidgetLegacy-BPbBAFmz.js (new) 364 B 🔴 +364 B 🔴 +239 B 🔴 +194 B
assets/WidgetLegacy-j3847_Pm.js (removed) 364 B 🟢 -364 B 🟢 -238 B 🟢 -195 B
assets/commands-BWp4HdfU.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CcfGaui5.js 14.4 kB 14.4 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CisfgZf5.js 13.7 kB 13.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CkU12Foh.js 13 kB 13 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-CoH2DJa6.js 14.2 kB 14.2 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-COSt-Bjx.js 14.9 kB 14.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DalfIW5f.js 15.9 kB 15.9 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DfTl0eCm.js 13.5 kB 13.5 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-DwSJL865.js 13.7 kB 13.7 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/commands-Zxyx15Vd.js 12.8 kB 12.8 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/main-Cw9RZWRY.js 89 B 89 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaAudioTop-Dr0afgCA.js 1.46 kB 1.46 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaImageTop-BXa-oKEc.js 1.75 kB 1.75 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/MediaVideoTop-BVdg2b8C.js 2.65 kB 2.65 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-1Vh3MCrN.js 240 kB 240 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-aW9En70v.js 260 kB 260 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BIckSVgU.js 273 kB 273 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-BiYpVi7D.js 263 kB 263 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Bw_Jitw_.js 101 B 101 B ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CCEXtYfM.js 243 kB 243 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-CvmVDWYd.js 323 kB 323 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-D_wreoPJ.js 267 kB 267 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-Dz-0ZIBN.js 297 kB 297 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/nodeDefs-VZsNmhG7.js 264 kB 264 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetChart-BU__hen8.js 2.48 kB 2.48 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/WidgetImageCompare-0zJeINY-.js 2.21 kB 2.21 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B
assets/widgetPropFilter-BIbGSUAt.js 1.28 kB 1.28 kB ⚪ 0 B ⚪ 0 B ⚪ 0 B

Status: 29 added / 29 removed

@christian-byrne christian-byrne marked this pull request as ready for review December 22, 2025 13:48
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Dec 22, 2025
@christian-byrne christian-byrne force-pushed the chore/remove-legacy-mask-editor branch from 8968beb to 47aa2d1 Compare December 22, 2025 13:49
@christian-byrne
Copy link
Contributor Author

We added the warning for users a few releases ago, and ensured from telemetry data on cloud that no one opts into using the legacy version.

For devs, we added the deprecation warning a couple months ago and as of today there is 0 usage from custom nodes per source graph.

This should be good to merge now (on 1.36, as promised).

@christian-byrne christian-byrne merged commit 0762985 into main Dec 22, 2025
28 checks passed
@christian-byrne christian-byrne deleted the chore/remove-legacy-mask-editor branch December 22, 2025 14:17
Yourz pushed a commit that referenced this pull request Dec 24, 2025
## Summary

Removes the legacy mask editor. May also want to remove the "Beta" tags
on all the current mask editor components/mentions in the app now as
well.

## Context

Telemetry data shows zero users using the legacy mask editor. It has
been considerable time since we switched to the new one, and there
really is no reason to use the legacy version given how lacking it is.

In #7332 (v1.35.2 -
Dec 11, 2025), we added a final warning that the legacy mask editor is
being removed.

On 1.36, this PR can be merged, as more than enough warning will have
been given.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7370-cleanup-remove-the-legacy-mask-editor-and-all-related-code-2c66d73d365081d58fbed0f3c84bcb0d)
by [Unito](https://www.unito.io)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:mask-editor size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant