-
Notifications
You must be signed in to change notification settings - Fork 490
feat: update subscription panel with tier-based design and improved UX #7307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b0856d3
feat: update subscription panel with tier-based design and improved UX
christian-byrne bd66008
fix: use i18n for tier benefits labels and update tests for new credi…
christian-byrne 046a1bc
fix: update credit card typography to use text-sm for consistency
christian-byrne 2130d26
Update src/platform/cloud/subscription/components/SubscriptionPanel.vue
christian-byrne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
...s/dialog/content/setting/CreditsPanel.vue → ...og/content/setting/LegacyCreditsPanel.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 6 additions & 29 deletions
35
src/platform/cloud/subscription/components/SubscriptionBenefits.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,19 @@ | ||
| <template> | ||
| <div class="flex flex-col items-start gap-1 self-stretch"> | ||
| <div class="flex items-start gap-2"> | ||
| <i class="pi pi-check mt-1 text-xs text-text-primary" /> | ||
| <div class="flex flex-col items-start gap-0 self-stretch"> | ||
| <div class="flex items-center gap-2 py-2"> | ||
| <i class="pi pi-check text-xs text-text-primary" /> | ||
| <span class="text-sm text-text-primary"> | ||
| {{ $t('subscription.benefits.benefit1') }} | ||
| </span> | ||
| </div> | ||
|
|
||
| <div class="flex items-start gap-2"> | ||
| <i class="pi pi-check mt-1 text-xs text-text-primary" /> | ||
| <div class="flex items-center gap-2 py-2"> | ||
| <i class="pi pi-check text-xs text-text-primary" /> | ||
| <span class="text-sm text-text-primary"> | ||
| {{ $t('subscription.benefits.benefit2') }} | ||
| </span> | ||
| </div> | ||
|
|
||
| <Button | ||
| :label="$t('subscription.viewMoreDetails')" | ||
| text | ||
| icon="pi pi-external-link" | ||
| icon-pos="left" | ||
| class="flex h-8 min-h-6 py-2 px-0 items-center gap-2 rounded text-text-secondary" | ||
| :pt="{ | ||
| icon: { | ||
| class: 'text-xs text-text-secondary' | ||
| }, | ||
| label: { | ||
| class: 'text-sm text-text-secondary' | ||
| } | ||
| }" | ||
| @click="handleViewMoreDetails" | ||
| /> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import Button from 'primevue/button' | ||
|
|
||
| const handleViewMoreDetails = () => { | ||
| window.open('https://www.comfy.org/cloud/pricing', '_blank') | ||
| } | ||
| </script> | ||
| <script setup lang="ts"></script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels implied by the filename, but sure 🤷🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but this code will be removed in a few weeks.