-
Notifications
You must be signed in to change notification settings - Fork 492
[backport core/1.34] Move cancel button into actionbar (#7297) #7298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
## Summary Move the interrupt control into the actionbar so cancellation sits with the run controls. ## Changes - add a cancel button to the actionbar with the existing interrupt tooltip and disabled state - remove the cancel button and related execution wiring from the top menu section to avoid duplication ## Review Focus - spacing/hover states of the new cancel control in both docked and floating modes ## Screenshots (if applicable) - n/a Tests: pnpm typecheck; pnpm lint:fix ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7297-Move-cancel-button-into-actionbar-2c46d73d36508198b00cf011390289f6) by [Unito](https://www.unito.io)
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/09/2025, 11:35:17 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 12/10/2025, 12:26:38 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR is a backport from core/1.34 that relocates the interrupt/cancel button from the top menu section into the actionbar alongside the run controls for better UI organization.
- Moves the cancel button from
TopMenuSection.vuetoComfyActionbar.vue - Removes duplicate code and unused imports from
TopMenuSection.vue - Adjusts spacing (margin-right to margin-left) to fit the new layout context
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/actionbar/ComfyActionbar.vue | Adds the cancel button with associated logic, imports, and styling to the actionbar |
| src/components/TopMenuSection.vue | Removes the cancel button and cleans up unused imports and functions |
|
Updating Playwright Expectations |
Summary
Backport of 2903560 to core/1.34 to place the cancel control alongside the run controls.
Changes
Review Focus
Check spacing/hover states of the new cancel control in docked vs floating layouts.
Screenshots (if applicable)
┆Issue is synchronized with this Notion page by Unito