Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore context menu for new searchbox #724

Merged
merged 7 commits into from
Sep 3, 2024
Merged

Restore context menu for new searchbox #724

merged 7 commits into from
Sep 3, 2024

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Sep 3, 2024

This PR adds 2 new settings to manage the link release behavior:
image

The Comfy.NodeSearchBoxImpl.LinkReleaseTrigger setting is deprecated.

Now even you enable the new searchbox, the context menu can still be used, and click the search button in the context menu will bring up the corresponding searchbox based on NodeSearchboxImpl setting.

contextMenu.mp4

Copy link

socket-security bot commented Sep 3, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@comfyorg/[email protected] network 0 2.56 MB k1oride

🚮 Removed packages: npm/@comfyorg/[email protected])

View full report↗︎

@huchenlei huchenlei added the New Browser Test Expectations New browser test screenshot should be set by github action label Sep 3, 2024
@huchenlei huchenlei merged commit 36cdebc into main Sep 3, 2024
2 checks passed
@huchenlei huchenlei deleted the searchbox branch September 3, 2024 17:28
@nux1111
Copy link

nux1111 commented Sep 6, 2024

I don't have the searchbox in my options again
CleanShot 2024-09-06 at 13 47 03@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Browser Test Expectations New browser test screenshot should be set by github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants