-
Notifications
You must be signed in to change notification settings - Fork 461
Fix issue No#7155: Nodes 2.0: Load Audio node is broken #7175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix: fail to load audio node
📝 WalkthroughWalkthroughThe WidgetAudioUI.vue component was restructured from a simple stacked layout to a grid-based layout. The container now uses a grid with specific column sizing and padding, with both WidgetSelect and AudioPreviewPlayer elements spanning the full width. No functional or data flow changes were made. Changes
Possibly related PRs
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (12)**/*.vue📄 CodeRabbit inference engine (.cursorrules)
|
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 12/05/2025, 02:56:05 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.2 MB (baseline 3.2 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 974 kB (baseline 974 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 173 kB (baseline 173 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.81 MB (baseline 3.81 MB) • 🔴 +33 BBundles that do not match a named category
Status: 17 added / 17 removed |
Myestery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks for your contribution
### Fix: Fail to load audio node ## Summary When using Modern Node Design (Nodes 2.0), the Load Audio node is able to work as expected. #7155 ## Changes Aligned `Load Audio` node appearance with the `Load Image` (/src/renderer/extensions/vueNodes/components/NodeWidgets.vue) node for consistency. ## Screenshots <img width="674" height="464" alt="zzzzw" src="https://github.com/user-attachments/assets/a7bf6a81-00e3-41a8-962b-560e7acb5c41" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7175-Fix-issue-No-7155-Nodes-2-0-Load-Audio-node-is-broken-2c06d73d365081ae9ab3c2ea20f061a4) by [Unito](https://www.unito.io)
|
@kaili-yang Successfully backported to #7261 |
… broken (#7261) Backport of #7175 to `core/1.33` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7261-backport-core-1-33-Fix-issue-No-7155-Nodes-2-0-Load-Audio-node-is-broken-2c46d73d36508149b7d4eeddbc05919f) by [Unito](https://www.unito.io) Co-authored-by: Kelly Yang <[email protected]>
### Fix: Fail to load audio node ## Summary When using Modern Node Design (Nodes 2.0), the Load Audio node is able to work as expected. #7155 ## Changes Aligned `Load Audio` node appearance with the `Load Image` (/src/renderer/extensions/vueNodes/components/NodeWidgets.vue) node for consistency. ## Screenshots <img width="674" height="464" alt="zzzzw" src="https://github.com/user-attachments/assets/a7bf6a81-00e3-41a8-962b-560e7acb5c41" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-7175-Fix-issue-No-7155-Nodes-2-0-Load-Audio-node-is-broken-2c06d73d365081ae9ab3c2ea20f061a4) by [Unito](https://www.unito.io)

Fix: Fail to load audio node
Summary
When using Modern Node Design (Nodes 2.0), the Load Audio node is able to work as expected.
#7155
Changes
Aligned
Load Audionode appearance with theLoad Image(/src/renderer/extensions/vueNodes/components/NodeWidgets.vue) node for consistency.Screenshots
┆Issue is synchronized with this Notion page by Unito