Skip to content

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Dec 3, 2025

Backport of #7100 to cloud/1.33

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

)

Increases the `/features` endpoint polling interval (runtime config
polling) from the current 30 seconds to 10 minutes.

## Background

The polling was originally added for two main purposes:

1. Server alert badges
2. Extra assurance that states are synchronized between frontend and
backend

However, both of these use cases are not critical:

- Server alert badges are unlikely to be needed in practice. WebSocket
(WS) can be used eventually as an alternative
- For synchronization, the system should be redesigned to be explicit
about marking client state as stale, or use WebSocket/Server-Sent Events
(WS/SSE) on a per-data basis rather than polling for the entire feature
flag set

## Motivation

The reason to reduce polling frequency is that per-user feature flags
are being added, which will make `/features` endpoint handling
significantly heavier. The endpoint will no longer just return static
JSON with high cache age, making frequent polling more costly.

## Future Considerations

- Eventually migrate server alert badges to use WebSocket
- Design a system that explicitly marks client state as stale when
needed
- Consider using WebSocket or Server-Sent Events for targeted data
updates instead of polling entire feature flag set

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7100-cloud-increase-feature-flag-polling-interval-to-10min-from-30s-2bd6d73d365081dfa8abeec901d0d975)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Alexander Brown <[email protected]>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Dec 3, 2025
@comfy-pr-bot comfy-pr-bot requested a review from a team as a code owner December 3, 2025 01:03
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 12/03/2025, 01:05:20 AM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 12/03/2025, 01:23:33 AM UTC

📈 Summary

  • Total Tests: 311
  • Passed: 114 ✅
  • Failed: 179 ❌
  • Flaky: 9 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser


🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne
Copy link
Contributor

christian-byrne commented Dec 3, 2025

Tests failing due to version compat toast warning. Will be fixed on future versions when backporting.

@christian-byrne christian-byrne merged commit 6c34085 into cloud/1.33 Dec 3, 2025
22 of 33 checks passed
@christian-byrne christian-byrne deleted the backport-7100-to-cloud-1.33 branch December 3, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants