Skip to content

[backport core/1.32] fix: add filter for combo widgets #7001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christian-byrne merged 2 commits into from
Nov 27, 2025
Merged

[backport core/1.32] fix: add filter for combo widgets #7001

christian-byrne merged 2 commits into from
Nov 27, 2025

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Nov 27, 2025 •
edited by sync-by-unito bot
Loading

Backport of #6999 to core/1.32

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

@Myestery @github-actions
fix: add filter for combo widgets (#6999)
dc37d90 
This pull request introduces a minor enhancement to the
`WidgetSelectDefault.vue` component. The change conditionally enables
the filtering feature in the select dropdown when there are more than
four options, improving usability for larger lists.


<img width="932" height="622" alt="Screenshot 2025-11-27 160239"
src="https://github.com/user-attachments/assets/76f6080f-13c7-4fa9-a813-2799af15363e"
/>

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6999-fix-add-filter-for-combo-widgets-2b86d73d365081f994e5caf78e64a196)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Nov 27, 2025
@comfy-pr-bot comfy-pr-bot mentioned this pull request Nov 27, 2025
Merged
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 27, 2025
@github-actions
Copy link

github-actions bot commented Nov 27, 2025 •
edited
Loading

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 11/27/2025, 08:22:41 PM UTC

📈 Summary

  • Total Tests: 478
  • Passed: 428 ✅
  • Failed: 16 ❌
  • Flaky: 4 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 419 / ❌ 16 / ⚠️ 4 / ⏭️ 30
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne added the New Browser Test Expectations New browser test screenshot should be set by github action label Nov 27, 2025
@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Updating Playwright Expectations

@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Nov 27, 2025
@christian-byrne christian-byrne merged commit de7d7f5 into core/1.32 Nov 27, 2025
3 checks passed
@christian-byrne christian-byrne deleted the backport-6999-to-core-1.32 branch November 27, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-byrne christian-byrne christian-byrne approved these changes

Assignees

No one assigned

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@comfy-pr-bot @christian-byrne @Myestery