Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Nov 27, 2025

Summary

Backport of #6950 onto core/1.32.

  • cherry-picked 4b87b1f
  • resolved conflicts by taking the upstream PNG expectations and removing LOD bits from WidgetMarkdown while preserving cloud-specific padding

Testing

  • pnpm typecheck

┆Issue is synchronized with this Notion page by Unito

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-6950-core-1.32-manual

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 27, 2025
@christian-byrne christian-byrne force-pushed the backport-6950-core-1.32-manual branch from 88dc3c9 to 1fb0495 Compare November 27, 2025 04:59
Refactor to remove LOD from vue nodes. Also, hide Litegraph LOD settings
in vue nodes to prevent confusion / stale setting. Keep litegraph LOD
the exact same.

- **What**: settings, all LOD related code in vue nodes

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-6950-fix-remove-LOD-from-vue-nodes-2b76d73d365081568723f8cbc7be7e17)
by [Unito](https://www.unito.io)

---------

Co-authored-by: github-actions <[email protected]>
(cherry picked from commit 4b87b1f)
@christian-byrne christian-byrne force-pushed the backport-6950-core-1.32-manual branch from 1fb0495 to e9d873e Compare November 27, 2025 05:38
@github-actions
Copy link

github-actions bot commented Nov 27, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 11/27/2025, 05:54:17 AM UTC

📈 Summary

  • Total Tests: 478
  • Passed: 428 ✅
  • Failed: 16 ❌
  • Flaky: 4 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 419 / ❌ 16 / ⚠️ 4 / ⏭️ 30
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne merged commit d8efb2b into core/1.32 Nov 27, 2025
18 of 20 checks passed
@christian-byrne christian-byrne deleted the backport-6950-core-1.32-manual branch November 27, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants