fix: ordering of Vue mode LOD setting initialization in browser tests#6884
Merged
christian-byrne merged 2 commits intomainfrom Nov 24, 2025
Merged
fix: ordering of Vue mode LOD setting initialization in browser tests#6884christian-byrne merged 2 commits intomainfrom
christian-byrne merged 2 commits intomainfrom
Conversation
dosubot
bot
added
the
size:XS
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 WalkthroughWalkthroughThe LOD test configuration in Vue Nodes was modified to relocate the Changes
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/24/2025, 03:54:10 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 11/24/2025, 04:05:14 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 941 kB (baseline 941 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 7.97 kB (baseline 7.97 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 306 kB (baseline 306 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 141 kB (baseline 141 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.7 MB (baseline 5.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BBundles that do not match a named category
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
browser_tests/tests/vueNodes/nodeStates/lod.spec.ts (1)
10-15: LGTM! Fix correctly addresses the timing issue.The relocation of the LOD threshold setting to after
setup()andloadWorkflow()resolves the race condition where Vue's initialization was overriding the test value back to 0. This ensures the custom threshold (8) takes effect during the test execution.Consider adding a comment to document the ordering requirement:
await comfyPage.setSetting('Comfy.VueNodes.Enabled', true) await comfyPage.setup() await comfyPage.loadWorkflow('default') + // Set LOD threshold after setup/loadWorkflow to prevent Vue initialization from overriding it await comfyPage.setSetting('LiteGraph.Canvas.MinFontSizeForLOD', 8)This would help future maintainers understand why this specific ordering is necessary and prevent accidental reordering.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
browser_tests/tests/vueNodes/nodeStates/lod.spec.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: test
- GitHub Check: lint-and-format
- GitHub Check: setup
- GitHub Check: collect
DrJKL
previously approved these changes
Nov 24, 2025
DrJKL
added
the
New Browser Test Expectations
|
Updating Playwright Expectations |
github-actions
bot
removed
the
New Browser Test Expectations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test "should toggle LOD based on zoom threshold" failing (example: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/19618176782/job/56174006314).
Test execution order:
┆Issue is synchronized with this Notion page by Unito