-
Notifications
You must be signed in to change notification settings - Fork 420
[feat] Add cloud notification modal for macOS desktop users #6845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
deepme987
wants to merge
4
commits into
main
Choose a base branch
from
feat/cloud-notification-macos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e5ba351
[feat] Add cloud notification modal for macOS desktop users
deepme987 de39ece
Add analytics tracking for cloud notification feature
deepme987 7bba8f0
Fix: Cloud notification badge reactivity and modal timing
deepme987 f5c2613
Remove cloud notification badge from topbar
deepme987 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
src/components/dialog/content/CloudNotificationContent.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| <template> | ||
| <div class="w-[480px] p-6"> | ||
| <!-- Header with Logo --> | ||
| <div class="mb-6"> | ||
| <div class="mb-2 flex items-center gap-3"> | ||
| <img | ||
| src="/assets/images/comfy-cloud-logo.svg" | ||
| alt="Comfy Cloud" | ||
| class="h-8 w-8 shrink-0" | ||
| /> | ||
| <h1 class="text-2xl font-semibold"> | ||
| {{ t('cloudNotification.title') }} | ||
| </h1> | ||
| </div> | ||
| <p class="text-base text-muted"> | ||
| {{ t('cloudNotification.message') }} | ||
| </p> | ||
| </div> | ||
|
|
||
| <!-- Features --> | ||
| <div class="mb-6 space-y-4"> | ||
| <div class="flex gap-3"> | ||
| <i class="pi pi-check-circle mt-0.5 shrink-0 text-xl text-blue-500"></i> | ||
| <div class="flex-1"> | ||
| <div class="mb-1 font-medium"> | ||
| {{ t('cloudNotification.feature1Title') }} | ||
| </div> | ||
| <div class="text-sm text-muted"> | ||
| {{ t('cloudNotification.feature1') }} | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="flex gap-3"> | ||
| <i class="pi pi-server mt-0.5 shrink-0 text-xl text-blue-500"></i> | ||
| <div class="flex-1"> | ||
| <div class="mb-1 font-medium"> | ||
| {{ t('cloudNotification.feature2Title') }} | ||
| </div> | ||
| <div class="text-sm text-muted"> | ||
| {{ t('cloudNotification.feature2') }} | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="flex gap-3"> | ||
| <i class="pi pi-tag mt-0.5 shrink-0 text-xl text-blue-500"></i> | ||
| <div class="flex-1"> | ||
| <div class="mb-1 font-medium"> | ||
| {{ t('cloudNotification.feature3Title') }} | ||
| </div> | ||
| <div class="text-sm text-muted"> | ||
| {{ t('cloudNotification.feature3') }} | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <!-- Footer Note --> | ||
| <div | ||
| class="mb-6 rounded border-l-2 border-blue-500 bg-blue-500/5 py-2.5 pl-3 pr-4" | ||
| > | ||
| <p class="whitespace-pre-line text-sm text-muted"> | ||
| {{ t('cloudNotification.feature4') }} | ||
| </p> | ||
| </div> | ||
|
|
||
| <!-- Actions --> | ||
| <div class="flex gap-3"> | ||
| <Button | ||
| :label="t('cloudNotification.continueLocally')" | ||
| severity="secondary" | ||
| outlined | ||
| class="flex-1" | ||
| @click="onDismiss" | ||
| /> | ||
| <Button | ||
| :label="t('cloudNotification.exploreCloud')" | ||
| icon="pi pi-arrow-right" | ||
| icon-pos="right" | ||
| class="flex-1" | ||
| @click="onExplore" | ||
| /> | ||
| </div> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import Button from 'primevue/button' | ||
| import { useI18n } from 'vue-i18n' | ||
|
|
||
| import { useDialogStore } from '@/stores/dialogStore' | ||
|
|
||
| const { t } = useI18n() | ||
|
|
||
| const onDismiss = () => { | ||
| useDialogStore().closeDialog() | ||
| } | ||
|
|
||
| const onExplore = () => { | ||
| window.open('https://www.comfy.org/cloud', '_blank') | ||
| useDialogStore().closeDialog() | ||
| } | ||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.