[bugfix] Fix double-click required after pasting URL in upload model dialog #6801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-mino-altherr
added
the
verified bug
dosubot
bot
added
the
size:S
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/21/2025, 05:50:59 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 11/21/2025, 06:01:06 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.13 MB (baseline 3.13 MB) • 🟢 -107 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 945 kB (baseline 945 kB) • 🔴 +154 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 7.97 kB (baseline 7.97 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 306 kB (baseline 306 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 141 kB (baseline 141 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 5.32 MB (baseline 5.32 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BBundles that do not match a named category
Status: 18 added / 18 removed |
christian-byrne
added
needs-backport
christian-byrne
previously approved these changes
Nov 21, 2025
DrJKL
reviewed
Nov 21, 2025
| if (!canFetchMetadata.value) return | ||
|
|
||
| // Clean and normalize URL | ||
| let cleanedUrl = wizardData.value.url.replace(/\s+/g, '') |
Contributor
There was a problem hiding this comment.
Some URLs have spaces in them that would normally be encoded as %20 but this would just remove them.
I think you might want to do a .trim() and then encodeURI.
DrJKL
requested changes
Nov 21, 2025
Contributor
DrJKL
left a comment
DrJKL
left a comment
There was a problem hiding this comment.
Forgot to hit request changes.
…dialog Replace UrlInput with plain InputText to emit value immediately on input instead of only on blur. Move URL cleaning/normalization to fetchMetadata handler. Remove unused disableValidation prop from UrlInput component. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
luke-mino-altherr
force-pushed
the
fix/upload-model-url-input-focus
branch
from
c94ea74 to
56d38a8
Compare
DrJKL
approved these changes
Nov 21, 2025
DrJKL
added
backport
christian-byrne
added
needs-backport
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
…dialog (#6801) ## Summary Fixed an issue where users had to click twice to continue after pasting a URL in the upload model dialog - once to blur the input, then again to click the button. ## Changes - **What**: Replaced `UrlInput` with plain `InputText` in `UploadModelUrlInput` to emit value immediately on input instead of only on blur - **Cleanup**: Moved URL cleaning/normalization to the `fetchMetadata` handler, removed unused `disableValidation` prop from `UrlInput` component ## Review Focus - URL normalization logic in `useUploadModelWizard.ts` 🤖 Generated with [Claude Code](https://claude.com/claude-code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6801-bugfix-Fix-double-click-required-after-pasting-URL-in-upload-model-dialog-2b26d73d3650811881aed0cc064efcc7) by [Unito](https://www.unito.io) --------- Co-authored-by: Claude <[email protected]>
Member
|
@luke-mino-altherr Successfully backported to #6815 |
github-actions
bot
removed
the
needs-backport
christian-byrne
pushed a commit
that referenced
this pull request
Nov 21, 2025
…g URL in upload model dialog (#6815) Backport of #6801 to `cloud/1.32` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6815-backport-cloud-1-32-bugfix-Fix-double-click-required-after-pasting-URL-in-upload-mode-2b26d73d3650811fa5c7ffab9d25df4f) by [Unito](https://www.unito.io) Co-authored-by: Luke Mino-Altherr <[email protected]> Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an issue where users had to click twice to continue after pasting a URL in the upload model dialog - once to blur the input, then again to click the button.
Changes
UrlInputwith plainInputTextinUploadModelUrlInputto emit value immediately on input instead of only on blurfetchMetadatahandler, removed unuseddisableValidationprop fromUrlInputcomponentReview Focus
useUploadModelWizard.ts🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito