Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run formatter and add .js to gitattributes #673

Merged
merged 2 commits into from
Aug 28, 2024
Merged

run formatter and add .js to gitattributes #673

merged 2 commits into from
Aug 28, 2024

Conversation

mcmonkey4eva
Copy link
Contributor

add *.js to prior gitattributes PR (sorry missed that we have a few .js files that the formatter hits)

now that I can run npm run format without it rewriting every file - apparently a few things were not formatted? It added parens on a couple ternaries.

@mcmonkey4eva
Copy link
Contributor Author

prettier check failed - does npm run format disagree on format rules with the other prettier impl?

@mcmonkey4eva
Copy link
Contributor Author

removed format apply for now, just add *.js to gitattributes for now -- though we should figure out why npm run format applied a different format rule than the other impl of prettier did?

@huchenlei huchenlei merged commit d5b4311 into main Aug 28, 2024
5 checks passed
@huchenlei huchenlei deleted the format-and-js-gitattr branch August 28, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmonkey4eva @huchenlei