refactor: change telemetry service to use hook registry instead of importing directly from modules in lower layers #6693
Closed
christian-byrne wants to merge 2 commits intomainfrom
Closed
refactor: change telemetry service to use hook registry instead of importing directly from modules in lower layers #6693christian-byrne wants to merge 2 commits intomainfrom
christian-byrne wants to merge 2 commits intomainfrom
Conversation
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/14/2025, 02:37:48 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results🕵🏻 No test results found ⏰ Completed at: 11/14/2025, 02:40:10 AM UTC 📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
commented
Nov 14, 2025
| * @param eventData The event data (any JSON-serializable object) | ||
| * @returns Promise resolving to the response | ||
| */ | ||
| async postCloudAnalytics( |
Contributor
Author
There was a problem hiding this comment.
TODO: make this tree-shaken on local
christian-byrne
changed the title
Contributor
Author
|
This was done in #8354, closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the telemetry service such that it does not depend on other lower-layer modules (only library or other platform-level modules). This way, it can be imported early in the app bootstrap (e.g., in onboarding views).
Alsos extends the service interface to better support composition with multiple providers (Clickhouse, Mixpanel, DD, Sentry, etc.).
┆Issue is synchronized with this Notion page by Unito