-
Notifications
You must be signed in to change notification settings - Fork 428
Cloud feedback Extension #6626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Cloud feedback Extension #6626
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9507476
[feat] Add ActionBarButton interface to extension API
Myestery f8fe51a
[feat] Add action bar button store for extension buttons
Myestery 055aeff
[feat] Add ActionBarButtons component for action bar
Myestery 9941922
[feat] Integrate ActionBarButtons into action bar container
Myestery 4a1de14
[feat] Add cloud feedback button extension
Myestery 663a212
[feat] Register cloud feedback button extension
Myestery 3282bde
[fix] Use i18n translation for feedback button text
Myestery 1fe9b0f
update zendesk feedback url
Myestery 5f54ed4
fix claude review comments
Myestery 45fa1d7
fix i18n
Myestery 9dcc4d4
add aria label
Myestery File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <template> | ||
| <div class="flex h-full shrink-0 items-center gap-1"> | ||
| <Button | ||
Myestery marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| v-for="(button, index) in actionBarButtonStore.buttons" | ||
| :key="index" | ||
| v-tooltip.bottom="button.tooltip" | ||
| :label="button.label" | ||
| :aria-label="button.tooltip || button.label" | ||
| :class="button.class" | ||
| text | ||
| rounded | ||
| severity="secondary" | ||
| class="h-7" | ||
| @click="button.onClick" | ||
| > | ||
| <template #icon> | ||
| <i :class="button.icon" /> | ||
| </template> | ||
| </Button> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script lang="ts" setup> | ||
| import Button from 'primevue/button' | ||
|
|
||
| import { useActionBarButtonStore } from '@/stores/actionBarButtonStore' | ||
|
|
||
| const actionBarButtonStore = useActionBarButtonStore() | ||
| </script> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { t } from '@/i18n' | ||
| import { useExtensionService } from '@/services/extensionService' | ||
| import type { ActionBarButton } from '@/types/comfy' | ||
|
|
||
| // Zendesk feedback URL - update this with the actual URL | ||
| const ZENDESK_FEEDBACK_URL = | ||
| 'https://support.comfy.org/hc/en-us/requests/new?ticket_form_id=43066738713236' | ||
|
|
||
| const buttons: ActionBarButton[] = [ | ||
| { | ||
| icon: 'icon-[lucide--message-circle-question-mark]', | ||
| label: t('actionbar.feedback'), | ||
| tooltip: t('actionbar.feedbackTooltip'), | ||
| onClick: () => { | ||
| window.open(ZENDESK_FEEDBACK_URL, '_blank', 'noopener,noreferrer') | ||
Myestery marked this conversation as resolved.
Show resolved
Hide resolved
Myestery marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| ] | ||
|
|
||
| useExtensionService().registerExtension({ | ||
| name: 'Comfy.Cloud.FeedbackButton', | ||
| actionBarButtons: buttons | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { defineStore } from 'pinia' | ||
| import { computed } from 'vue' | ||
|
|
||
| import type { ActionBarButton } from '@/types/comfy' | ||
|
|
||
| import { useExtensionStore } from './extensionStore' | ||
|
|
||
| export const useActionBarButtonStore = defineStore('actionBarButton', () => { | ||
| const extensionStore = useExtensionStore() | ||
|
|
||
| const buttons = computed<ActionBarButton[]>(() => | ||
Myestery marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| extensionStore.extensions.flatMap((e) => e.actionBarButtons ?? []) | ||
| ) | ||
|
|
||
| return { | ||
| buttons | ||
| } | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (non-blocking): Is it worth to do
v-ifon condition!!button.length?