fix: add cloud badges and server health alerts to second-row workflow tabs #6515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tabs Badges were only visible when WorkflowTabsPosition was set to 'Topbar', but not when set to 'Topbar (2nd-row)' which is the default for screens < 1536px wide. This adds TopbarBadges component to SecondRowWorkflowTabs.vue to ensure cloud badges and server health alerts are visible in both topbar positions.
dosubot
bot
added
the
size:XS
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 11/01/2025, 10:53:25 AM UTC 📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
added a commit
that referenced
this pull request
Nov 5, 2025
…sition ## Summary Fixes incorrect badge placement from PR #6515. Badges should remain in the main topbar row at all times, not move to the second row with workflow tabs. ## Problem PR #6515 added TopbarBadges to SecondRowWorkflowTabs.vue, causing badges to appear in the second row when workflow tabs position was set to 'Topbar (2nd-row)'. The original issue was that badges weren't visible when tabs were in second-row mode because they were conditionally rendered only when workflowTabsPosition === 'Topbar'. ## Changes - Remove TopbarBadges from SecondRowWorkflowTabs.vue (badges should never be in second row) - Move TopbarBadges from conditional workflow tabs row to main topbar in TopMenubar.vue - Badges now always display in main topbar regardless of workflow tabs position
christian-byrne
added a commit
that referenced
this pull request
Nov 5, 2025
…sition (#6592) ## Summary Fixes incorrect badge placement from PR #6515. Badges should remain in the main topbar row at all times, not move to the second row with workflow tabs. ## Problem PR #6515 added `TopbarBadges` to `SecondRowWorkflowTabs.vue`, causing badges to appear in the second row when workflow tabs position was set to `'Topbar (2nd-row)'`. The original issue was that badges weren't visible when tabs were in second-row mode because they were conditionally rendered only when `workflowTabsPosition === 'Topbar'`. ## Changes - Remove `TopbarBadges` from `SecondRowWorkflowTabs.vue` (badges should never be in second row) - Move `TopbarBadges` from conditional workflow tabs row to main topbar in `TopMenubar.vue` - Badges now always display in main topbar regardless of workflow tabs position ## Testing - Badges visible in main topbar when `workflowTabsPosition === 'Topbar'` - Badges visible in main topbar when `workflowTabsPosition === 'Topbar (2nd-row)'` - Workflow tabs correctly move to second row without badges Fixes issue introduced in #6515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes missing cloud badges and server health alerts when workflow tabs are in the second-row position.
Problem
Badges were only visible when
Comfy.Workflow.WorkflowTabsPositionwas set to'Topbar', but not when set to'Topbar (2nd-row)'which is the default for screens < 1536px wide on rh-test.The
SecondRowWorkflowTabs.vuecomponent only rendered<WorkflowTabs />but was missing<TopbarBadges />.Changes
<TopbarBadges />component toSecondRowWorkflowTabs.vueTesting
Note
This is an rh-test only issue. The main branch removed the 'Topbar (2nd-row)' option in the Floating Menus PR (#5980).
┆Issue is synchronized with this Notion page by Unito