Multiple fixes related to copying subgraphs #6383

AustinMroz · 2025-10-29T21:33:41Z

DOMWidgets have ownership reset after a subgraphNode.clone().
- Fixes Ctrl+C on a subgraphNode with a prompted prompt making the prompt disappear.
alt + drag uses the copy/paste pathway that deeply clones subgraphs.
Fixed dangling references on nodes in subgraphs by updating subgraph ids before configuration.
Attempt to recursively resolve disconnected proxyWidgets (Can matter when subgraphs load out of order).
Fix Right click -> clone creating linked copies of subgraphs.

┆Issue is synchronized with this Notion page by Unito

github-actions · 2025-10-29T21:34:05Z

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 10/30/2025, 01:02:57 AM UTC

📈 Summary

Total Tests: 501
Passed: 470 ✅
Failed: 0
Flaky: 1 ⚠️
Skipped: 30 ⏭️

📊 Test Reports by Browser

✅ chromium: View Report • ✅ 461 / ❌ 0 / ⚠️ 1 / ⏭️ 30
✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

github-actions · 2025-10-29T21:34:11Z

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 10/30/2025, 12:50:18 AM UTC

🔗 Links

📊 View Workflow Run
🎨 View Storybook

🎉 Your Storybook is ready for review!

github-actions · 2025-10-29T21:36:06Z

Bundle Size Report

Summary

Raw size: 12.3 MB baseline 12.3 MB — 🟢 -600 B
Gzip: 2.49 MB baseline 2.49 MB — 🔴 +15 B
Brotli: 1.96 MB baseline 1.96 MB — 🟢 -121 B
Bundles: 57 current • 57 baseline • 12 added / 12 removed

Category Glance
App Entry Points 🟢 -600 B (3.31 MB) · Vendor & Third-Party ⚪ 0 B (5.36 MB) · Other ⚪ 0 B (2.55 MB) · Graph Workspace ⚪ 0 B (716 kB) · Panels & Settings ⚪ 0 B (294 kB) · UI Components ⚪ 0 B (12.3 kB) · + 3 more

Per-category breakdown

App Entry Points — 3.31 MB (baseline 3.31 MB) • 🟢 -600 B

Main entry bundles and manifests

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/index-DlfikPmE.js~~ (removed)	2.69 MB	—	🟢 -2.69 MB	🟢 -561 kB	🟢 -424 kB
assets/index-Bu2kiCTr.js (new)	—	2.69 MB	🔴 +2.69 MB	🔴 +561 kB	🔴 +424 kB
assets/index-CwOnORLV.js (new)	—	617 kB	🔴 +617 kB	🔴 +114 kB	🔴 +90.4 kB
~~assets/index-PeRaQ83W.js~~ (removed)	617 kB	—	🟢 -617 kB	🟢 -114 kB	🟢 -90.4 kB

Status: 2 added / 2 removed

Graph Workspace — 716 kB (baseline 716 kB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/GraphView-Bwr_sXnd.js (new)	—	716 kB	🔴 +716 kB	🔴 +140 kB	🔴 +108 kB
~~assets/GraphView-DqCPZPMv.js~~ (removed)	716 kB	—	🟢 -716 kB	🟢 -140 kB	🟢 -108 kB

Status: 1 added / 1 removed

Views & Navigation — 8.14 kB (baseline 8.14 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/UserSelectView-B4SdIYcH.js (new)	—	8.14 kB	🔴 +8.14 kB	🔴 +2.46 kB	🔴 +2.16 kB
~~assets/UserSelectView-Bn0uSTyA.js~~ (removed)	8.14 kB	—	🟢 -8.14 kB	🟢 -2.46 kB	🟢 -2.16 kB

Status: 1 added / 1 removed

Panels & Settings — 294 kB (baseline 294 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
~~assets/CreditsPanel-DI02E56i.js~~ (removed)	22 kB	—	🟢 -22 kB	🟢 -5.28 kB	🟢 -4.62 kB
assets/CreditsPanel-mh6G0EZ1.js (new)	—	22 kB	🔴 +22 kB	🔴 +5.28 kB	🔴 +4.62 kB
assets/KeybindingPanel-CH58VP7e.js (new)	—	15.2 kB	🔴 +15.2 kB	🔴 +3.76 kB	🔴 +3.31 kB
~~assets/KeybindingPanel-Kh08C2b9.js~~ (removed)	15.2 kB	—	🟢 -15.2 kB	🟢 -3.76 kB	🟢 -3.31 kB
assets/ExtensionPanel-CTQlPiZd.js (new)	—	12.1 kB	🔴 +12.1 kB	🔴 +2.82 kB	🔴 +2.47 kB
~~assets/ExtensionPanel-KJhTzkh5.js~~ (removed)	12.1 kB	—	🟢 -12.1 kB	🟢 -2.82 kB	🟢 -2.47 kB
~~assets/AboutPanel-BxAM9dOn.js~~ (removed)	10.3 kB	—	🟢 -10.3 kB	🟢 -2.66 kB	🟢 -2.33 kB
assets/AboutPanel-CwxVvj3o.js (new)	—	10.3 kB	🔴 +10.3 kB	🔴 +2.66 kB	🔴 +2.33 kB
assets/ServerConfigPanel-C5EV9BMp.js (new)	—	8.2 kB	🔴 +8.2 kB	🔴 +2.16 kB	🔴 +1.9 kB
~~assets/ServerConfigPanel-DD9Ut1yy.js~~ (removed)	8.2 kB	—	🟢 -8.2 kB	🟢 -2.16 kB	🟢 -1.9 kB
~~assets/UserPanel-Bn5O8UVY.js~~ (removed)	7.91 kB	—	🟢 -7.91 kB	🟢 -2.06 kB	🟢 -1.79 kB
assets/UserPanel-DsrCz7HW.js (new)	—	7.91 kB	🔴 +7.91 kB	🔴 +2.06 kB	🔴 +1.79 kB
assets/settings-B-df0dZe.js	20.7 kB	20.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CI6OKvJn.js	22.9 kB	22.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-CXGVj_nD.js	24.5 kB	24.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DfQ6dSJj.js	31.6 kB	31.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DJ2QgDzm.js	25.2 kB	25.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DRNLPMG6.js	23.7 kB	23.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-DVVycxDc.js	19.9 kB	19.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-G6Dybj1b.js	24.1 kB	24.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/settings-M6_GZccG.js	26 kB	26 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 6 added / 6 removed

UI Components — 12.3 kB (baseline 12.3 kB) • ⚪ 0 B

Reusable component library chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/ComfyQueueButton-BdYRzEIT.js (new)	—	11.1 kB	🔴 +11.1 kB	🔴 +2.75 kB	🔴 +2.44 kB
~~assets/ComfyQueueButton-BpHrbHqj.js~~ (removed)	11.1 kB	—	🟢 -11.1 kB	🟢 -2.75 kB	🟢 -2.44 kB
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js	1.12 kB	1.12 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 1 added / 1 removed

Data & Services — 10 kB (baseline 10 kB) • ⚪ 0 B

Stores, services, APIs, and repositories

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/keybindingService-BdLPmPan.js (new)	—	7.21 kB	🔴 +7.21 kB	🔴 +1.75 kB	🔴 +1.5 kB
~~assets/keybindingService-BTLiM8NU.js~~ (removed)	7.21 kB	—	🟢 -7.21 kB	🟢 -1.75 kB	🟢 -1.5 kB
assets/serverConfigStore-a46y6iwm.js	2.79 kB	2.79 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Status: 1 added / 1 removed

Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/mathUtil-CTARWQ-l.js	1.07 kB	1.07 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Vendor & Third-Party — 5.36 MB (baseline 5.36 MB) • ⚪ 0 B

External libraries and shared vendor chunks

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/vendor-other-BwM5763c.js	3.22 MB	3.22 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-primevue-PESgPnbc.js	517 B	517 B	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-three-DjRIbjYR.js	1.41 MB	1.41 MB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-tiptap-C6rhmSpC.js	232 kB	232 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-vue-Bze-dcMt.js	92.4 kB	92.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/vendor-xterm-BZLod3g9.js	407 kB	407 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 B

Bundles that do not match a named category

File	Before	After	Δ Raw	Δ Gzip	Δ Brotli
assets/commands-B2KZRBmX.js	15.1 kB	15.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-Bw-ckyga.js	13.9 kB	13.9 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-C_NmM85I.js	13.8 kB	13.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-CuozCW4W.js	14 kB	14 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DGfVUJCR.js	16.2 kB	16.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-dOJNDogK.js	14.5 kB	14.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-DwiE551e.js	14.7 kB	14.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-Fw7mvqSy.js	13.1 kB	13.1 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/commands-FXnO1W4Q.js	13.2 kB	13.2 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Bgu6_Hvd.js	59.5 kB	59.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-Bv0L0qvp.js	93 kB	93 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-C3Doz3n_.js	67.6 kB	67.6 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-C7eBl607.js	70.7 kB	70.7 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CHiV9ds2.js	76.4 kB	76.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-CIc79Nts.js	68.5 kB	68.5 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-DK5LmuBm.js	58.8 kB	58.8 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-J1nit7cj.js	66.3 kB	66.3 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/main-W97XgvAQ.js	80.4 kB	80.4 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-8Ef8lY1m.js	196 kB	196 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-BdF8EiZl.js	200 kB	200 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-Bv9Y8Cvp.js	229 kB	229 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-cMdB_wHv.js	179 kB	179 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CvNWbbtX.js	194 kB	194 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CwDWxzVz.js	215 kB	215 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-CyPAVHpA.js	191 kB	191 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-D6QTD6bJ.js	181 kB	181 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B
assets/nodeDefs-DKn6VmRJ.js	192 kB	192 kB	⚪ 0 B	⚪ 0 B	⚪ 0 B

AustinMroz added 3 commits October 29, 2025 11:22

Reset DOMWidget ownership on clone of subgraphNode

a0c18bd

Swap alt+drag to use reuse copy/paste code

5390d80

On deserialization update ids before configure

192fb4e

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 29, 2025

AustinMroz changed the title ~~Austin/subgraph clone improvements~~ Multiple fixes related to copying subgraphs Oct 29, 2025

AustinMroz added 2 commits October 29, 2025 15:04

Force recursive resolution of proxyWidgets

ee0c5f1

Fix node position on alt+drag

7cead43

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 29, 2025

Use copy/paste pathway for right click -> clone

73045fc

DrJKL previously approved these changes Oct 30, 2025

View reviewed changes

Use clearer check for proxyWidgets

93c02a9

AustinMroz dismissed DrJKL’s stale review via 93c02a9 October 30, 2025 00:48

DrJKL approved these changes Oct 30, 2025

View reviewed changes

AustinMroz merged commit 6f068c8 into main Oct 30, 2025
27 checks passed

AustinMroz deleted the austin/subgraph-clone-improvements branch October 30, 2025 01:05

AustinMroz mentioned this pull request Oct 30, 2025

Subgraphs are buggy #6391

Closed

1 task

dosubot bot mentioned this pull request Nov 8, 2025

Linked subgraphs are entirely broken #6639

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Multiple fixes related to copying subgraphs #6383

Multiple fixes related to copying subgraphs #6383

Uh oh!

AustinMroz commented Oct 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Multiple fixes related to copying subgraphs #6383

Multiple fixes related to copying subgraphs #6383

Uh oh!

Conversation

AustinMroz commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 Playwright Test Results

📈 Summary

📊 Test Reports by Browser

Uh oh!

github-actions bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎨 Storybook Build Status

🔗 Links

Uh oh!

github-actions bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AustinMroz commented Oct 29, 2025 •

edited

Loading

github-actions bot commented Oct 29, 2025 •

edited

Loading

github-actions bot commented Oct 29, 2025 •

edited

Loading

github-actions bot commented Oct 29, 2025 •

edited

Loading