fix terminal style #6056
Merged
fix terminal style #6056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
christian-byrne
changed the title
🎭 Playwright Test Results⏰ Completed at: 10/14/2025, 08:25:22 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/14/2025, 08:09:36 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
christian-byrne
added
needs-backport
|
@christian-byrne Backport to Please manually cherry-pick commit Conflicting files
|
arjansingh
pushed a commit
that referenced
this pull request
Oct 16, 2025
## Summary After #5292, at certain browser zoom levels, the xterm terminal did not fill horizontal space properly, showing a gap with mismatched background colors (`#171717` viewport vs `black` terminal content). Fixes #6049 ## Problem The hardcoded `#171717` terminal theme background only affected the xterm viewport, while terminal content remained black, causing a visible color mismatch at low zoom levels where the gap was more apparent. Fixed by keeping original theme when not on desktop distribution. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6056-fix-terminal-style-28c6d73d36508132b521e5767f41d540) by [Unito](https://www.unito.io)
arjansingh
added a commit
that referenced
this pull request
Oct 17, 2025
## Summary Updates with cloud specific features merged into `main`. Notable changes include the `DISTRIBUTION=cloud` changes. Will also be changing cloud build workflow to build with that flag in Comfy-Org/cloud#1043 ## Changes - bb61d98 feat: AssetCard tweaks (#6085) - 05f7352 fix terminal style (#6056) - d5fa221 Add distribution detection pattern (#6028) - 6c36aaa feat: Improve MediaAssetCard video controls and add gallery view (#6065) - 6944ef0 fix Cloudbadge (#6063) - 6764f8d Badge for cloud environment (#6048) --------- Co-authored-by: Johnpaul Chiwetelu <[email protected]> Co-authored-by: Jin Yi <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: Christian Byrne <[email protected]>
Merged
christian-byrne
added a commit
that referenced
this pull request
Oct 17, 2025
## Summary After #5292, at certain browser zoom levels, the xterm terminal did not fill horizontal space properly, showing a gap with mismatched background colors (`#171717` viewport vs `black` terminal content). Fixes #6049 ## Problem The hardcoded `#171717` terminal theme background only affected the xterm viewport, while terminal content remained black, causing a visible color mismatch at low zoom levels where the gap was more apparent. Fixed by keeping original theme when not on desktop distribution. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6056-fix-terminal-style-28c6d73d36508132b521e5767f41d540) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #5292, at certain browser zoom levels, the xterm terminal did not fill horizontal space properly, showing a gap with mismatched background colors (
#171717viewport vsblackterminal content).Fixes #6049
Problem
The hardcoded
#171717terminal theme background only affected the xterm viewport, while terminal content remained black, causing a visible color mismatch at low zoom levels where the gap was more apparent.Fixed by keeping original theme when not on desktop distribution.
┆Issue is synchronized with this Notion page by Unito