fix(execution): reset progress state after runs to unfreeze tab title/favicon (main) #6026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎭 Playwright Test Results⏰ Completed at: 10/12/2025, 01:11:15 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/12/2025, 12:57:15 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
dosubot
bot
added
the
size:S
christian-byrne
added
needs-backport
github-actions bot
pushed a commit
that referenced
this pull request
Oct 12, 2025
…/favicon (main) (#6026) Cherry picked over from #6025, should've been made to target main to begin with ## Summary Fixes the browser tab progress and favicon remaining at ~14% after workflow completion on `main` by resetting execution state when a run ends (success, error, or interruption). ## Changes - Add `execution_success` listener in the execution store - Centralize terminal-state cleanup in `resetExecutionState()` - Clear `nodeProgressStates`, queued prompt entry, `_executingNodeProgress`, and set `activePromptId` to `null` - Ensures `isIdle` becomes `true` post-run so tab title and favicon no longer freeze mid-progress resolves #6024 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6026-fix-execution-reset-progress-state-after-runs-to-unfreeze-tab-title-favicon-main-28a6d73d365081f188ebc2e69d936dd9) by [Unito](https://www.unito.io)
|
@benceruleanlu Successfully backported to #6027 |
arjansingh
pushed a commit
that referenced
this pull request
Oct 12, 2025
…freeze tab title/favicon (main) (#6027) Backport of #6026 to `core/1.28` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6027-backport-1-28-fix-execution-reset-progress-state-after-runs-to-unfreeze-tab-title-fav-28a6d73d3650815d866efa9f3190f88c) by [Unito](https://www.unito.io) Co-authored-by: Benjamin Lu <[email protected]>
Merged
arjansingh
added a commit
that referenced
this pull request
Oct 14, 2025
## What's Changed ### 🚀 Features - Add MediaAssetCard presentation components (#5878) - Make Vue nodes' outputs/previews responsively sized and work with node resizing (#5970) - Allow connection to subgraphIOs in vue mode (#6016) - Add distribution detection pattern (#6028) - Make nodeData.widgets reactive (#6019) ### 🐛 Bug Fixes - Fix FLOAT widget incrementing broken & disabled state styles on widget number input (Vue) (#6036) - Fix Vue node border styles in different states (executing, error, selected) (#6018) - Fix Vue node opacity conditions (user node opacity, bypass state, muted state) (#6022) - Fix: emit layout change for batch node bounds (#5939) - Safer restoration of widgets_values on subgraph nodes (#6015) - Fix(execution): reset progress state after runs to unfreeze tab title/favicon (main) (#6026) - Use type check instead of cast (#6041) ### 🎨 Style & Design - [style] match widget border/outline styles with designs (#6021) - [style] make Vue widget/slot/label width and spacing align with designs (#6023) ### ♿ Accessibility - Add aria labels on vue node widgets (#6032) ### 🔧 Maintenance - [refactor] adjust Vue node fixtures to not be coupled to Litegraph (#6033) - [refactor] reorganize devtools test nodes into modules (#6020) ### 🧪 Testing - [test] add browser test for control+a selection of Vue nodes (#6031) ### 🔄 CI/CD - [ci] fix update locales workflow (#6017) **Full Changelog**: v1.29.1...v1.29.2 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6045-1-29-2-28c6d73d3650817a8c36fba944ce69a8) by [Unito](https://www.unito.io) --------- Co-authored-by: arjansingh <[email protected]> Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked over from #6025, should've been made to target main to begin with
Summary
Fixes the browser tab progress and favicon remaining at ~14% after workflow completion on
mainby resetting execution state when a run ends (success, error, or interruption).Changes
execution_successlistener in the execution storeresetExecutionState()nodeProgressStates, queued prompt entry,_executingNodeProgress, and setactivePromptIdtonullisIdlebecomestruepost-run so tab title and favicon no longer freeze mid-progressresolves #6024
┆Issue is synchronized with this Notion page by Unito