feat: add default keybindings for changing the mask brush size #6003
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
🎨 Storybook Build Status
⏰ Started at: 10/10/2025, 06:02:50 AM UTC 🚀 Building Storybook
⏱️ Please wait while the Storybook build is in progress... |
🎭 Playwright Test Results⏰ Completed at: 10/10/2025, 06:17:50 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
jtydhr88
previously approved these changes
Oct 9, 2025
Make it easier to change the mask brush size. These keybindings are familiar to users of other image editors.
Handle the brush size hotkeys in the MaskEditor's KeyboardManager instead of using global keybindings. This keeps these hotkeys scoped to the editor instead of firing globally.
davvid-comfy
force-pushed
the
maskeditor-keyboard-shortcuts
branch
from
bea4591 to
56d2f0f
Compare
|
I see what you mean about the local keybinding manager. I added a 2nd commit that handles this behavior using the scoped keyDown callback instead of with a global keybinding. If you think the end result looks better I'll squash the two commits together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make it easier to change the mask brush size. These keybindings are familiar to users of other image editors.
Changes
[to decrease and]to increase the brush size.Review Focus
Is this generically useful enough to include the default keybindings?
┆Issue is synchronized with this Notion page by Unito
References