Skip to content

fix "what's changed" release toast attention level logic #5959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJKL merged 1 commit into from
Oct 7, 2025
Merged

fix "what's changed" release toast attention level logic #5959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/platform/updates/common/releaseStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,10 @@ export const useReleaseStore = defineStore('release', () => {
) === 0
)

const hasMediumOrHighAttention = computed(() =>
recentReleases.value
.slice(0, -1)
.some(
(release) =>
release.attention === 'medium' || release.attention === 'high'
)
)
const hasMediumOrHighAttention = computed(() => {
const attention = recentRelease.value?.attention
return attention === 'medium' || attention === 'high'
})

// Show toast if needed
const shouldShowToast = computed(() => {
Expand Down
41 changes: 15 additions & 26 deletions tests-ui/tests/store/releaseStore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,16 +145,22 @@ describe('useReleaseStore', () => {

it('should show toast for medium/high attention releases', () => {
vi.mocked(semverCompare).mockReturnValue(1)
store.releases = [mockRelease]

// Need multiple releases for hasMediumOrHighAttention to work
const mediumRelease = {
expect(store.shouldShowToast).toBe(true)
})

it('should not show toast for low attention releases', () => {
vi.mocked(semverCompare).mockReturnValue(1)

const lowAttentionRelease = {
...mockRelease,
id: 2,
attention: 'medium' as const
attention: 'low' as const
}
store.releases = [mockRelease, mediumRelease]

expect(store.shouldShowToast).toBe(true)
store.releases = [lowAttentionRelease]

expect(store.shouldShowToast).toBe(false)
})

it('should show red dot for new versions', () => {
Expand Down Expand Up @@ -490,12 +496,7 @@ describe('useReleaseStore', () => {

vi.mocked(semverCompare).mockReturnValue(1)

const mediumRelease = { ...mockRelease, attention: 'medium' as const }
store.releases = [
mockRelease,
mediumRelease,
{ ...mockRelease, attention: 'low' as const }
]
store.releases = [mockRelease]

expect(store.shouldShowToast).toBe(true)
})
Expand Down Expand Up @@ -578,14 +579,7 @@ describe('useReleaseStore', () => {

it('should show toast when conditions are met', () => {
vi.mocked(semverCompare).mockReturnValue(1)

// Need multiple releases for hasMediumOrHighAttention
const mediumRelease = {
...mockRelease,
id: 2,
attention: 'medium' as const
}
store.releases = [mockRelease, mediumRelease]
store.releases = [mockRelease]

expect(store.shouldShowToast).toBe(true)
})
Expand Down Expand Up @@ -615,12 +609,7 @@ describe('useReleaseStore', () => {
vi.mocked(semverCompare).mockReturnValue(1)

// Set up all conditions that would normally show toast
const mediumRelease = {
...mockRelease,
id: 2,
attention: 'medium' as const
}
store.releases = [mockRelease, mediumRelease]
store.releases = [mockRelease]

expect(store.shouldShowToast).toBe(false)
})
Expand Down
Loading