Missing model downloader #5929
Open
Missing model downloader #5929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds automatic download functionality to the Missing Models dialog. Features: - Automatically adds Download buttons to each missing model - Pre-configured URLs for popular models (SDXL, SD1.5, VAEs, LoRAs, etc.) - Real-time download progress shown in button (percentage) - Custom URL prompt for unknown models - Download All button for bulk downloads - TypeScript implementation with proper typing When the Missing Models dialog appears, users can now download missing models directly without manually searching and moving files. Requires backend API endpoints in ComfyUI server for download functionality.
- Automatically extract URLs from the dialog (no more prompting for URLs that are already shown) - Replace alert/prompt boxes with inline UI elements for better UX - Add inline status messages showing download progress and file sizes - Add inline URL input field when URL is not available - Show "Open URL" link when backend doesn't support downloads - Better error handling and status feedback The extension now: 1. Extracts existing URLs from the dialog HTML 2. Uses inline input fields instead of browser prompts 3. Shows real-time download progress with file sizes 4. Provides better visual feedback with status messages 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Remove /api prefix from model download endpoints - ComfyUI serves these endpoints at /models/download not /api/models/download - This fixes the 405 Method Not Allowed error 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Added data-download-button attribute to track existing buttons - Check for existing buttons before adding new ones - Prevents duplicate buttons from appearing in the UI 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Removed 'Download from provided URL' tooltip - Simplified button title to only show 'Click to enter URL' when needed - Cleaner UI without redundant text 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
dosubot
bot
added
the
size:XL
🎭 Playwright Test Results
⏰ Started at: 10/05/2025, 08:43:53 PM UTC 🚀 Running Tests
⏱️ Please wait while tests are running... |
🎨 Storybook Build Status
⏰ Started at: 10/05/2025, 08:43:55 PM UTC 🚀 Building Storybook
⏱️ Please wait while the Storybook build is in progress... |
|
Hi @fragmede, I wonder if we could break this into smaller parts that consider each desired feature. For model downloading, I think to get the real desired experience, we would need to do it on the server and add parallelization, retry, chunking, mirror handling, etc. If there are other UI/UX improvements, would it be possible to extract the underlying improvement and see if we can integrate it with the existing system a bit? BTW, is this extension currently available as a custom node? |
|
Hi,
I didn't do a custom extension for this, just what you see here.
Happy to break it apart to make it easier to review.
Should I close this PR and create smaller individual ones, or what would
you prefer?
…On Tue, Oct 7, 2025 at 3:26 PM Christian Byrne ***@***.***> wrote:
*christian-byrne* left a comment (Comfy-Org/ComfyUI_frontend#5929)
<#5929 (comment)>
Hi @fragmede <https://github.com/fragmede>, I wonder if we could break
this into smaller parts that consider each desired feature. For model
downloading, I think to get the real desired experience, we would need to
do it on the server and add parallelization, retry, chunking, mirror
handling, etc.
If there are other UI/UX improvements, would it be possible to extract the
underlying improvement and see if we can integrate it with the existing
system a bit?
BTW, is this extension currently available as a custom node?
—
Reply to this email directly, view it on GitHub
<#5929 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKEHHSFIIRVNGD6X2B4ZD3WQ42XAVCNFSM6AAAAACILDDEACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNZYHEZDEOBSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sure that sounds good, any feature in particular you want to add most? |
|
The base functionality is that it's uncomfortable for the user to have to
download a file to a specific place, and that the program can do it for
them. Everything on top of that is to make it more user friendly and
useful. So the smallest frontend change would be to have a button that hits
the backend API I added in the linked PR but which doesn't give any user
feedback.
…On Wed, Oct 8, 2025 at 12:20 Christian Byrne ***@***.***> wrote:
*christian-byrne* left a comment (Comfy-Org/ComfyUI_frontend#5929)
<#5929 (comment)>
Sure that sounds good, any feature in particular you want to add most?
—
Reply to this email directly, view it on GitHub
<#5929 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKEHBVEWAK7WORKSQRWML3WVPWBAVCNFSM6AAAAACILDDEACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOBSHA4TCNZQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an intuitive download system to the missing models dialog, allowing users to download required models directly from the ComfyUI interface with real-time progress tracking and download speed display.
Problem Solved
When users load workflows with missing models, they currently see a dialog listing the missing files but must:
This creates friction, especially for:
Solution
This PR enhances the missing models dialog with:
✨ User Experience Features
🎨 UI Implementation
🔒 Security Features
📁 Files Modified
src/extensions/core/missingModelsDownloader.ts- Core implementationRelated PR
Also see comfyanonymous/ComfyUI#10224
Features in Detail
Individual Download Buttons
Each missing model gets a download button that:
Download All Button
Progress Display Format
Visual States
Screenshots
Before
After
Integration
Works with the companion backend PR that provides:
/models/downloadAPI endpointsTesting
Tested scenarios:
Browser Compatibility
Tested on:
Performance
Related PR
See companion backend PR: ComfyUI#XXX for API implementation
Future Enhancements
Potential improvements for future iterations:
Note: This PR requires the companion backend PR to be merged for full functionality. The UI gracefully handles cases where the backend is not available.
┆Issue is synchronized with this Notion page by Unito