fix: Only add the listeners for DomWidget components once #5846
Conversation
dosubot
bot
added
the
size:M
🎭 Playwright Test Results⏰ Completed at: 09/29/2025, 08:38:28 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
There was a problem hiding this comment.
I would recommend testing this in normal usage - undo, redo, add/remove, subgraph in / out, workflow swaps, and in a decent size workflow (pan / zoom around and make some changes).
I can't recall the gotchas on this atm. I believe it was refactored during subgraph work (simpler?).
Okay, did a decent number of checks, nothing seemed to be broken. |
|
IIRC, I had edited this code for subgraphs. I just tested all the cases for which I was covering at the time -- everything still works per expectation. For the DOM widget promotion, there are also browser tests giving us coverage. It all looks good to me. |
AustinMroz
added
needs-backport
## Summary Fixes the laggy textarea select noted in Discord. ## Changes - **What**: Fixes the case where a DomWidget that was repeatedly made visible accumulated as many event listeners as times it was toggled on. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5846-fix-Only-add-the-listeners-for-DomWidget-components-once-27d6d73d3650818382e0d0c565fc862a) by [Unito](https://www.unito.io)
…once (#5849) Backport of #5846 to `core/1.27` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5849-backport-1-27-fix-Only-add-the-listeners-for-DomWidget-components-once-27d6d73d365081438673f970b0508032) by [Unito](https://www.unito.io) --------- Co-authored-by: Alexander Brown <[email protected]> Co-authored-by: github-actions <[email protected]>
## Summary Fixes the laggy textarea select noted in Discord. ## Changes - **What**: Fixes the case where a DomWidget that was repeatedly made visible accumulated as many event listeners as times it was toggled on. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5846-fix-Only-add-the-listeners-for-DomWidget-components-once-27d6d73d3650818382e0d0c565fc862a) by [Unito](https://www.unito.io)
## Summary Fixes the laggy textarea select noted in Discord. ## Changes - **What**: Fixes the case where a DomWidget that was repeatedly made visible accumulated as many event listeners as times it was toggled on. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5846-fix-Only-add-the-listeners-for-DomWidget-components-once-27d6d73d3650818382e0d0c565fc862a) by [Unito](https://www.unito.io)
5 participants
Summary
Fixes the laggy textarea select noted in Discord.
Changes
┆Issue is synchronized with this Notion page by Unito