Use localized labels for Vue node slots and inputs/outputs (fallback to names) #5773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
added
area:i18n
dosubot
bot
added
the
size:S
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 09/26/2025, 01:50:19 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
|
Test failures are expected (the text next to the widgets changed from the name to the label which changed the apperance of some UI baseline images): https://531ead11.comfyui-playwright-chromium.pages.dev/#?q=s:failed |
christian-byrne
added
the
New Browser Test Expectations
AustinMroz
previously approved these changes
Sep 25, 2025
DrJKL
previously approved these changes
Sep 25, 2025
Comment on lines
135
to
140
| name: widget.name, | ||
| type: widget.type, | ||
| value: widget.value, | ||
| label: widget.label, | ||
| options: widget.options, | ||
| callback: widget.callback |
There was a problem hiding this comment.
This looks like it could just use the spread operator.
There was a problem hiding this comment.
I believe it's extracting safe properties, otherwise private fields would be included.
christian-byrne
dismissed stale reviews from DrJKL and AustinMroz
via
e6300f8
True we have that tracked here: I think we can handle it easily in the next milestone (it's also in notion). |
christian-byrne
force-pushed
the
vue-nodes/translations
branch
from
e6300f8 to
d25ac60
Compare
christian-byrne
added
New Browser Test Expectations
christian-byrne
added a commit
that referenced
this pull request
Sep 27, 2025
…to names) (#5773) ## Summary Fixes #5697 by adding internationalization support for Vue node widget labels and output slot names with fallback to original names. ## Changes - **What**: Added `label` field to widget data structures and `localized_name` support for output slots - **Breaking**: None - all changes maintain backward compatibility with fallback to original names ## Review Focus Translation key resolution for node definitions and proper fallback chain for widget labels and slot names. ## Screenshots (if applicable) Observe that there is parity between Litegraph and Vue nodes w.r.t. localization of labels/names. <img width="3455" height="1417" alt="Screenshot from 2025-09-25 13-19-54" src="https://github.com/user-attachments/assets/93ee8fae-3671-4175-a941-6462f942d0f1" /> <img width="3455" height="1417" alt="Screenshot from 2025-09-25 13-19-38" src="https://github.com/user-attachments/assets/9573eb86-d74a-40ed-a0b5-e30afd3da6eb" /> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5773-Use-localized-labels-for-Vue-node-slots-and-inputs-outputs-fallback-to-names-2796d73d365081e08fb7d38464f4aa90) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Alexander Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5697 by adding internationalization support for Vue node widget labels and output slot names with fallback to original names.
Changes
labelfield to widget data structures andlocalized_namesupport for output slotsReview Focus
Translation key resolution for node definitions and proper fallback chain for widget labels and slot names.
Screenshots (if applicable)
Observe that there is parity between Litegraph and Vue nodes w.r.t. localization of labels/names.
┆Issue is synchronized with this Notion page by Unito