Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Sep 25, 2025

Summary

Added mute state support to Vue nodes with visual feedback and keyboard shortcut functionality.

Changes

  • What: Implemented mute state (mode 2) for Vue nodes with opacity styling and Ctrl+M hotkey support

Review Focus

Visual consistency between bypass and mute states, and keyboard shortcut conflict detection with existing hotkeys.

Test Coverage

  • Single node mute/unmute with Ctrl+M hotkey
  • Multi-selection mute/unmute operations
  • Visual state verification with opacity changes

Related

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 25, 2025
@github-actions
Copy link

github-actions bot commented Sep 25, 2025

🎭 Playwright Test Results

⚠️ Tests passed with flaky tests

⏰ Completed at: 09/25/2025, 07:32:58 PM UTC

📈 Summary

  • Total Tests: 462
  • Passed: 431 ✅
  • Failed: 0
  • Flaky: 2 ⚠️
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 424 / ❌ 0 / ⚠️ 2 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

Copy link
Collaborator

@AustinMroz AustinMroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-byrne christian-byrne merged commit 415ebfd into main Sep 25, 2025
29 checks passed
@christian-byrne christian-byrne deleted the vue-nodes/mute-state branch September 25, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:vue-migration size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants