Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Sep 19, 2025

Summary

Extension of #5659: Added optional chaining to NodeTooltip component to prevent TypeError when nodeDef is undefined for unknown node types.

Changes

Review Focus

Error handling for node types not found in nodeDefStore and tooltip display behavior for unrecognized nodes.

Fixes CLOUD-FRONTEND-STAGING-3N

Prevents TypeError when nodeDef is undefined for unknown node types.
Uses optional chaining (?.) to safely access nodeDef properties:
- description
- inputs
- outputs

Fixes CLOUD-FRONTEND-STAGING-3N

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@christian-byrne christian-byrne requested a review from a team as a code owner September 19, 2025 06:47
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 19, 2025
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

🎭 Playwright Test Results

All tests passed!

⏰ Completed at: 09/19/2025, 07:04:17 AM UTC

📈 Summary

  • Total Tests: 450
  • Passed: 421 ✅
  • Failed: 0
  • Flaky: 0
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 414 / ❌ 0 / ⚠️ 0 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@christian-byrne christian-byrne merged commit a17c74f into main Sep 19, 2025
25 checks passed
@christian-byrne christian-byrne deleted the fix/node-tooltip-undefined-nodedef-v2 branch September 19, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants