Slot functionality for vue nodes #5628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racking.ts Co-authored-by: AustinMroz <[email protected]>
…bserver sizing, centralized slot tracking, and small readability updates
…knip pre-push" This reverts commit 110ecf3.
… ResizeObserver sizing, centralized slot tracking, and small readability updates" This reverts commit 4287526.
…utilities - Rename parameters in useVueElementTracking for clarity (appIdentifier, trackingType) - Add comprehensive docstring with examples to prevent DOM attribute confusion - Extract mountLGraphNode test utility to eliminate repetitive mock setup - Add technical implementation notes documenting optimization decisions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…bserver sizing, centralized slot tracking, and small readability updates
I wrote it not long ago, and it was non functional as well, there's not much you can do with it, and it was only a simplification for renderLinkDirect anyway I've been meaning to remove it |
DrJKL
requested changes
Sep 19, 2025
src/renderer/extensions/vueNodes/composables/useSlotLinkInteraction.ts
Outdated
Show resolved
Hide resolved
christian-byrne
approved these changes
Sep 19, 2025
DrJKL
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for simple slot functionality in vue nodes mode.
Has:
Now:
After:
┆Issue is synchronized with this Notion page by Unito