LazyImage on Safari #5626
Merged
LazyImage on Safari #5626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d improve media caching strategy
dosubot
bot
added
the
size:S
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/17/2025, 08:01:00 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
arjansingh
approved these changes
Sep 17, 2025
|
What is the relation to Safari? |
Myestery
commented
Sep 18, 2025
Safari doesn't trigger load event in images like other chrome based browsers |
christian-byrne
approved these changes
Sep 18, 2025
christian-byrne
added
platform:macos
Myestery
added a commit
that referenced
this pull request
Sep 19, 2025
This pull request improves the lazy loading behavior and caching
strategy for images in the `LazyImage.vue` component. The most
significant changes are focused on optimizing image rendering and
resource management, as well as improving code clarity.
**Lazy loading behavior improvements:**
* Changed the `<img>` element to render only when `cachedSrc` is
available, ensuring that images are not displayed before they are ready.
* Updated watchers in `LazyImage.vue` to use clearer variable names
(`shouldLoadVal` instead of `shouldLoad`) for better readability and
maintainability.
[[1]](diffhunk://#diff-3a1bfa7eb8cb26b04bea73f7b4b4e3c01e9d20a7eba6c3738fb47f96da1a7c95L80-R81)
[[2]](diffhunk://#diff-3a1bfa7eb8cb26b04bea73f7b4b4e3c01e9d20a7eba6c3738fb47f96da1a7c95L96-R96)
**Caching strategy enhancement:**
* Modified the `fetch` call in `mediaCacheService.ts` to use `{ cache:
'force-cache' }`, which leverages the browser's cache more aggressively
when loading media, potentially improving performance and reducing
network requests.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-5626-LazyImage-on-Safari-2716d73d365081eeb1d3c2a96be4d408)
by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the lazy loading behavior and caching strategy for images in the
LazyImage.vuecomponent. The most significant changes are focused on optimizing image rendering and resource management, as well as improving code clarity.Lazy loading behavior improvements:
<img>element to render only whencachedSrcis available, ensuring that images are not displayed before they are ready.LazyImage.vueto use clearer variable names (shouldLoadValinstead ofshouldLoad) for better readability and maintainability. [1] [2]Caching strategy enhancement:
fetchcall inmediaCacheService.tsto use{ cache: 'force-cache' }, which leverages the browser's cache more aggressively when loading media, potentially improving performance and reducing network requests.┆Issue is synchronized with this Notion page by Unito