Move VueFire persistence configuration to initialization #5614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/17/2025, 02:41:59 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
|
Change detector tests detected changes. |
…B issues - Use VueFireAuthWithDependencies to set localStorage-first persistence order - Prevents "Connection to Indexed Database server lost" errors on iOS Safari - Remove obsolete persistence test since configuration moved to main.ts Fixes CLOUD-FRONTEND-STAGING-2J 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
dosubot
bot
added
size:M
DrJKL
approved these changes
Sep 17, 2025
Myestery
pushed a commit
that referenced
this pull request
Sep 19, 2025
Currently, we set persistence method in the auth store setup. This creates pattern of using the default on init (indexed DB) up until the firebase store is initialized and `setPersistence` is called. For devices that don't support indexed DB or have the connection aggresively terminated or cleared, like [Safari](https://comfy-org.sentry.io/issues/6879071102/?project=4509681221369857&query=is%3Aunresolved&referrer=issue-stream), this can create problems with maintaing auth persistence. Fix by setting persistence method in the initialization in main.ts ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5614-Move-VueFire-persistence-configuration-to-initialization-2716d73d3650817480e0c8feb1f37b9a) by [Unito](https://www.unito.io) --------- Co-authored-by: Claude <[email protected]>
christian-byrne
added a commit
that referenced
this pull request
Sep 23, 2025
…)" This reverts commit ea4e57b.
christian-byrne
added a commit
that referenced
this pull request
Sep 23, 2025
…) (#5729) ## Summary This reverts PR #5614 which moved VueFire persistence configuration to initialization. ## Reason for Revert It breaks Google SSO login with error: ``` useErrorHandling.ts:12 FirebaseError: Firebase: Error (auth/argument-error). at createErrorInternal (index-c92d61ad.js:506:41) at _assert (index-c92d61ad.js:512:15) at _withDefaultResolver (index-c92d61ad.js:9237:5) at signInWithPopup (index-c92d61ad.js:9457:30) at executeAuthAction.createCustomer (firebaseAuthStore.ts:263:25) at executeAuthAction (firebaseAuthStore.ts:223:28) at Proxy.loginWithGoogle (firebaseAuthStore.ts:262:5) at Proxy.wrappedAction (pinia.mjs:1405:26) at useFirebaseAuthActions.ts:104:28 at Object.signInWithGoogle (useErrorHandling.ts:39:22) ``` ## Changes - Reverts commit ea4e57b "Move VueFire persistence configuration to initialization (#5614)" - Restores previous Firebase auth persistence behavior ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5729-Revert-Move-VueFire-persistence-configuration-to-initialization-5614-2776d73d3650814c9b80d9c67c852874) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we set persistence method in the auth store setup. This creates pattern of using the default on init (indexed DB) up until the firebase store is initialized and
setPersistenceis called. For devices that don't support indexed DB or have the connection aggresively terminated or cleared, like Safari, this can create problems with maintaing auth persistence.Fix by setting persistence method in the initialization in main.ts
┆Issue is synchronized with this Notion page by Unito