[feat] Add tooltip support for Vue nodes #5577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/19/2025, 08:06:37 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
christian-byrne
force-pushed
the
feat/vue-node-tooltips
branch
from
f01ff8e to
2bf2c00
Compare
DrJKL
previously approved these changes
Sep 16, 2025
src/renderer/extensions/vueNodes/composables/useNodeTooltips.ts
Outdated
Show resolved
Hide resolved
christian-byrne
dismissed stale reviews from DrJKL and AustinMroz
via
5b672cb
christian-byrne
force-pushed
the
feat/vue-node-tooltips
branch
from
d9f4788 to
850ae0e
Compare
AustinMroz
previously approved these changes
Sep 17, 2025
DrJKL
previously approved these changes
Sep 17, 2025
src/renderer/extensions/vueNodes/composables/useNodeTooltips.ts
Outdated
Show resolved
Hide resolved
christian-byrne
dismissed stale reviews from DrJKL and AustinMroz
via
4e50c3a
christian-byrne
force-pushed
the
feat/vue-node-tooltips
branch
2 times, most recently
from
4e50c3a to
aae097b
Compare
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Implements comprehensive tooltip functionality for all Vue node components: - Node headers display node descriptions from definitions - Input/output slots show slot-specific tooltip information - Widgets display tooltip text from metadata and node definitions - Uses PrimeVue's v-tooltip directive with container scoping - Integrates with existing settings (Comfy.EnableTooltips, LiteGraph.Node.TooltipDelay) - Provides fallback content when no tooltip data is available - Full TypeScript support with proper interfaces
- Input slots and widgets: show tooltips on right (auto-fallback to left) - Output slots: show tooltips on left (auto-fallback to right) - Improves UX by not covering connection areas and using horizontal space better
- Use Tailwind classes via pt.text and pt.arrow for clean styling - Match Figma specs: dark background (#171718), purple border (#5B5E7D) - Fix tooltip positioning: inputs show left, outputs show right - Proper arrow styling with before:border-[#171718] for chevron shape
…iew feedback Co-authored-by: DrJKL <[email protected]>
…s review feedback Co-authored-by: DrJKL <[email protected]>
…ar cursor - addresses review feedback Co-authored-by: DrJKL <[email protected]>
…review feedback Co-authored-by: DrJKL <[email protected]>
…oltips outside node boundaries Co-authored-by: DrJKL <[email protected]>
… review feedback Co-authored-by: DrJKL <[email protected]>
…view feedback Co-authored-by: DrJKL <[email protected]>
Allow passing either string or ref for more flexible API usage. Co-Authored-By: DrJKL <[email protected]>
Use standard Tailwind class instead of arbitrary value. Co-Authored-By: DrJKL <[email protected]>
christian-byrne
force-pushed
the
feat/vue-node-tooltips
branch
from
a38d428 to
9fe3e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added tooltip support for Vue node components using PrimeVue's v-tooltip directive with proper data integration and container scoping.
2025-09-14.22-57-04_processed_20250914_225745.mp4
Changes
Review Focus
Container scoping implementation via provide/inject pattern for tooltip positioning, proper TypeScript interfaces eliminating
as anycasts, and integration with existing settings store for tooltip delays and enable/disable functionality.graph TD A[LGraphNode Container] --> B[provide tooltipContainer] B --> C[NodeHeader inject] B --> D[InputSlot inject] B --> E[OutputSlot inject] B --> F[NodeWidgets inject] G[useNodeTooltips composable] --> H[NodeDefStore lookup] G --> I[Settings integration] G --> J[i18n fallback] C --> G D --> G E --> G F --> G style A fill:#f9f9f9,stroke:#333,color:#000 style G fill:#e8f4fd,stroke:#0066cc,color:#000