[test] Add component test for image compare widget #5549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/16/2025, 09:34:02 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
previously approved these changes
Sep 16, 2025
|
|
||
| import WidgetImageCompare from './WidgetImageCompare.vue' | ||
|
|
||
| interface ImageCompareValue { |
There was a problem hiding this comment.
Is this interface available in the component itself?
There was a problem hiding this comment.
Exported the ImageCompareValue interface directly from the component and updated the test to import it instead of duplicating - see commit 63d6a61
| describe('WidgetImageCompare Display', () => { | ||
| const createMockWidget = ( | ||
| value: ImageCompareValue | string, | ||
| options: Partial<ImageCompareProps> = {} |
There was a problem hiding this comment.
Suggested change
| options: Partial<ImageCompareProps> = {} | |
| options: SimplifiedWidget['options'] = {} |
There was a problem hiding this comment.
Changed Partial<ImageCompareProps> to SimplifiedWidget['options'] for consistency with the actual component interface - see commit 63d6a61
| }) | ||
|
|
||
| it('handles empty object value', () => { | ||
| const value = {} as ImageCompareValue |
There was a problem hiding this comment.
Added proper typing for the empty object test case - see commit 63d6a61
…g - addresses review feedback - Export ImageCompareValue interface from component for reuse - Update test to import interface instead of duplicating it - Replace Partial<ImageCompareProps> with SimplifiedWidget['options'] for consistency - Add proper typing for empty object test case Co-authored-by: DrJKL <[email protected]>
Reduced test duplication by consolidating similar test cases: - Combined 3 basic rendering tests into comprehensive structure test - Merged alt text tests into single parameterized test - Consolidated URL handling tests (long URLs, special chars, data/blob URLs) - Unified template structure verification into single test Reduces test count from 25 to 15 while maintaining full coverage. Provides clearer failure signals by grouping related assertions. Co-authored-by: DrJKL <[email protected]>
|
Consolidated overlapping tests from 25 to 15 tests, maintaining full coverage while providing clearer failure signals - see commit 87cb782 |
christian-byrne
deleted the
vue-nodes/test/image-compare-component-test
branch
Myestery
pushed a commit
that referenced
this pull request
Sep 19, 2025
## Summary Added comprehensive component test suite for WidgetImageCompare widget with 410 test assertions covering display, edge cases, and integration scenarios. ## Changes - **What**: Created [Vue Test Utils](https://vue-test-utils.vuejs.org/) test suite for [WidgetImageCompare component](src/renderer/extensions/vueNodes/widgets/components/WidgetImageCompare.vue) using [Vitest](https://vitest.dev/) testing framework ## Review Focus Test coverage completeness for string vs object value handling, accessibility attribute propagation, and edge case robustness including malformed URLs and empty states. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5549-test-Add-component-test-for-image-compare-widget-26e6d73d365081189fe0d010f87d1eec) by [Unito](https://www.unito.io) --------- Co-authored-by: DrJKL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added comprehensive component test suite for WidgetImageCompare widget with 410 test assertions covering display, edge cases, and integration scenarios.
Changes
Review Focus
Test coverage completeness for string vs object value handling, accessibility attribute propagation, and edge case robustness including malformed URLs and empty states.
┆Issue is synchronized with this Notion page by Unito