Skip to content

Conversation

@snomiao
Copy link
Member

@snomiao snomiao commented Sep 8, 2025

Summary

  • Added complete Turkish language translation for ComfyUI Frontend
  • Integrated Turkish locale into the i18n system
  • Added Turkish as a selectable language option in settings

Implementation Details

  • Added Turkish translation files provided by @naxci1:
    • src/locales/tr/main.json - Main UI translations
    • src/locales/tr/commands.json - Command translations
    • src/locales/tr/nodeDefs.json - Node definitions translations
    • src/locales/tr/settings.json - Settings translations
  • Updated src/i18n.ts to import and register Turkish locale
  • Added Turkish option to language selector in src/constants/coreSettings.ts

Test Plan

  • Verify Turkish translations load correctly
  • Test language switching to/from Turkish
  • Check all UI elements display properly in Turkish
  • Verify node descriptions and tooltips in Turkish
  • Test command palette in Turkish

Fixes #5437

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

🎭 Playwright Test Results

All tests passed!

⏰ Completed at: 09/18/2025, 12:37:18 PM UTC

📈 Summary

  • Total Tests: 450
  • Passed: 421 ✅
  • Failed: 0
  • Flaky: 0
  • Skipped: 29 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 414 / ❌ 0 / ⚠️ 0 / ⏭️ 29
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Prettier formatting

@snomiao snomiao marked this pull request as ready for review September 10, 2025 01:51
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 10, 2025
@naxci1
Copy link

naxci1 commented Sep 17, 2025

Hi, are the tests finished? Are there any problems? When will it be added to the main code? Thank you.

@snomiao snomiao force-pushed the 5437-i-request-that-the-turkish-language-be-added branch from 4a4a138 to 6245378 Compare September 18, 2025 07:13
- Added Turkish translations for main UI, settings, commands, and node definitions
- Updated i18n configuration to include Turkish locale (tr)
- Added Turkish language option to settings menu
@snomiao snomiao force-pushed the 5437-i-request-that-the-turkish-language-be-added branch from 6245378 to b272a9f Compare September 18, 2025 12:26
@snomiao
Copy link
Member Author

snomiao commented Sep 18, 2025

Hi, are the tests finished? Are there any problems? When will it be added to the main code? Thank you.

Hi @naxci1, thank you for providing i18n files, all tests are passed, this PR are pending for more code-reviews, thank you for patients : D

@christian-byrne christian-byrne added area:i18n Anything related to translation claude-review Add to trigger a PR code review from Claude Code labels Sep 19, 2025
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comprehensive PR Review

This review is generated by Claude. It may not always be accurate, as with human reviewers. If you believe that any of the comments are invalid or incorrect, please state why for each. For others, please implement the changes in one way or another.

Review Summary

PR: feat: Add Turkish language support (#5438)
Impact: 11,200 additions, 4 deletions across 77 files

Issue Distribution

  • Critical: 1
  • High: 0
  • Medium: 2
  • Low: 1

Category Breakdown

  • Architecture: 2 issues
  • Security: 1 issue
  • Performance: 0 issues
  • Code Quality: 2 issues

Key Findings

Architecture & Design

Major Concern: This PR violates the single responsibility principle by conflating Turkish translation with extensive refactoring. The PR description claims to add Turkish language support but includes 77 file changes with major architectural modifications, file moves (renderer→composables), Firebase auth changes, ESLint config changes, and more. This should be split into separate focused PRs.

File Organization: The move of useCanvasInteractions from renderer/core/canvas to composables/graph changes architectural boundaries. While composables are meant for reusable logic, this move needs validation that it aligns with the intended architecture.

Security Considerations

Firebase Auth Persistence: The removal of explicit Firebase auth persistence configuration in main.ts is concerning. The original code specifically configured localStorage → sessionStorage → IndexedDB ordering for mobile Safari compatibility. Removing this configuration without justification may break authentication persistence on certain browsers.

Performance Impact

No significant performance issues identified in the Turkish translation files themselves. However, the scope of changes makes it difficult to properly assess performance impact of the refactoring components.

Integration Points

Test Coverage: A test file (WidgetImageCompare.test.ts) was deleted while the component remains, potentially reducing test coverage.

ESLint Configuration: Removes TypeScript import rules for test files, which could lead to inconsistent code style in tests.

Positive Observations

  • Turkish translation files follow correct i18n patterns with proper native language text (Türkçe)
  • Import path updates appear consistent where the file moves occurred
  • Translation integration in i18n.ts and settings follows established patterns

References

Next Steps

  1. CRITICAL: Split this PR into focused changes:
    • PR 1: Turkish translation only (5-6 files: i18n.ts, coreSettings.ts, .i18nrc.cjs, tr/ folder)
    • PR 2: Architectural refactoring and file moves
    • PR 3: Firebase auth changes (if needed)
  2. Address the Firebase auth persistence configuration issue
  3. Fix invalid GPT model name in i18n config
  4. Restore deleted test file or provide justification
  5. Ensure ESLint configuration maintains code quality standards

This is a comprehensive automated review. For architectural decisions requiring human judgment, please request additional manual review.

@christian-byrne christian-byrne merged commit 553b5aa into main Sep 19, 2025
29 checks passed
@christian-byrne christian-byrne deleted the 5437-i-request-that-the-turkish-language-be-added branch September 19, 2025 02:43
@dosubot dosubot bot mentioned this pull request Oct 20, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Anything related to translation claude-review Add to trigger a PR code review from Claude Code size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I request that the Turkish language be added.

3 participants