-
Couldn't load subscription status.
- Fork 390
feat: Add Turkish language support #5438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Turkish language support #5438
Conversation
🎭 Playwright Test Results✅ All tests passed! ⏰ Completed at: 09/18/2025, 12:37:18 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
|
Hi, are the tests finished? Are there any problems? When will it be added to the main code? Thank you. |
4a4a138 to
6245378
Compare
- Added Turkish translations for main UI, settings, commands, and node definitions - Updated i18n configuration to include Turkish locale (tr) - Added Turkish language option to settings menu
6245378 to
b272a9f
Compare
Hi @naxci1, thank you for providing i18n files, all tests are passed, this PR are pending for more code-reviews, thank you for patients : D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comprehensive PR Review
This review is generated by Claude. It may not always be accurate, as with human reviewers. If you believe that any of the comments are invalid or incorrect, please state why for each. For others, please implement the changes in one way or another.
Review Summary
PR: feat: Add Turkish language support (#5438)
Impact: 11,200 additions, 4 deletions across 77 files
Issue Distribution
- Critical: 1
- High: 0
- Medium: 2
- Low: 1
Category Breakdown
- Architecture: 2 issues
- Security: 1 issue
- Performance: 0 issues
- Code Quality: 2 issues
Key Findings
Architecture & Design
Major Concern: This PR violates the single responsibility principle by conflating Turkish translation with extensive refactoring. The PR description claims to add Turkish language support but includes 77 file changes with major architectural modifications, file moves (renderer→composables), Firebase auth changes, ESLint config changes, and more. This should be split into separate focused PRs.
File Organization: The move of useCanvasInteractions from renderer/core/canvas to composables/graph changes architectural boundaries. While composables are meant for reusable logic, this move needs validation that it aligns with the intended architecture.
Security Considerations
Firebase Auth Persistence: The removal of explicit Firebase auth persistence configuration in main.ts is concerning. The original code specifically configured localStorage → sessionStorage → IndexedDB ordering for mobile Safari compatibility. Removing this configuration without justification may break authentication persistence on certain browsers.
Performance Impact
No significant performance issues identified in the Turkish translation files themselves. However, the scope of changes makes it difficult to properly assess performance impact of the refactoring components.
Integration Points
Test Coverage: A test file (WidgetImageCompare.test.ts) was deleted while the component remains, potentially reducing test coverage.
ESLint Configuration: Removes TypeScript import rules for test files, which could lead to inconsistent code style in tests.
Positive Observations
- Turkish translation files follow correct i18n patterns with proper native language text (Türkçe)
- Import path updates appear consistent where the file moves occurred
- Translation integration in i18n.ts and settings follows established patterns
References
- Repository Architecture Guide: https://github.com/Comfy-Org/comfy-claude-prompt-library/blob/master/project-summaries-for-agents/ComfyUI_frontend/REPOSITORY_GUIDE.md
- Frontend Standards: https://github.com/Comfy-Org/comfy-claude-prompt-library/blob/master/.claude/commands/validation/frontend-code-standards.md
- Security Guidelines: https://github.com/Comfy-Org/comfy-claude-prompt-library/blob/master/.claude/commands/validation/security-audit.md
Next Steps
- CRITICAL: Split this PR into focused changes:
- PR 1: Turkish translation only (5-6 files: i18n.ts, coreSettings.ts, .i18nrc.cjs, tr/ folder)
- PR 2: Architectural refactoring and file moves
- PR 3: Firebase auth changes (if needed)
- Address the Firebase auth persistence configuration issue
- Fix invalid GPT model name in i18n config
- Restore deleted test file or provide justification
- Ensure ESLint configuration maintains code quality standards
This is a comprehensive automated review. For architectural decisions requiring human judgment, please request additional manual review.
Summary
Implementation Details
src/locales/tr/main.json- Main UI translationssrc/locales/tr/commands.json- Command translationssrc/locales/tr/nodeDefs.json- Node definitions translationssrc/locales/tr/settings.json- Settings translationssrc/i18n.tsto import and register Turkish localesrc/constants/coreSettings.tsTest Plan
Fixes #5437
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito