[fix] Remove useDefineForClassFields from tsconfig

[snomiao]

Summary

Remove the useDefineForClassFields compiler option from tsconfig.json to fix Playwright test configuration compatibility issues.

Changes

• Removed useDefineForClassFields: true from tsconfig.json

Test plan

• CI/CD tests pass
• Playwright tests run successfully
• Build completes without errors

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

[github-actions]

🎭 Playwright Test Results

✅ All tests passed across all browsers!

⏰ Completed at: 09/04/2025, 10:35:08 PM UTC

📊 Test Reports by Browser

---

🎉 Your tests are passing across all browsers!

[christian-byrne]

In the spec, it says this is set to true if the target is ES2022, which ours is.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	uuid@​11.1.0
	semver@​7.7.2
	typescript@​5.9.2

View full report

[snomiao]

Analysis of i18n Playwright Test Failure

The Update Locales workflow is failing with the error:

SyntaxError: TypeScript 'declare' fields must first be transformed by @babel/plugin-transform-typescript

Root Cause

The i18n collection scripts (scripts/collect-i18n-*.ts) are importing TypeScript source files directly and executing them in Node.js context during Playwright tests. This bypasses the normal Vite build pipeline and instead relies on Playwright's TypeScript compilation, which uses Babel under the hood.

Why This Happens

1. Direct imports: The i18n scripts import TypeScript modules like ../src/constants/coreMenuCommands directly
2. Babel transformation: Playwright uses Babel to transform TypeScript, not the TypeScript compiler (tsc)
3. Missing plugin configuration: Babel needs @babel/plugin-transform-typescript to handle declare fields, but it must run before class property plugins

The Issue with declare Fields

When useDefineForClassFields: false was removed from tsconfig.json, TypeScript now uses declare for class fields that shouldn't be initialized. However, Babel's plugin order matters - the TypeScript plugin must process declare fields before class property transformations.

Possible Solutions

1. Configure Babel for Playwright (recommended): Add a babel config specifically for Playwright tests that ensures correct plugin order
2. Re-add useDefineForClassFields: true: Explicitly set this in tsconfig to avoid declare fields
3. Refactor i18n scripts: Avoid importing TypeScript source files directly, use compiled outputs instead
4. Update Playwright's TypeScript handling: Configure Playwright to use tsc instead of Babel

The TypeScript and Playwright version updates (5.9.2 and 1.55.0) are working correctly for the main test suite - the issue is specific to how the i18n collection scripts compile TypeScript.

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		[email protected] has Obfuscated code. Confidence: 0.94 Location: Package overview From: pnpm-lock.yaml → npm/[email protected] → npm/[email protected] ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected]. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[snomiao]

close this as the solution is similar to - refactor: Remove TypeScript declare keywords for Playwright compatibility by snomiao · Pull Request #5304 · Comfy-Org/ComfyUI_frontend