[fix] Fix collect-i18n script compilation error with TypeScript declare fields #5287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re fields The collect-i18n script was failing with babel transformer error when encountering TypeScript declare fields in litegraph classes. Root cause: - Playwright internal TypeScript compilation does not handle declare fields properly - i18n test files imported ComfyNodeDefImpl which imports litegraph types Solution: - Move i18n tests to browser_tests/tests/ with .spec.ts extension - Remove direct imports of types that reference litegraph - Process node definitions in browser context where types are available - Use nx e2e command for consistency with other browser tests Fixes regression introduced after Nx integration
🎨 Storybook Build Status❌ Build failed! ⏰ Completed at: 08/31/2025, 03:30:10 PM UTC 🔗 Links |
🎭 Playwright Test Results✅ All tests passed across all browsers! ⏰ Completed at: 08/31/2025, 03:52:26 PM UTC 📊 Test Reports by Browser🎉 Your tests are passing across all browsers! |
|
close this as not necessary anymore because we solved locale workflow problem here: - fix(collect-i18n-node-defs): refactor to run ComfyNodeDefImpl only in browser context by snomiao · Pull Request #5775 · Comfy-Org/ComfyUI_frontend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pnpm collect-i18nscript failing with TypeScript compilation errordeclarefields in litegraph classesProblem
The collect-i18n script was failing with:
Root Cause
declarefields in classesdeclarefields that Playwright's babel transformer can't processSolution
scripts/i18n/with separateplaywright.i18n.config.tsgrepInvert: /@mobile|collect-i18n/to exclude i18n tests from regular CI runspnpm collect-i18nwhen server is runningTest Plan
pnpm collect-i18n- completes without TypeScript compilation errorspnpm test:browser(0 found)Changes
package.json: Use separate playwright config for i18n collectionplaywright.config.ts: Exclude collect-i18n tests from regular CI runsplaywright.i18n.config.ts: Separate config for i18n testsscripts/i18n/directory🤖 Generated with Claude Code