Skip to content

Conversation

@snomiao
Copy link
Member

@snomiao snomiao commented Aug 26, 2025

Summary

• Extended safe-to-fail pattern to all CI comment and deploy steps across workflows
• Added continue-on-error: true to 8 total steps preventing GitHub API issues from blocking CI
• Completes the implementation started in PR #5156 with comprehensive coverage

Changes Made

This PR includes three progressive commits building a complete solution:

1. Comment Steps (d5fed56)

Added continue-on-error: true to 6 comment steps:

chromatic.yaml

  • Comment PR - Build Started (line 35)
  • Comment PR - Build Complete (line 72)

test-ui.yaml

  • Comment PR - Tests Started (line 50)
  • Comment PR - Browser Test Started (line 138)
  • Comment PR - Browser Test Complete (line 244)
  • Comment PR - Tests Complete (line 330)

2. Deploy Steps (a8c48b6)

Added continue-on-error: true to 1 deploy step:

test-ui.yaml

  • Deploy to Cloudflare Pages (line 185)

3. Lint Workflow Comments (1c9933d) - NEW

Added continue-on-error: true to 2 additional comment steps:

lint-and-format.yaml

  • Comment on PR about auto-fix (line 63)
  • Comment on PR about manual fix needed (line 76)

Problem Solved

CI workflows were failing when GitHub API token permissions prevented PR commenting or deployment operations. This blocked essential testing and linting processes even though commenting/deployment are not critical for core functionality.

Impact

All testing continues even if comments fail
All linting continues even if comments fail
All deployments continue even if they fail
Better developer experience - no failed CI due to non-critical API issues
Comprehensive coverage across all workflows
Consistent pattern applied everywhere

Test Plan

  • Validated YAML syntax for all modified workflows
  • Confirmed essential workflow logic remains unchanged
  • Core functionality (tests, linting, deployments) preserved
  • Test with PR to verify CI workflows complete successfully with comment/deploy failures

Fixes #5149

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

@snomiao snomiao requested a review from a team as a code owner August 26, 2025 12:43
@github-actions
Copy link

github-actions bot commented Aug 26, 2025

🎭 Playwright Test Results

All tests passed across all browsers!

⏰ Completed at: 08/26/2025, 04:00:27 PM UTC

📊 Test Reports by Browser


🎉 Your tests are passing across all browsers!

@snomiao
Copy link
Member Author

snomiao commented Aug 26, 2025

let sno rebase to origin/main and update pr descriptions

@snomiao
Copy link
Member Author

snomiao commented Aug 26, 2025

Rebase to origin/main completed successfully!

Rebase Progress Checklist

  • Reply to comment with todo list for rebase task
  • Fetch latest changes from origin/main
  • Rebase current branch onto origin/main
  • Resolve any merge conflicts if they arise
  • Run tests to verify changes still work
  • Push the rebased changes
  • Update tracking comment with completion status

Summary

  • Successfully rebased branch issue-5149-ci-chromatic-comment-should-be-safe-to-fail onto origin/main
  • Branch is now up to date with latest changes from main branch
  • No merge conflicts encountered during rebase
  • Changes have been pushed to the remote branch
  • Current commit: 3dee9f97 [ci] Make lint-and-format comment steps safe to fail

The PR is ready for review and merge! 🚀

snomiao and others added 2 commits August 26, 2025 12:46
Add continue-on-error: true to Deploy to Cloudflare Pages step to prevent
Cloudflare API issues from blocking essential testing processes.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Add continue-on-error: true to PR comment steps in lint workflow:
- Comment on PR about auto-fix (line 63)
- Comment on PR about manual fix needed (line 76)

This prevents GitHub API permission errors from blocking
essential linting processes while maintaining comment functionality.
@snomiao snomiao force-pushed the issue-5149-ci-chromatic-comment-should-be-safe-to-fail branch from 1c9933d to 3dee9f9 Compare August 26, 2025 12:50
@christian-byrne christian-byrne merged commit 8646ca4 into main Aug 26, 2025
14 of 17 checks passed
@christian-byrne christian-byrne deleted the issue-5149-ci-chromatic-comment-should-be-safe-to-fail branch August 26, 2025 16:25
@christian-byrne christian-byrne mentioned this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci] Chromatic comment should be safe to fail

3 participants