[ci] Complete implementation of safe-to-fail CI steps #5210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
• Extended safe-to-fail pattern to all CI comment and deploy steps across workflows
• Added
continue-on-error: trueto 8 total steps preventing GitHub API issues from blocking CI• Completes the implementation started in PR #5156 with comprehensive coverage
Changes Made
This PR includes three progressive commits building a complete solution:
1. Comment Steps (d5fed56)
Added
continue-on-error: trueto 6 comment steps:chromatic.yaml
test-ui.yaml
2. Deploy Steps (a8c48b6)
Added
continue-on-error: trueto 1 deploy step:test-ui.yaml
3. Lint Workflow Comments (1c9933d) - NEW
Added
continue-on-error: trueto 2 additional comment steps:lint-and-format.yaml
Problem Solved
CI workflows were failing when GitHub API token permissions prevented PR commenting or deployment operations. This blocked essential testing and linting processes even though commenting/deployment are not critical for core functionality.
Impact
✅ All testing continues even if comments fail
✅ All linting continues even if comments fail
✅ All deployments continue even if they fail
✅ Better developer experience - no failed CI due to non-critical API issues
✅ Comprehensive coverage across all workflows
✅ Consistent pattern applied everywhere
Test Plan
Fixes #5149
🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito