Skip to content

[types] Add proper types for ImportFailInfo API endpoints #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

[types] Add proper types for ImportFailInfo API endpoints #4783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/services/comfyManagerService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import { ref } from 'vue'

import { api } from '@/scripts/api'
import {
type ImportFailInfoBulkRequest,
type ImportFailInfoBulkResponse,
type InstallPackParams,
type InstalledPacksResponse,
type ManagerPackInfo,
Expand Down Expand Up @@ -157,12 +159,12 @@ export const useComfyManagerService = () => {
}

const getImportFailInfoBulk = async (
params: { cnr_ids?: string[]; urls?: string[] } = {},
params: ImportFailInfoBulkRequest = {},
signal?: AbortSignal
) => {
const errorContext = 'Fetching bulk import failure information'

return executeRequest<Record<string, any>>(
return executeRequest<ImportFailInfoBulkResponse>(
() =>
managerApiClient.post(ManagerRoute.IMPORT_FAIL_INFO_BULK, params, {
signal
Expand Down
11 changes: 11 additions & 0 deletions src/types/comfyManagerTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type { InjectionKey, Ref } from 'vue'
import type { ComfyWorkflowJSON } from '@/schemas/comfyWorkflowSchema'
import type { AlgoliaNodePack } from '@/types/algoliaTypes'
import type { components } from '@/types/comfyRegistryTypes'
import type { components as managerComponents } from '@/types/generatedManagerTypes'
import type { SearchMode } from '@/types/searchServiceTypes'

type WorkflowNodeProperties = ComfyWorkflowJSON['nodes'][0]['properties']
Expand Down Expand Up @@ -242,3 +243,13 @@ export interface ManagerState {
searchMode: SearchMode
sortField: string
}

/**
* Types for import failure information API
*/
export type ImportFailInfoBulkRequest =
managerComponents['schemas']['ImportFailInfoBulkRequest']
export type ImportFailInfoBulkResponse =
managerComponents['schemas']['ImportFailInfoBulkResponse']
export type ImportFailInfoItem =
managerComponents['schemas']['ImportFailInfoItem']