Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Jun 4, 2025

Summary

  • document Algolia env vars for new custom node manager

Testing

  • npm run format
  • npm run lint
  • npm run typecheck
  • npm run test:unit
  • npm run test:component
  • npm run test:browser (fails: Set TEST_COMFYUI_DIR in .env to prevent user data from being overwritten)

https://chatgpt.com/codex/tasks/task_e_68404795db708330ad581eca1b96b1d6

┆Issue is synchronized with this Notion page by Unito

@benceruleanlu
Copy link
Member Author

AFAIK the APP ID and Search-specific key can both be public facing, could we just add it plaintext to .env_example?

@christian-byrne
Copy link
Contributor

AFAIK the APP ID and Search-specific key can both be public facing, could we just add it plaintext to .env_example?

Seems fine to me. Will make one less hurdle when onboard new people or for OS dev.

@benceruleanlu benceruleanlu marked this pull request as ready for review June 4, 2025 23:51
@benceruleanlu benceruleanlu requested a review from a team as a code owner June 4, 2025 23:51
@webfiltered webfiltered merged commit defea56 into main Jun 5, 2025
10 checks passed
@webfiltered webfiltered deleted the codex/add-algolia_app_id-and-algolia_api_key-to-.env_example branch June 5, 2025 00:39
lordTyrion pushed a commit to playbook3d/ComfyUI_frontend that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants