Update to new card design #4065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webfiltered
reviewed
Jun 5, 2025
webfiltered
reviewed
Jun 5, 2025
webfiltered
approved these changes
Jun 5, 2025
christian-byrne
requested changes
Jun 5, 2025
Comment on lines
+419
to
+434
| const pack = selectedNodePack.value | ||
| if (!pack?.id) return | ||
| if (hasMultipleSelections.value) return | ||
| const data = await getPackById.call(selectedNodePack.value.id) | ||
| if (data?.id === selectedNodePack.value?.id) { | ||
| // If selected node hasn't changed since request, merge registry & Algolia data | ||
| selectedNodePacks.value = [merge(selectedNodePack.value, data)] | ||
| // Only fetch if we haven't already for this pack | ||
| if (lastFetchedPackId.value === pack.id) return | ||
| const data = await getPackById.call(pack.id) | ||
| // If selected node hasn't changed since request, merge registry & Algolia data | ||
| if (data?.id === pack.id) { | ||
| lastFetchedPackId.value = pack.id | ||
| const mergedPack = merge({}, pack, data) | ||
| selectedNodePacks.value = [mergedPack] | ||
| // Replace pack in displayPacks so that children receive a fresh prop reference | ||
| const idx = displayPacks.value.findIndex((p) => p.id === mergedPack.id) | ||
| if (idx !== -1) { | ||
| displayPacks.value.splice(idx, 1, mergedPack) | ||
| } |
There was a problem hiding this comment.
Can you verify using Network tab in dev tools that this caching is necessary? The getPackById should already be wrapped with useCachedRequest which handles request caching / deduplication. Although in general this doesn't really hurt to add, so not a big deal.
There was a problem hiding this comment.
apart from caching, it also prevents an infinite loop issue I had, it should be OK to ship as is, not too important
This reverts commit 228b4d4.
This was referenced Jun 14, 2025
lordTyrion
pushed a commit
to playbook3d/ComfyUI_frontend
that referenced
this pull request
Jul 2, 2025
Co-authored-by: filtered <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR affects the new manager, by changing the design of the new manager's cards to be up to date with the latest Figma reference.
However, please note that banner_url and github stars are both missing from this PR. They'll both be added in a future patch, once the backend is updated.
┆Issue is synchronized with this Notion page by Unito